From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87157C61DA4 for ; Mon, 30 Jan 2023 11:04:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 217406B0074; Mon, 30 Jan 2023 06:04:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1C6EE6B0075; Mon, 30 Jan 2023 06:04:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 068F26B0078; Mon, 30 Jan 2023 06:04:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id E6C8E6B0074 for ; Mon, 30 Jan 2023 06:04:17 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id B68151C5951 for ; Mon, 30 Jan 2023 11:04:17 +0000 (UTC) X-FDA: 80411181354.15.5FD8C61 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf27.hostedemail.com (Postfix) with ESMTP id 7C37C40009 for ; Mon, 30 Jan 2023 11:04:15 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=fail ("headers rsa verify failed") header.d=ibm.com header.s=pp1 header.b=BVYZyNfv; dmarc=pass (policy=reject) header.from=ibm.com; spf=pass (imf27.hostedemail.com: domain of Alexander.Egorenkov@ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=Alexander.Egorenkov@ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675076655; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:in-reply-to:references:dkim-signature; bh=jeb7QWeBepJL9ZapzbeROcrKlwVo4gdD3ekHCiMD/zo=; b=CPHWWQ+jfTP8hfGBaIfS+qoXiMVrS3Hvk38URDsqJLJqCj4R+sk5by97K84sB+jCpeq5FN xXBTDPeWCCy0q4hI78ayMQKR+e3elrTMyaRsn+yjU2zlZrEmc6ELvF+DFG60dNdzrm+IRx xedfDGwOUVYJHCAiWXnV15O4Nlpv5JY= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=fail ("headers rsa verify failed") header.d=ibm.com header.s=pp1 header.b=BVYZyNfv; dmarc=pass (policy=reject) header.from=ibm.com; spf=pass (imf27.hostedemail.com: domain of Alexander.Egorenkov@ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=Alexander.Egorenkov@ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675076655; a=rsa-sha256; cv=none; b=5JkxBVgzDEXLDKHwZgWM9tDFpXllHJW9ERlo/SNoZOQnr19IkdKzwJrFR0TMLakH+SiaYq qSYUOhWQ885iofflSoxbl1AuU8yvI3xDDbEDXkkOE1F6r7oxBoEurBbJJ6SzHPiE2EpGXL 9sSofDTQ3Cx9N8Dz+gA77sZLSvAhMhw= Received: from pps.filterd (m0098417.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 30UAT89s018611; Mon, 30 Jan 2023 11:04:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : cc : subject : in-reply-to : in-reply-to : date : message-id : mime-version : content-type : content-transfer-encoding; s=pp1; bh=jeb7QWeBepJL9ZapzbeROcrKlwVo4gdD3ekHCiMD/zo=; b=BVYZyNfvzNHCKq8oQeB7zpbT5eeYH/5GZsvvTIF37aZHt6ATqrGpaVp94/UUQt0WFt/8 brLXxKhtqJf+PfEvfAnk4ff7ynvVV1b0Lx92xMz9Kxg6bwlTUx3MXHeJQhe9TYwFR0n6 QlzP7IPZCfjl/2Uggc5cVWDK7DFHxWdWwiil0BOi1joiFzamc/rTug5nKuhx77hNQ5gp DOnmGd18UWXV0tfqwgSwRCZ1RmXIv+n14Ei+goxGu09vKw9ZUZeHB8ALLvOIdIHxRbeH h624zlXO2ybICiUk7A2Z+JRTmj+E85oFPYy31gewQkfkjiZX6k6qVqi6xbdlxxLPlKm3 2A== Received: from ppma05fra.de.ibm.com (6c.4a.5195.ip4.static.sl-reverse.com [149.81.74.108]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3nec6cgrp0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 30 Jan 2023 11:04:05 +0000 Received: from pps.filterd (ppma05fra.de.ibm.com [127.0.0.1]) by ppma05fra.de.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 30T8B1LZ016468; Mon, 30 Jan 2023 11:04:03 GMT Received: from smtprelay01.fra02v.mail.ibm.com ([9.218.2.227]) by ppma05fra.de.ibm.com (PPS) with ESMTPS id 3ncvt7hh3j-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 30 Jan 2023 11:04:03 +0000 Received: from smtpav03.fra02v.mail.ibm.com (smtpav03.fra02v.mail.ibm.com [10.20.54.102]) by smtprelay01.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 30UB414M51577180 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 30 Jan 2023 11:04:01 GMT Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 598762004B; Mon, 30 Jan 2023 11:04:01 +0000 (GMT) Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 339BA20040; Mon, 30 Jan 2023 11:04:01 +0000 (GMT) Received: from localhost (unknown [9.171.84.174]) by smtpav03.fra02v.mail.ibm.com (Postfix) with ESMTP; Mon, 30 Jan 2023 11:04:01 +0000 (GMT) From: Alexander Egorenkov To: willy@infradead.org Cc: akpm@linux-foundation.org, hch@infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Cc: Subject: Re: [PATCH 2/2] mpage: Convert __mpage_writepage() to use a folio more fully In-Reply-To: <20230126201255.1681189-3-willy@infradead.org> In-Reply-To: Date: Mon, 30 Jan 2023 12:04:00 +0100 Message-ID: <878rhk707z.fsf@oc8242746057.ibm.com> MIME-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: fe0j-r8KUss-8L4481DpZi9zH1dgrc6Z X-Proofpoint-GUID: fe0j-r8KUss-8L4481DpZi9zH1dgrc6Z X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1 definitions=2023-01-30_10,2023-01-30_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 priorityscore=1501 phishscore=0 mlxlogscore=478 impostorscore=0 spamscore=0 suspectscore=0 clxscore=1011 adultscore=0 malwarescore=0 lowpriorityscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2301300101 X-Rspamd-Queue-Id: 7C37C40009 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: mt47pg7e4x41f3sigg9eb1hm1xcktw6d X-HE-Tag: 1675076655-209933 X-HE-Meta: U2FsdGVkX19fNEJwyWKghvLjXQQtUS5wz6LVOZ7MRaVh1KdwmunhT1fv1OTZNxd6AyQziKbIRWb4uFB5OaYjN9mQtdYQDNJPxywg4GudqLSuj8pfSjq38nOx9VX/4UAJG7RXr7MSzbCsdAht7rGpbzMoxZLcsooYVr3qSpMHY1KeIb0swlaPsmriSTq8t1kF/b0GWTPoBN0R1V+MbnMdiOaTUSaBgo2P2dOz/l9sO3H4i6aPhG2Uo+Qbnub7b/1lHBE6XFmcN6tuyjvZHGHKcHwrJTnXkmh+xiq4V0vNzkN7i7St1PgtAK7/+nnzRASYOghrqrANgQVsA5kJcRA+rdvDdbFY4g9cmVeHXJ+CSc6WukLPM2AkHKiU/wRycAAqjCRGQQjM14LWQ+OUKW0+/O6Oc/RZLxy6x3d+Ua2j+B7noKqTnsSzFtpRUDDs7gVqN+/k2MNcWMdFLuGoAV0iVO+UYwliXcOVoVQkYvGNAn5P9153XQqVTsb1RDdeSFTXSN2vlbQgA+emmPA6PZzQyPCvKGuYZ9TbK/s/6z+77oWb2mFLDGONCIsMupLsjjV12n6jwLCFg50QK5RiIwhceYwxHyXqtEMLl895kij5RP0n15qBwsZa9OFHgyVbA8HY1218h9ChXboygCEdubjX0MDGP4PXTnARYl5UnqQzeEvdCV/IHx2gk0F0FfxpEMFFwBB7yGheeHqzKWQ/9chfT4Ne9G707x7UyaXyzVI4tV+4yeDwl91lWSgwgg5FCzpunuKraZ10d0K5xnx585Nm46SZVlOpW0RZggitQlsbYfLQMV+N+D08nPaahz1a1TFNHLMHooGgHb06FHE2uscTX/BLExUvZ+AF4Ba3tjtgl2uEotInRXNtsZYSJqejq4Vmo0ia8pEeSXny9a7IQBNdHzooWazGzk/XupUJCkBAj+AvtoIQkJHYt/fdRWLwI35eBDhknz5XZFjxFU632jE E9tgGH2x YI3mvuWnFoC8GcRa7G8lyECjx79EI0eLT9fXtYVCKg8w21q+fXiYnRBat0Fcguy7siV8uC9ymsB+ZsNWS3DT1hQ5W3G852kvNjhDh95MzUL64S8aUnVc6/nAHWXwQ1ZFm4KlbmUKZkL5w3PfUSg5N3UCa6LTmvh59lts50XgDDSY/4X6yRaA+1pxpngOp9RIcjw/KAG212KCSv7RVYVJBP8ZY+c9LB9+iJkREXr1CAHExQcgdP5QCUW3fH5+svff2o5yqED4Jgr1C0/SOtMJPapK5cg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000151, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi, after this change we see a WARNING on s390 linux-next with LTP tests (write= v03). RELEASE: 6.2.0-20230129.rc5.git1.e2f86c02fdc9.300.fc37.s390x+next [ 5577.900868] BTRFS: device fsid 4127fc5b-a6b3-44ff-927d-7bfc5163686e de= vid 1 transid 6 /dev/loop0 scanned by mkfs.btrfs (2502327) [ 5577.901186] BTRFS info (device loop0): using crc32c (crc32c-vx) checks= um algorithm [ 5577.901192] BTRFS info (device loop0): using free space tree [ 5577.901847] BTRFS info (device loop0): enabling ssd optimizations [ 5577.901850] BTRFS info (device loop0): auto enabling async discard [ 5577.901895] BTRFS info (device loop0): checking UUID tree [ 5620.655695] ------------[ cut here ]------------ [ 5620.655702] WARNING: CPU: 6 PID: 2404385 at fs/mpage.c:570 __mpage_wri= tepage+0x79c/0x7b0 [ 5620.655711] Modules linked in: xt_state(E) quota_v2(E) quota_tree(E) t= un(E) nls_utf8(E) overlay(E) nls_iso8859_1(E) nls_cp437(E) ntfs(E) exfat(E)= vfat(E) fat(E) loop(E) sctp(E) ip6_udp_tunnel(E) udp_tunnel(E) kunit(E) af= _packet_diag(E) unix_diag(E) mptcp_diag(E) xfrm_user(E) xfrm_algo(E) crypto= _user(E) tcp_diag(E) inet_diag(E) netlink_diag(E) algif_hash(E) af_alg(E) d= m_service_time(E) nft_fib_inet(E) nft_fib_ipv4(E) nft_fib_ipv6(E) nft_fib(E= ) nft_reject_inet(E) nf_reject_ipv4(E) nf_reject_ipv6(E) nft_reject(E) nft_= ct(E) nft_chain_nat(E) nf_nat(E) nf_conntrack(E) nf_defrag_ipv6(E) nf_defra= g_ipv4(E) ip_set(E) nf_tables(E) nfnetlink(E) sunrpc(E) zfcp(E) scsi_transp= ort_fc(E) s390_trng(E) vfio_ccw(E) mdev(E) vfio_iommu_type1(E) vfio(E) sch_= fq_codel(E) ip6_tables(E) ip_tables(E) x_tables(E) configfs(E) ghash_s390(E= ) prng(E) chacha_s390(E) libchacha(E) aes_s390(E) des_s390(E) libdes(E) sha= 3_512_s390(E) sha3_256_s390(E) sha512_s390(E) sha256_s390(E) sha1_s390(E) s= ha_common(E) scsi_dh_rdac(E) scsi_dh_emc(E) scsi_dh_alua(E) [ 5620.655763] pkey(E) zcrypt(E) rng_core(E) dm_multipath(E) autofs4(E) [ 5620.655778] Unloaded tainted modules: init_module(OE):3 finit_module(O= E):3 dummy_del_mod_dep(OE):1 dummy_del_mod(OE):2 test_unwind(E):1 test_modu= les(E):1 test_kprobes_s390(E):1 test_kprobes(E):1 klp_tc_17_livepatch(OEK):= 1 klp_tc_16_livepatch(OEK):1 klp_tc_15_livepatch(OEK):1 klp_tc_14_livepatch= (OEK):1 klp_tc_13_livepatch(OEK):1 klp_tc_12_livepatch(OEK):1 klp_tc_11_liv= epatch(OEK):1 klp_test_support_mod(OE):8 klp_tc_10_livepatch(OEK):1 klp_tc_= 8_5_livepatch(OEK):1 klp_tc_8_4_livepatch(OEK):1 klp_tc_8_3_livepatch(OEK):= 1 klp_tc_8_2_livepatch(OEK):1 klp_tc_8_1_livepatch(OEK):1 klp_tc_6_livepatc= h(OEK):1 klp_tc_5_1_livepatch(OEK):1 klp_tc_5_2_livepatch(OEK):1 klp_tc_5_3= _livepatch(OEK):1 klp_tc_5_4_livepatch(OEK):1 klp_tc_5_5_livepatch(OEK):1 k= lp_tc_5_6_livepatch(OEK):1 klp_tc_5_7_livepatch(OEK):1 klp_tc_5_8_livepatch= (OEK):1 klp_tc_5_9_livepatch(OEK):1 klp_tc_5_10_livepatch(OEK):1 klp_tc_5_1= 1_livepatch(OEK):1 klp_tc_5_12_livepatch(OEK):1 klp_tc_5_13_livepatch(OEK):= 1 klp_tc_5_14_livepatch(OEK):1 klp_tc_5_15_livepatch(OEK):1 [ 5620.655806] klp_tc_3_livepatch(OEK):1 [last unloaded: init_module(OE)] [ 5620.655815] CPU: 6 PID: 2404385 Comm: kworker/u128:8 Tainted: G = OE K N 6.2.0-20230129.rc5.git1.e2f86c02fdc9.300.fc37.s390x+next #1 [ 5620.655818] Hardware name: IBM 3931 A01 704 (z/VM 7.3.0) [ 5620.655820] Workqueue: writeback wb_workfn (flush-7:0) [ 5620.655861] Krnl PSW : 0704c00180000000 0000000077704118 (__mpage_writ= epage+0x7a0/0x7b0) [ 5620.655866] R:0 T:1 IO:1 EX:1 Key:0 M:1 W:0 P:0 AS:3 CC:0 P= M:0 RI:0 EA:3 [ 5620.655869] Krnl GPRS: 0000000000000000 0000000000001000 0000000000000= 000 0000000000000000 [ 5620.655872] 0000038000000001 00000001ce688000 0000000000000= 000 0000037200000009 [ 5620.655874] 00000380004cb970 0000000000000000 0000038000000= 001 0000037203a01d80 [ 5620.655877] 00000000855f2100 0000000000000000 0000000000000= 000 00000380004cb660 [ 5620.655885] Krnl Code: 000000007770410c: a7181000 lhi %r1= ,4096 0000000077704110: a7f4fe34 brc 15,= 0000000077703d78 #0000000077704114: af000000 mc 0,0 >0000000077704118: a7f4fccc brc 15,= 0000000077703ab0 000000007770411c: af000000 mc 0,0 0000000077704120: d70010001000 xc 0(1= ,%r1),0(%r1) 0000000077704126: 0707 bcr 0,%= r7 0000000077704128: c00400497b2c brcl 0,0= 000000078033780 [ 5620.655905] Call Trace: [ 5620.655907] [<0000000077704118>] __mpage_writepage+0x7a0/0x7b0 [ 5620.655911] [<00000000775c9df0>] write_cache_pages+0x1b0/0x418 [ 5620.655916] [<0000000077703824>] mpage_writepages+0x64/0xb0 [ 5620.655918] [<00000000775cb416>] do_writepages+0x66/0x1d0 [ 5620.655921] [<00000000776ee14c>] __writeback_single_inode+0x4c/0x410 [ 5620.655925] [<00000000776eea2a>] writeback_sb_inodes+0x232/0x5a0 [ 5620.655928] [<00000000776eedf2>] __writeback_inodes_wb+0x5a/0x138 [ 5620.655931] [<00000000776ef140>] wb_writeback+0x270/0x3a0 [ 5620.655934] [<00000000776f04e0>] wb_workfn+0x370/0x5b8 [ 5620.655936] [<00000000773daab8>] process_one_work+0x200/0x458 [ 5620.655940] [<00000000773db246>] worker_thread+0x66/0x490 [ 5620.655942] [<00000000773e4098>] kthread+0x108/0x110 [ 5620.655944] [<000000007736736c>] __ret_from_fork+0x3c/0x58 [ 5620.655947] [<0000000077fecb6a>] ret_from_fork+0xa/0x40 [ 5620.655952] Last Breaking-Event-Address: [ 5620.655953] [<0000000077703d2e>] __mpage_writepage+0x3b6/0x7b0 [ 5620.655956] Kernel panic - not syncing: kernel: panic_on_warn set ... [ 5620.655958] CPU: 6 PID: 2404385 Comm: kworker/u128:8 Tainted: G = OE K N 6.2.0-20230129.rc5.git1.e2f86c02fdc9.300.fc37.s390x+next #1 [ 5620.655961] Hardware name: IBM 3931 A01 704 (z/VM 7.3.0) [ 5620.655962] Workqueue: writeback wb_workfn (flush-7:0) [ 5620.655965] Call Trace: [ 5620.655966] [<0000000077fdd01a>] dump_stack_lvl+0x62/0x80 [ 5620.655970] [<0000000077fcb658>] panic+0x118/0x300 [ 5620.655973] [<00000000773b5d80>] check_panic_on_warn+0x70/0x88 [ 5620.655977] [<00000000773b6028>] __warn+0x108/0x150 [ 5620.655979] [<0000000077fa06da>] report_bug+0xba/0x140 [ 5620.655983] [<00000000773651a4>] monitor_event_exception+0x44/0x80 [ 5620.655985] [<0000000077fdd218>] __do_pgm_check+0xf0/0x1b0 [ 5620.655988] [<0000000077feccbc>] pgm_check_handler+0x11c/0x170 [ 5620.655991] [<0000000077704118>] __mpage_writepage+0x7a0/0x7b0 [ 5620.655993] [<00000000775c9df0>] write_cache_pages+0x1b0/0x418 [ 5620.655995] [<0000000077703824>] mpage_writepages+0x64/0xb0 [ 5620.655998] [<00000000775cb416>] do_writepages+0x66/0x1d0 [ 5620.656000] [<00000000776ee14c>] __writeback_single_inode+0x4c/0x410 [ 5620.656003] [<00000000776eea2a>] writeback_sb_inodes+0x232/0x5a0 [ 5620.656006] [<00000000776eedf2>] __writeback_inodes_wb+0x5a/0x138 [ 5620.656010] [<00000000776ef140>] wb_writeback+0x270/0x3a0 [ 5620.656012] [<00000000776f04e0>] wb_workfn+0x370/0x5b8 [ 5620.656014] [<00000000773daab8>] process_one_work+0x200/0x458 [ 5620.656016] [<00000000773db246>] worker_thread+0x66/0x490 [ 5620.656019] [<00000000773e4098>] kthread+0x108/0x110 [ 5620.656020] [<000000007736736c>] __ret_from_fork+0x3c/0x58 [ 5620.656023] [<0000000077fecb6a>] ret_from_fork+0xa/0x40 crash> q Regards Alex