From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F21B3C001DC for ; Mon, 31 Jul 2023 16:35:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 703456B0127; Mon, 31 Jul 2023 12:35:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 68C616B0128; Mon, 31 Jul 2023 12:35:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 52F1B6B0129; Mon, 31 Jul 2023 12:35:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 40FC26B0127 for ; Mon, 31 Jul 2023 12:35:43 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id F38AA40A5D for ; Mon, 31 Jul 2023 16:35:42 +0000 (UTC) X-FDA: 81072458124.21.586ED1F Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by imf19.hostedemail.com (Postfix) with ESMTP id 3A9DB1A0016 for ; Mon, 31 Jul 2023 16:35:40 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=gG5PHgDz; dkim=pass header.d=linutronix.de header.s=2020e header.b=7DpKt2xK; dmarc=pass (policy=none) header.from=linutronix.de; spf=pass (imf19.hostedemail.com: domain of tglx@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=tglx@linutronix.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690821341; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=w/WJW32x1qpjSrgwv/AAuxytdw2s82fSnUhy8yQ0iVg=; b=RbNNJMjVbrLOqNAeACWJEXeZAlXuyOelJMv2VToxnDZCD2VYFIKgEn3+Bawg2RZNXJDpFj Kb1oGIrysdcM9g+c8Rhem7orNblKPXxJE/gyi35f2OyWUkL3F2B4R/YuBQTAF+bmb/AT7S BKPlLHyZLGaWm+6US4YsQCv2J5nTJWw= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=gG5PHgDz; dkim=pass header.d=linutronix.de header.s=2020e header.b=7DpKt2xK; dmarc=pass (policy=none) header.from=linutronix.de; spf=pass (imf19.hostedemail.com: domain of tglx@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=tglx@linutronix.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690821341; a=rsa-sha256; cv=none; b=f6x9Vp3yTCMfKsk4k4jK7VODivi5amFP1iwZZW1Xz0RFpO+OVMmzX3rj4UePH3uezh5Bai jgMSaBqntVlvwEkL7GpgvRJrV2RpXgkuumGbX4Uga6RWXDv0FlyL0Mdn7/a/FuiLETSu4a kJfR9+xGZIr2FbNK4jUcTY257DvmXVU= From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1690821339; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=w/WJW32x1qpjSrgwv/AAuxytdw2s82fSnUhy8yQ0iVg=; b=gG5PHgDz/pQLCINjkJVxFk/Lmh2saQ0xr/dYg023WFuBOb1tuHcIdKlev6rU1fcajxhC/c 7J5Y34yCUxvqjzX13AjHUsHc3DDkt3qf926ZoFklrlwQCCg9Elv/PElmmz3DMqQiyhdNLW cFqKlRSPA4J1/9ExUUROa/ipSEg0ZXDqWk79TtUG3XAGPfEps6z7LHLNPcNmFZ/jRUXjhB piF9VV20VhoNGtPHm3X3zNO6YqOzhJh40VZIeZNCCiML5NnSkzA/fRwNwm77hoizMTQJqV bAGuGGLkOiLos2y3j13EyHXL3rZWl5u4JKqY//nNoO+POnu+Zqe5rhvQMHluRQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1690821339; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=w/WJW32x1qpjSrgwv/AAuxytdw2s82fSnUhy8yQ0iVg=; b=7DpKt2xKwu1n51Wog9rodhsvt2OqNWsi2Lrx9ASOJTOogoqgG3Z5zg8QLxSQD/eOs0Rg8p 9y47YPsNlwDzdnBg== To: Peter Zijlstra , axboe@kernel.dk Cc: linux-kernel@vger.kernel.org, peterz@infradead.org, mingo@redhat.com, dvhart@infradead.org, dave@stgolabs.net, andrealmeid@igalia.com, Andrew Morton , urezki@gmail.com, hch@infradead.org, lstoakes@gmail.com, Arnd Bergmann , linux-api@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, malteskarupke@web.de Subject: Re: [PATCH v1 06/14] futex: Add sys_futex_wait() In-Reply-To: <20230721105744.090372309@infradead.org> References: <20230721102237.268073801@infradead.org> <20230721105744.090372309@infradead.org> Date: Mon, 31 Jul 2023 18:35:38 +0200 Message-ID: <878rawnin9.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 3A9DB1A0016 X-Stat-Signature: jzaw4eqq8zqzztrrd9mw8tyzed7q17ho X-Rspam-User: X-HE-Tag: 1690821340-440997 X-HE-Meta: U2FsdGVkX1+NDbz4F7ixOf1Eg9tl7rji+Tus7VhifYrEZ9om9LHXcMP6W9q8Zgj2cA1b3EqGuWcBrGKL916ybo0m9yU4XV7gt0B4tl3xTsH/Dps6vXu+bPb0Us+NMNal8v1O249m9Amr+S13RphYv+CrsXQ897yIJZM5ub/qF5CyT5okriBA3A1RhjJG1hcuoI8mUOKG+/dQEnD4HBfA7kP9ebLDJYQwSxb6abXIUdjRe4A3MLvxU3Bm8LoEi1Tka8rB38kpmhJXjk0kKWCIpMbgHBnSuntTUCl10MAOpK5uvzTJZ7kmAiXgugDVCnOYiNqInQwlYrF+CbZNQET6Q3v+qMtR0iWF8UX0BZd8N8m/iWYWFlZfMwndpuUkGGqNPeCmBooMrO9pL+8bc687Nl/6AsjxqIyK+/JmZqp3X534AjkFKNJnAkM7AhVXcfqvgOVxSqXjZcvXmXi3MGkjHuW25x+btogRQGtY+1/aNaCEo/BstVMoL4i4ci3dyJJizedhOTkdlQGaTYlhUqAK+SAAqFMszpwCOPbnKlkQL7U4al3x/HXDBSfRIMBx41aF9SG91oxFvCIt4u9tVyEq6BmITN8b19hXbp4lrxA8iN5zNG44RIcAyFaHM2szeelPUw5NCeDmFXbTtf1vGlYri6kK3KZ8F8bp7HseL+ZFCSzYvUy6MUD/xGjrVRwgXRgT/q8H4q9V6Ol2pxCT+FRm82QP/dsVlqjR1cYgcK4EnTP+ZuXsEw34B7K2IOI9lIOyzr1mU9CpMxw/zxN0Grl3786rnfgS5X6rzg+Zp6w21gHmbz+FFpF8dGBuftOCnPdbaMlefvoAO3Zhmf5cOYvuSsLh0TkFOKhOVC0RBNjJ/OMwD+BxJbRlzkeWMVVwWKBBUOyl0jeRRmBlTTlA8cMtxeV6QAjWkeZUBWDFVNYyY7I/NZ7P4ZbKLNsdVGuuARpsqd1bYoBTR4MlC8x8g6z H7QHHw52 spxUwWBNpIeBm1xWo4eZrpUH1nyPVhjoD49WtfkAZrih0sG0OV81amB/xJwA+uUQGjzwov3L0GTJA9j95LNGU1sGBCfFhYRj45R5e X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jul 21 2023 at 12:22, Peter Zijlstra wrote: > +int futex_wait(u32 __user *uaddr, unsigned int flags, u32 val, ktime_t *abs_time, u32 bitset) > +{ > + struct hrtimer_sleeper timeout, *to; > + struct restart_block *restart; > + int ret; > + > + to = futex_setup_timer(abs_time, &timeout, flags, > + current->timer_slack_ns); > + > + ret = __futex_wait(uaddr, flags, val, to, bitset); > + if (!to) > + return ret; Can you please put an empty new line and a comment between the __futex_wait() and the if (!to) check? The original code was less obfuscated. Other than that: Reviewed-by: Thomas Gleixner