From: Alistair Popple <apopple@nvidia.com>
To: Alistair Popple <apopple@nvidia.com>
Cc: Dan Williams <dan.j.williams@intel.com>,
linux-mm@kvack.org, jhubbard@nvidia.com, rcampbell@nvidia.com,
willy@infradead.org, jgg@nvidia.com, david@fromorbit.com,
linux-fsdevel@vger.kernel.org, jack@suse.cz, djwong@kernel.org,
hch@lst.de, david@redhat.com, ruansy.fnst@fujitsu.com
Subject: Re: ZONE_DEVICE refcounting
Date: Thu, 21 Mar 2024 16:26:42 +1100 [thread overview]
Message-ID: <878r2c6t99.fsf@nvdebian.thelocal> (raw)
In-Reply-To: <87y1ad776c.fsf@nvdebian.thelocal>
Alistair Popple <apopple@nvidia.com> writes:
> Dan Williams <dan.j.williams@intel.com> writes:
>
>> Alistair Popple wrote:
>
> I also noticed folio_anon() is not safe to call on a FS DAX page due to
> sharing PAGE_MAPPING_DAX_SHARED.
Also it feels like I could be missing something here. AFAICT the
page->mapping and page->index fields can't actually be used outside of
fs/dax because they are overloaded for the shared case. Therefore
setting/clearing them could be skipped and the only reason for doing so
is so dax_associate_entry()/dax_disassociate_entry() can generate
warnings which should never occur anyway. So all that code is
functionally unnecessary.
I guess that makes sense because DAX pages aren't in the pagecache or
LRU and therefore nothing tries to look them up via the normal
rmap. Does that sounds about right or did I miss something?
- Alistair
next prev parent reply other threads:[~2024-03-21 5:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-08 4:24 Alistair Popple
2024-03-08 13:44 ` Jason Gunthorpe
2024-03-13 6:32 ` Dan Williams
2024-03-20 5:20 ` Alistair Popple
2024-03-21 5:26 ` Alistair Popple [this message]
2024-03-21 6:03 ` Dan Williams
2024-03-22 0:01 ` Alistair Popple
2024-03-22 3:18 ` Dave Chinner
2024-03-22 5:34 ` Alistair Popple
2024-03-22 6:58 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878r2c6t99.fsf@nvdebian.thelocal \
--to=apopple@nvidia.com \
--cc=dan.j.williams@intel.com \
--cc=david@fromorbit.com \
--cc=david@redhat.com \
--cc=djwong@kernel.org \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=jgg@nvidia.com \
--cc=jhubbard@nvidia.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rcampbell@nvidia.com \
--cc=ruansy.fnst@fujitsu.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox