From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0D9AC3064D for ; Tue, 2 Jul 2024 10:16:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4170D6B00A3; Tue, 2 Jul 2024 06:16:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3A55C6B00A5; Tue, 2 Jul 2024 06:16:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1CFC96B00A7; Tue, 2 Jul 2024 06:16:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id F1FD66B00A3 for ; Tue, 2 Jul 2024 06:16:04 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 60714122034 for ; Tue, 2 Jul 2024 10:16:04 +0000 (UTC) X-FDA: 82294407048.15.3C821ED Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on2073.outbound.protection.outlook.com [40.107.96.73]) by imf12.hostedemail.com (Postfix) with ESMTP id 8C2D140014 for ; Tue, 2 Jul 2024 10:16:00 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=tS8lmnx9; spf=pass (imf12.hostedemail.com: domain of apopple@nvidia.com designates 40.107.96.73 as permitted sender) smtp.mailfrom=apopple@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719915350; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ICw05VyKde2TUCoMeJFHf8NJYprjtlFMk0GWFuhjzHc=; b=RpbcOCob8dmr0yaYe+PHHI7+ferEUIOS+1ScqKQ4EgTDJIf3wK03cR4otApBl2W+3IuhKF RdeWKHV0RAMRa7HaDgxCV2gK1KiEBHq/amH/C9CteAVXs1Tvxtz5Cpt6NTy6/O8RmBDxEa P4rT65BjGqdncwb1CEfjneKJ2PsRVBw= ARC-Authentication-Results: i=2; imf12.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=tS8lmnx9; spf=pass (imf12.hostedemail.com: domain of apopple@nvidia.com designates 40.107.96.73 as permitted sender) smtp.mailfrom=apopple@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1719915350; a=rsa-sha256; cv=pass; b=WS4ts55fBcJAL0m41eHymgr3Sau4vQmHnQe9QQjy1gklgu381AFkndn4J8oux74enKvaWR g6Y3+1RIxPgjlswdiudUtHRxHLnnOO4QGw1nsDeYthQGCEQsDqwYFnpRgHrWbOVFTOOZCI Lpj7eWOnLB4RwoGpm3n2zlg61iI9HVQ= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Xz55sef0dfJb1+gF5LH7sSOIkewT5VSYZ2sZ6Odro7B3pdCpc7J638nvP28C2AWJcwZj6tKqnMW4owpbqO3xK+QOdBx8W9vGl9Oyme6V9xIaWZ0J5W/uLniO4vq5jAnau2FXfrbbFFI8iOzNraanWmxjIRhgUY6t9LRx97WOLGHLNmf31+TdoklNq+PKkPxqwu4dMAjD4VT4Yk4kAFEcOIGctMkW/MRi76qvrhHIjUVAKeIa7dlqJ89uC/f3hwl+D5RxRV9lnauw5gC6yPREzY/E6llLNqnEzZJK/p/MrUP8eBKxyqndB4Z4q9f5wDFcERVpmR1qzayKzBF+tA1JMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ICw05VyKde2TUCoMeJFHf8NJYprjtlFMk0GWFuhjzHc=; b=Eyo9aD8kabiaE2PGeq4i36M/leML1pjiHudAtbfO3o9NUwEK2Mhf4qIOMiwDlUq9K9qGe1gfN4Anw9uDQkfWUxQQWZFxFuqdz98NYheKW/OMierEnuwuihGtE5BDLTcLrRikGJ/L4DjecgRuQCT5jD0JGQP4rLuhCIlfIjQjdKS4kgQr293Ugyq3B48HAddsZ3ordAjSGu+PtL71gathg7YtR0oznlWPfY2B2Rt+mKjMiH8KKAT7ztOym0lpViugLBmJLnsDi1+10hX/xMO1Ib30kFCkD1QlvRm9GCEUsceO+i8KLWFI9cE5twkalGmVMztbbpjUGGC0U4pNVjNcZw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ICw05VyKde2TUCoMeJFHf8NJYprjtlFMk0GWFuhjzHc=; b=tS8lmnx9eJYZdApDmHAfxuAs8olESrimLxmFCRZF9zYztV7PFUWu5L46juyv9VpzJVP4JHyhoJEUv7KQW6eN/Cr7s3/zD2IuY4hR56FkxJDfxXyKztv44DDfz+8lRwPGJdIL+pGNXFz99azQXBL9Qlw+NQTbv5IU8ocKwG4wvsynwn41vdWy8/vaQHtcGZDOYzWlog/z84pBSGEi+cC0GPTcbK6GnyWJd72Cd6opLUHWZQgpMLpnRkvPFgz5MHJ+M5HwNOUzVS3+rDSSuS2As86vg8wt9MyQ2sYCjkD9423lgCAb6RbgaEkF9q3FhuLMy18NaXGVBXT7eS8cFLYcHw== Received: from DS0PR12MB7726.namprd12.prod.outlook.com (2603:10b6:8:130::6) by MW6PR12MB9019.namprd12.prod.outlook.com (2603:10b6:303:23f::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7741.23; Tue, 2 Jul 2024 10:15:56 +0000 Received: from DS0PR12MB7726.namprd12.prod.outlook.com ([fe80::953f:2f80:90c5:67fe]) by DS0PR12MB7726.namprd12.prod.outlook.com ([fe80::953f:2f80:90c5:67fe%6]) with mapi id 15.20.7741.017; Tue, 2 Jul 2024 10:15:56 +0000 References: <20240702072327.1640911-1-hch@lst.de> User-agent: mu4e 1.10.8; emacs 29.1 From: Alistair Popple To: Christoph Hellwig Cc: akpm@linux-foundation.org, linux-mm@kvack.org Subject: Re: [PATCH] mm: unexport vmf_insert_mixed_mkwrite Date: Tue, 02 Jul 2024 20:13:28 +1000 In-reply-to: <20240702072327.1640911-1-hch@lst.de> Message-ID: <878qykgkvc.fsf@nvdebian.thelocal> Content-Type: text/plain X-ClientProxiedBy: SY0PR01CA0016.ausprd01.prod.outlook.com (2603:10c6:10:1bb::19) To DS0PR12MB7726.namprd12.prod.outlook.com (2603:10b6:8:130::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR12MB7726:EE_|MW6PR12MB9019:EE_ X-MS-Office365-Filtering-Correlation-Id: 8434a7ea-cafc-4fc1-808d-08dc9a7ff65d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?shCGFPeJZKz/gAmlLXNMi6q+N15nbS5r81jQmCHB4lIVapZdsxgck/YG/cZX?= =?us-ascii?Q?yCFvJmhpZuOmWD3sBGs++k13U52u2DXI67GpsjmwzuwqxhR1pAz4ADEZoN6w?= =?us-ascii?Q?/v8+5J4EHMjx2geOBvbNmZCzHZcGgJxQA+q7MVrl+w0+DQiHXUtWUxTQM7x7?= =?us-ascii?Q?tXLm/m7iD9RghJxY63wQBWqffZM+AR5H0eXZmQnvxe9wweSRSZgQQEzqtN6A?= =?us-ascii?Q?hPli6sOmQzdhSV43qPw82cOCosuYxiXdtoKRUOmGb0LTIy/vtYIwwL1eAI67?= =?us-ascii?Q?rAp4fFiHjQt53xHW+Ed8y0cZp2BYK5s7Dx47hhqqKWr1YGtUjtL38XABdLgw?= =?us-ascii?Q?jSWN5TnUJy4oZ/A1/Wb7k7GjvHEcwVzFXQohGaGGNWvMBBD4GYG5kI55NWQ2?= =?us-ascii?Q?YFzoOJzYFaz/hxd4n7ysMz/hSWXznWvvYiH10qtQhPlaUBQ3IRYniIT2HA/j?= =?us-ascii?Q?SqJPBoZEf6I//M4oDqucXPzjWhWA6mZaeVqENhx7D9YWWYBUAYDKRmegU1hR?= =?us-ascii?Q?eZeqe6To5U2GCPLxfvrKG9CYfCPqdNXPb65Zx9Cpv2KrOGCmNeP44t3cfKSK?= =?us-ascii?Q?k91Oq0zK74RBVlf5zgUtUQX6EN8aRsytcBuQIO6jMqYcdGgH0fEXKeITJZ2x?= =?us-ascii?Q?/1XBjrrR1I0Mp6M4L+B4ZoipWXul57RM8Q5i5E2sdx2E+pF729rCCSA/zCf3?= =?us-ascii?Q?gFsT/jSlyZA4WjfRdrflNYXzIowRxponybheVagHbu9xVchvWwzjkv738LA4?= =?us-ascii?Q?KY5uhacgrJT3GlGzZVYNTT4yMWt+PKT0YrJyUHNISsf6GtkOII6zocnY4TnN?= =?us-ascii?Q?PkQHbg8PPvzO4t0LoUbtmTKqyU4eenfA+Z8znsJPhbVCFNnOB+yWXf863DUv?= =?us-ascii?Q?EeZDIZA44ufQqaYJ1+9fUFKOnL+HnabRHyLNB7IlzqH6DOjXkwBvJihfnVUj?= =?us-ascii?Q?qMJ1rYDxwdqwnC5A/3j4SpHZ9nRVF0nBCU+uE+/VTRjgEsR/J2ddf1t9Udgy?= =?us-ascii?Q?qv+ALA0r5Z/SKsGX2pTerXClcmyrOanccR5N24zjqicfWjsxZWJYNHm+lD/m?= =?us-ascii?Q?h5fHedAVZMf2nL6GFQaXOsf3GRbE3ynvU2HObtM1qBLJEfEvdSRaAMIxCt5T?= =?us-ascii?Q?jL83nf/mDJTeNjVmrvu291lzqFIWa4/mxRB1xIk2FfuG24IUVoyvYkDGbsU7?= =?us-ascii?Q?KWJpfNMJAl5wEmcG8FfxbVqywL/WWvbwId+h0FbZRIRS+K94r3iA5129NQAR?= =?us-ascii?Q?SYP9NlAHUujfsfMmZgZpIAqgWFv+x94S37opoFgRCQVhp87e7aBhs2IEb36e?= =?us-ascii?Q?55o4DnzXUQJKQJG/HIA2tVY2WPMHZnDVS6cSKxV6+rEndA=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR12MB7726.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(1800799024)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ZlEiPufxhYE8r/VwrUM7M/qtGOlV02jOOQHj7JtqxsqLqukBEhVHqk4krquf?= =?us-ascii?Q?BkL4dUFeSnj+3bdSmXObZGEnAo/n0WMn8hTCtu2LMmQIgxZ5N2UVH1LaLoh9?= =?us-ascii?Q?zVNGXuZQACR2eC2rBdsK2zTfar2neG4HhEpk9ey7JOTGLBHXoS93syBcYqyg?= =?us-ascii?Q?feQLqPjvV1G+0tgtVdvuDD+xzEdi803Vul2Fdc2OtM6FkaYhkCxkFsDG/EuA?= =?us-ascii?Q?zu08csyHjCUYDMOk6n6W/p3p4V66Ki7dlVyRgS35O+sxSezixDT8UWyjdBci?= =?us-ascii?Q?x4Y28b6Odsve/3zooPCgmPfR5Wr3CRpPoS7u8vlbYy1m8mpsatEZeXTXb5WK?= =?us-ascii?Q?POuihJUNsxqsOzaz9/5vhSwuUOEJo3IazlgSSvEhhEteY2/HIeS+QaHUNxdH?= =?us-ascii?Q?PktCpVRjq/68/LTspy8VMCkDAo44mpPTnnPGovTggLAmrO+kHOMFgdYBqofb?= =?us-ascii?Q?AoPLpXu35WnqxMstl7S4Gi8SeGIpk1W8afu4qH1TZvDJnCWoolUOZYvf/C8d?= =?us-ascii?Q?y6CGkjVvFSTiPgFmfb95a6wVCzKKEj8QJQ3Mxq5g5ICnQjnaNpdfpkaLGSBH?= =?us-ascii?Q?LWHmWQtaCqEwlAV7vtDg04e8KZXP68R/lJnqWqPGbqzn8UG0ddYQd7VEftCr?= =?us-ascii?Q?rig0woJfSzSiS8OSQG1y/ytlbYYgK6yiL/Loi+zxzGxP8c2ned25PVF/4I65?= =?us-ascii?Q?9si1ERT7Gfc8GwDnM4Ys1+dNr46AJzNsm3ANlNgJ3TaR1BWftsG51LgGibtm?= =?us-ascii?Q?v9V9ABSmDasUaHrKSF9OqD5YbVvt5ESuovo7M30XWYmcl3TOENs2iFBfuJVY?= =?us-ascii?Q?Jrtn/b6+DEpaNjhv5SH6FWjWF+maybCC9JGaIJQeubCrRBhM8j5ge7EgjOnx?= =?us-ascii?Q?3SbdlnQmW8BA8EgYJFLxUp5iSb6lyuS1IwjieZdn6vK4EluZJ9QQ8m17EBT8?= =?us-ascii?Q?rXTsS+wNyOr0QGCJRusmFVJzLIqVSNwQioTaqqilozB4ebc9iUSYAkveEDgI?= =?us-ascii?Q?ijdj9oPSUcWcgr1MtFjjzFDyJ5iX8dH1Bz+zmJlHmRW8DlKXbxtx1QhQgu2M?= =?us-ascii?Q?67qoD9ksj3za1JRt1OxaCbsc9KXxYYjj2Pm4P/GC0lNZc0jZL1H1dPDmVwxt?= =?us-ascii?Q?jBdRmGGsiXwhTv/KqTrrpnWU1P+OZxeOjHUrvbIZkFtHlTy/NpugwT46HRgy?= =?us-ascii?Q?Hp+42mimT//mZfzZksaKa0eIrNW04xjotlfqmxUt1GnmraiJqp7JxtPtgXhC?= =?us-ascii?Q?f++A6C7Dm98I+nYrU+3cIm1rtx9zLTZSsXLQzyQFQTpEwUQf44/qM/x8At6G?= =?us-ascii?Q?2l5BUxyzcTFZaCMKueJ56i0/GPQ2MeTRQX/2XNT0I59RYyfbK/4G6bH+uZ2U?= =?us-ascii?Q?yJdARKVKwEFiXhmDd7+xislkYS/URRqTwvCGyKlniZMRA/2jXf0IqBP/5S5b?= =?us-ascii?Q?nUs2LoWJ+pAD2ocDcLnWjpvS8j6TkFaldKobe4S4CBOiZJ+LafoqNpTSoAVC?= =?us-ascii?Q?SSdpgY9vG0oQ9HU3ZBXrAgpuwWSOrBwtOSwHy4klrCFTdrAddTd7hq4A3c3X?= =?us-ascii?Q?IJ6OECfyCw7LJty8oZ4pyFg2t/BkLoExNthP3Kmz?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8434a7ea-cafc-4fc1-808d-08dc9a7ff65d X-MS-Exchange-CrossTenant-AuthSource: DS0PR12MB7726.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jul 2024 10:15:56.5970 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hOwAgKPW2j1aNgi53qf8yGgAGC90PpUfcqG5kgrx4dF4CdjYRKVvX0itPEuPVz2Eoy1mJqpoeM7LUeQJ2gEHTA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW6PR12MB9019 X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 8C2D140014 X-Stat-Signature: o7wncf3fczn34979sh88mhn9tz4rfsjt X-HE-Tag: 1719915360-423056 X-HE-Meta: U2FsdGVkX19hplMu3pp+z4utAj/e4zVbQOrHiAe0PfO5pD87YfXFuHNwnoMpk2BpQe8uhY8yYmWvx5TnDJyLh53rWb7/0hRCoXOrRCCt+1d6Ty3g/jSb8Ed3kBahEBrqc71yOqcnbiyUY/HE6vY2OKMicKe/+SthYargr/RPwFql62cEu7USeS7h0/R68Sl4RFTHASo9UmTrMIj+E6t2oPYEDsDxuEGCBaLdW6/b750pvR+zeyjk/4uIehEsOo1oZ8lq1ygroyfQTANbbY1yVNWNu+2kedm6H3kJgh+2IoPsRln1Qq0ywNmWLKYfO95t156Dl3BLrwVR51zayU9OO4jiykgpmusKqfyJZ9AIFnzYWt/D49mLx71P0NQgMqPDhB88S5a7J2nE5fqkgVBu0a+D9Amc+9Z2XJQrNG6KBME1THeb+s/JoU+SAzChuqvOW+D71A6mmvubkce/etkQnF+rnEfc1SAlmqU2OeSjXmU/TSGBb5a6XjD34NdhOiH98MuhtpamJuikIEHszdaHg8AdAsmfPhg9s2ZLQUAMUx8aLLQ4/ytfABrY25QIGFf2pMpy4dqkD5Q2nsxQMuBgmQ+QgKQazSCh4I6RuaBY24nnVaKuJPgP88xmSYrbxr1qe11PECJkj/KJJMSfNqwhOTSCeSxLgxkljRQLJeP+PyKqFbBAN6pTyTHdoNL+4O1FNlF3hzoPSE3Bh7NZ3zbsTXiOUBhG50dKHlFE/9t16GQIpKQk4ojOyQRKSAYQrtgpcB+ceDKmg+/Q9kCHaDZWTQrPrQYAv8p1ibqDZU0/8MX4D3MdqX2VffNuLBdnIjJBFrGDHwhuNUL7pvaGkCeDGqp3XOb65fCUMKItiaFcBM/BNhfhFQIJVzT1u5IIGT0FtDWrDeHmaK/ZPI2UlEze4Rru3KGsSnPvNh2/B9wuJ15OmSX6Jx/HT2KKm0+j7V0PCSpJvB0dHruALRdzZa4 XJcq82nz 0oFQSigDa94eBAQwhrUkmG7r2dBGD4a1LS6+xu6VEtYj+4WlmEzRn6dlxZn+KnLS28sRzwFz7Sk8aEPf3RCxO4sCjCqHy13PRiHCXU9uTi7XPqKkkdH37BzhW9lmyzKj/91sTtBZgtvo4aOauv2VEBWOlq51WXrvj+nnOKtRpZe+WNNePT1/RZCfWBGRMUoaYnf1J/3L78NdzFE2CdYX1HjiJtsKIa7i5TaKJWy8dlSE0ctS7eXx7W1FtiaH4EBTND1Fu X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Seems that way to me too, so feel free to add: Reviewed-by: Alistair Popple Christoph Hellwig writes: > vmf_insert_mixed_mkwrite is only used by the built-in DAX code. > > Signed-off-by: Christoph Hellwig > --- > mm/memory.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/mm/memory.c b/mm/memory.c > index 0f47a533014e43..feb55b1d0cd6b2 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -2487,7 +2487,6 @@ vm_fault_t vmf_insert_mixed_mkwrite(struct vm_area_struct *vma, > { > return __vm_insert_mixed(vma, addr, pfn, true); > } > -EXPORT_SYMBOL(vmf_insert_mixed_mkwrite); > > /* > * maps a range of physical memory into the requested pages. the old