linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Alistair Popple <apopple@nvidia.com>
To: Christoph Hellwig <hch@lst.de>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org
Subject: Re: [PATCH] mm: unexport vmf_insert_mixed_mkwrite
Date: Tue, 02 Jul 2024 20:13:28 +1000	[thread overview]
Message-ID: <878qykgkvc.fsf@nvdebian.thelocal> (raw)
In-Reply-To: <20240702072327.1640911-1-hch@lst.de>


Seems that way to me too, so feel free to add:

Reviewed-by: Alistair Popple <apopple@nvidia.com>

Christoph Hellwig <hch@lst.de> writes:

> vmf_insert_mixed_mkwrite is only used by the built-in DAX code.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  mm/memory.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/mm/memory.c b/mm/memory.c
> index 0f47a533014e43..feb55b1d0cd6b2 100644
> --- a/mm/memory.c
> +++ b/mm/memory.c
> @@ -2487,7 +2487,6 @@ vm_fault_t vmf_insert_mixed_mkwrite(struct vm_area_struct *vma,
>  {
>  	return __vm_insert_mixed(vma, addr, pfn, true);
>  }
> -EXPORT_SYMBOL(vmf_insert_mixed_mkwrite);
>  
>  /*
>   * maps a range of physical memory into the requested pages. the old



  reply	other threads:[~2024-07-02 10:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-02  7:23 Christoph Hellwig
2024-07-02 10:13 ` Alistair Popple [this message]
2024-07-02 13:10 ` David Hildenbrand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878qykgkvc.fsf@nvdebian.thelocal \
    --to=apopple@nvidia.com \
    --cc=akpm@linux-foundation.org \
    --cc=hch@lst.de \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox