From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE23AC3DA4A for ; Wed, 14 Aug 2024 10:30:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 845046B0082; Wed, 14 Aug 2024 06:30:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7F4E26B0083; Wed, 14 Aug 2024 06:30:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6BC6A6B0085; Wed, 14 Aug 2024 06:30:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 4D8796B0082 for ; Wed, 14 Aug 2024 06:30:16 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id F269AA0D86 for ; Wed, 14 Aug 2024 10:30:15 +0000 (UTC) X-FDA: 82450481190.19.87F9ADF Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by imf23.hostedemail.com (Postfix) with ESMTP id 51006140018 for ; Wed, 14 Aug 2024 10:30:13 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=YalDkqGi; dkim=pass header.d=linutronix.de header.s=2020e header.b=vO8MBuyx; spf=pass (imf23.hostedemail.com: domain of tglx@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=tglx@linutronix.de; dmarc=pass (policy=none) header.from=linutronix.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723631318; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kQJcLvdJXGirvTzHx/X5mQxJZfu1qd9LZj5pJq+trw4=; b=ZYXJb+y9u68FDqTLooHBQyguFOtAWkvefXe8znZ/WjPe7UqWlVEjKoDfPKT2bgmhbqOtzq 1rgyRJ7gcFjumx5i0wFB8/4tUADW5hBIdkIhr1dUF17oF/CTT25JiYNoIrWhL2nh9Z9ZL4 mD4pqTMat15He4qEJSp2r2GBKAxY/xc= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=YalDkqGi; dkim=pass header.d=linutronix.de header.s=2020e header.b=vO8MBuyx; spf=pass (imf23.hostedemail.com: domain of tglx@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=tglx@linutronix.de; dmarc=pass (policy=none) header.from=linutronix.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723631318; a=rsa-sha256; cv=none; b=Z/UWsFuMGZsuKczLYAtPNvsbUeVTCTojj+xMoZd55BvL7fpY4VsfU5Sq/EUCLKLaHArFE+ NY5Ac7G9nJKF1MZIUuYkQwSIlamxioxuV8z3y+q+JipQHqbjgQjI9V4BorCJpEBLrXUrR4 QDxCNR3L9aZABAMaGQAfTQAm/DJR1Pc= From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1723631410; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kQJcLvdJXGirvTzHx/X5mQxJZfu1qd9LZj5pJq+trw4=; b=YalDkqGid5cIIu7BfMSWEd4UsIKjyU2dhPdda3VcpO78xsLv//xQPjJbd6YpSiw1HwpdHQ +gdykHM6Rz/Dq8bov+c1YanMm9Du8ptDadZJD4C46ZTKj8SuA1TSuW+jhYBN8jiOmeiU8r TQBXqiIAIQ37BTft6sjf/EBnakPZge/Lg7MipnkjUIxN2zJUs6j1pSS2wrMuduYBZnnPiG G3K4ESwelOH7a6NaUVp1cuitsAwq7Q1j0y1NX/ZIn+KQySDLL34mA8zO3X94puJwb53BjO MAk7c1qFU4+6YmfvcwONhOigaqtlOBsa85QB023wy6eVTJY724wQkMncoH5G/Q== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1723631410; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kQJcLvdJXGirvTzHx/X5mQxJZfu1qd9LZj5pJq+trw4=; b=vO8MBuyx4LB7RymIQGNZ3fBiI0Svk1sljj0EXFjPr0CWwMObzBwqlWPKACIZSqxwk5xRT2 bobpqyFt9tVZZWAQ== To: Christoph Hellwig , Max Ramanouski Cc: x86@kernel.org, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, linux-kernel@vger.kernel.org, jniethe@nvidia.com, jhubbard@nvidia.com, linux-mm@kvack.org Subject: Re: [PATCH v2] x86/ioremap: Use is_ioremap_addr() in iounmap() In-Reply-To: References: <20240812203538.82548-1-max8rr8@gmail.com> Date: Wed, 14 Aug 2024 12:30:09 +0200 Message-ID: <878qwzpfbi.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 51006140018 X-Stat-Signature: 8pp9ctcgrin7dw5nuai1qw5m9d7okdpf X-Rspam-User: X-HE-Tag: 1723631413-461856 X-HE-Meta: U2FsdGVkX19R8pc2OJNiX//oEGHyIjvdl28dDKEzXID9H2u16nfoxoiYTGS8HXp5jWGHLjJA4WT+u5YT2UxsXQhaVb+lSGeLU9nhgDWpaDrKo9spcTqOrj1xf+mNb6FFF9p/xct9QVfNGTUFCDmikSTfQRi8DRFBb4jd42x1uiCigPB001JWknT4ibV24e3xPTNHhRqTeQcjNoZWmoWz1OWI7HF830Fe6IYZX/NRMKCxeIscrFnZW8z+JowLYYNulbrHriXHxEohhW6pO2KH/lqQXWDUwnpEflW2iwW48Zs8ZeDDNS5muApjNgOfNPpoOxb8VoFJoElesvsj3BTWQSkSlE2uUfcl1vMVHJwlC4aGnOUXLLnFWLhSYkjF2BJu6NwgRfF3HUZ45BHhel+54vzVAuEp/lDQp0+KafXTZEGKm99TLm/HFvWs2JD2dBtuP/5vc8rRgAk/FqeSr+p9/4JdaADvdx7gW8enNSR0nYCqFOzOqH+7grb75qOpm6gWNxeip53yqWB/JP6d6C6JMAgGyBkmukJPxW9G6tYM85D2fQo3fdXPnlw40WNbl21Ug/yb7dhyNp0FekSFc0w763KUI7k8DcnZwS5COffi5Ilazf3wMMit5HwUmzr5xijd6kkuuofvmZDtNbrOWwwbhiBAYSwlma+vmcTmal9//TA5EeFKuG57jHGewXXxUEKnb4P5vO1wtq35lGWuVhd0Q1c3QnGxRXgb/9ZqQ+D3ozSqNaPrbzmT+m00K66Vkopm4PNAcHuuhzY4PpuHRRKTxPdmgVeeRyCmSoiucp3gexC/MbYw9y/gxO5tba+Lt7C0rCOqB7op3JKMrNuPUHkjDd9i5qVqrU9nnv1GdwtaDlYmITbcjR1gWbOYWNgG32fzLcB5+Lwpypsxqy5+vjm95vqesW+iwC8eMAOoqwUK1EhtuCofhvK13EE8x0VfIeaAxAotKDfmQOscNzsiOoO P6GBdM4I 6tGEEzYv0Ba/AWmQacUmOnHCTqAaA/VhGXHJIsOEkqfoV6Y3W1oHTOzsuh5Rq5B33Yl3CLNhpI31gnWCzm5HGRMOUfNMMMXIMNNqbUXudzT1tg8hHEveBOOx8u4EYrGH+RC190QYC160lpNWZy+PsAjC+77Fd8C4LmI1p7iIPAWKsaxK66ofImHp/1Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Aug 13 2024 at 21:28, Christoph Hellwig wrote: > Modulo the fixes discussion (and any commit log adjustments related to > that), is_ioremap_addr is the right interface to check for an > ioremap address. So for the actual code change: I'm not opposed to use is_ioremap_addr() as it restricts the check to the actual ioremp region. That said, I'm wondering why iounmap() silently bails out when invoked with an address which is outside of the ioremap region. I'd say, any invocation with an address outside of it, is broken, but I might be missing something as always. Thanks, tglx