From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 072C6CEDDA3 for ; Wed, 9 Oct 2024 23:58:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 43F5C6B007B; Wed, 9 Oct 2024 19:58:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3EE526B0082; Wed, 9 Oct 2024 19:58:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2B5D36B0083; Wed, 9 Oct 2024 19:58:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 0E37A6B007B for ; Wed, 9 Oct 2024 19:58:43 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 002D0160305 for ; Wed, 9 Oct 2024 23:58:39 +0000 (UTC) X-FDA: 82655731284.24.FFF1A13 Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by imf15.hostedemail.com (Postfix) with ESMTP id F34DBA0002 for ; Wed, 9 Oct 2024 23:58:39 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=ellerman.id.au header.s=201909 header.b=l64N++3r; spf=pass (imf15.hostedemail.com: domain of mpe@ellerman.id.au designates 150.107.74.76 as permitted sender) smtp.mailfrom=mpe@ellerman.id.au; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728518251; a=rsa-sha256; cv=none; b=VY+ftNdfD2bzCLBWhwaGPULt58D8ICL8CdPrBbwwF/BTorWvkdO5kwKRuHkUraFsPzaq4U siBOutDnswXPnXyX7iDIlXAoGD2MEsByIHS4zRQE3KUnkK2nRGLBSMU+GDaS/chcreDcwS ISgOWuXOdzULShw80AXaRk7eOADVxtU= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=ellerman.id.au header.s=201909 header.b=l64N++3r; spf=pass (imf15.hostedemail.com: domain of mpe@ellerman.id.au designates 150.107.74.76 as permitted sender) smtp.mailfrom=mpe@ellerman.id.au; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728518251; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xGr+bL4hNtQoIXlcdCtPf1LScyxeLuXfkYkS492d+io=; b=nPHWvW/xuld9cdIRgyOR+9heNQM/q+p91L5Oo0LdpMKVCehfDxO9vdDfvZbypbfQFoAbtj 2LfcAx/OFAyD6r7rthzc+wZ/uw4H/Zvn7X6E6ADLF5vrf0P7UpVraP0lihKMCAvtav/yLZ VwesUVrjt+ssWZrWygLPPuPKiLBek1U= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1728518316; bh=xGr+bL4hNtQoIXlcdCtPf1LScyxeLuXfkYkS492d+io=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=l64N++3rtLStAQ6xt1IGJliIUx6KKR0K6hTsAnaEPELTVaDsqGX4mgFpl21+1eCqa t3uHSkTXDN/T1GQo4QlNiGhwkyHpy51QnTV7fQBwMvCwNAxNUXejuRkmIPh+27HZso 3NO8wHiHQ0MmfvqTvjyaf/IAEYtdeLWMWGcIc9EvsYNPW0/7YS41FhkykngoibHFbz wkTQeJ0lPZfoMI9gYDAs5Racj78K8BMPODTt+ct9LxFsBtcHWvNP2MQWwqr8+dRcCY 0MnLxLs5aKS6/AsOA8qkptKRaY9pC9VurMzcaCW2HgUh2dymfFxdsn4Vw/+hgw4RFw 0SiHFlVm8QfXQ== Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mail.ozlabs.org (Postfix) with ESMTPSA id 4XP8wl4n0mz4wxm; Thu, 10 Oct 2024 10:58:31 +1100 (AEDT) From: Michael Ellerman To: Thomas Gleixner , Vincenzo Frascino , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org Cc: Vincenzo Frascino , Andy Lutomirski , "Jason A . Donenfeld" , Christophe Leroy , Nicholas Piggin , Naveen N Rao , Ingo Molnar , Borislav Petkov , Dave Hansen , "H . Peter Anvin" , Theodore Ts'o , Arnd Bergmann , Andrew Morton , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers Subject: Re: [PATCH v3 2/2] vdso: Introduce vdso/page.h In-Reply-To: <87ttdlr3s5.ffs@tglx> References: <20241003152910.3287259-1-vincenzo.frascino@arm.com> <20241003152910.3287259-3-vincenzo.frascino@arm.com> <87wmihr49g.ffs@tglx> <87ttdlr3s5.ffs@tglx> Date: Thu, 10 Oct 2024 10:58:31 +1100 Message-ID: <878quw7rrs.fsf@mail.lhotse> MIME-Version: 1.0 Content-Type: text/plain X-Stat-Signature: st3qxkzezr4guo19q6981m8861h8ehkp X-Rspamd-Queue-Id: F34DBA0002 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1728518319-791978 X-HE-Meta: U2FsdGVkX18Moe5+/7UubjNWI3ZSLrZ9l7qW1aOaxndk0QRC261E5JfGl7y9O+R2nYYCrcUBJQqn2QbXi5OJlyjbXYfl0OzUTVSuZqM0M+iGDt1MQ4owqGcvXaB6NI6AtNAfBOXn8G4q9RaYHg8iFcOafZKBUgj3WQ+gha35GArxPoblkT+wD6Ve9yujU659dlBsyAbbglzi1IVOZZ2TRPq3U3uXRpTpmwTvz5kEjHvZKlZraDqZg9bHe2KEH9uDy45pRFt+DY0N58M+tI0k+obFYT0ZfErgADoftxO5GkbFOAztvpNJdH/lSnaXlb4OJKJbKDJpm++SKARuxueAlrMtuR26OCQHeMEKtvQv4LbrU5pBMAzwNdp/03YeY+c3xhywdDxC7e+PzconlkONuJ7GfARLzW9+lsFz69E6bbIQRmS0Z3YejD6VWYgqp3osvsdRBS/l8OhqgzurDdTpaa5r+4dHtFKo4EDIGSuCqtwNuDEWl7T9EA6bOz2Cz1sqtvgWcXU48zDTgnSy+tT0iw8wwAQkJEiV6eZhdq03t4QnpB1TR/G2sQL3PnQI5PZ375bqJ+pGLGc0nQpKrrPipWi4UeE5a7c0crIx5iLdLsr5J7t9/a7olK16Htrwy5KrS+voeUSbOkSToNQMO2I/jG5pOjyVPBLRj2Lobr6EHxKGKSfwV+YUG9aSRfM/Zbn4AZbCbAG5Y8pm87BbmOSKFh3m7AhtkiSn+REhBJF9fR2RIF84ed6sQAAVL9/t5nYNsg7TT3dcU6LYv1yOs4jUH4bfJSC3ClIMywb+B+1IYF5fZocA6qX65E0dLu5n1acPT0WUKP81KXZ3YHNayGeh8jat+/s8MMHsaIXWunbM0k/ZlobbRLwuKEkoUS3AI21aADUdB20k6dCrA7TNMVUe9vLS5DlF2Ieyu9cGvf6tnRqpp36srvz4wvq+tLRNuevzj7MWtixLXg3fVSWHBpc uB+c4UtQ ykhRCV0ck1g20RD3u8bHlKiNNYjBv+LIEKU0wnF4uRWT2NdLC7yNsx8N1jIGqT3To3vkgidvlKAF2GpDIgqeYVTNSMeTepwY/vrz9FNZp1LbLvfp4Gm/jOXZ+04Uz6mn4R9ZTlOr+RnGRqnqJQeGdQ55lhQrrejRxQHRJUM8GF+7tj/CvOH0G0ux0oQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Thomas Gleixner writes: > On Wed, Oct 09 2024 at 11:53, Thomas Gleixner wrote: >> On Thu, Oct 03 2024 at 16:29, Vincenzo Frascino wrote: > > Hit send too early. > >>> +#if defined(CONFIG_PHYS_ADDR_T_64BIT) >>> +#define PAGE_MASK (~((1 << CONFIG_PAGE_SHIFT) - 1)) > > This really wants a comment. The magic reliance on integer sign > expansion is any thing than obvious. +1 Vincenzo feel free to take/modify the one from arch/powerpc/include/asm/page.h :) cheers