From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C4EBD2E025 for ; Wed, 23 Oct 2024 08:45:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A96176B007B; Wed, 23 Oct 2024 04:45:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A20AA6B0082; Wed, 23 Oct 2024 04:45:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 899296B0083; Wed, 23 Oct 2024 04:45:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 674A46B007B for ; Wed, 23 Oct 2024 04:45:27 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 067021407CB for ; Wed, 23 Oct 2024 08:45:09 +0000 (UTC) X-FDA: 82704232170.09.B2F1D2B Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.14]) by imf10.hostedemail.com (Postfix) with ESMTP id AE2C2C0013 for ; Wed, 23 Oct 2024 08:45:16 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=OjPtHlDv; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf10.hostedemail.com: domain of jani.nikula@intel.com designates 192.198.163.14 as permitted sender) smtp.mailfrom=jani.nikula@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729672957; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Vkr9salNgVB+Yqvm0u7l4B5At2y5Ask+8v8QR8YSnWk=; b=gbYKqVFCwW44tFrWm5JQgOG1/4/Aro8TGEyDlBen4TSi/0HuybRziXCeqRbuQ1+TaMzMJN pg8SpQkWaaEe8/iPvGb/htqjvTwF1DwxHENJAzlkI40OiQzJ6P86f7KZbNsuJxu3Rqg32i 3Tm/BzvVA2w7SjK/w0J5dphKsDq3kkI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729672957; a=rsa-sha256; cv=none; b=gu6JdbMTxOZeTHdPqAXN+B8OLvZ+vofEHroUAC6C7/72YFWWXroWZMaGaovnfiY3T2X76S 8d8uRfmjpWr4dlpe5BN5xHjpKBfF1dUvfFK8+JW8kD9CwNdHN9z3cW6BSJC52uUTsgstq5 IjZi/Fe9jkf7IMg5/5nrspbsRomejS4= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=OjPtHlDv; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf10.hostedemail.com: domain of jani.nikula@intel.com designates 192.198.163.14 as permitted sender) smtp.mailfrom=jani.nikula@intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1729673124; x=1761209124; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=A5ndovx0/E0It2utNkxkAGR1H8VRnlib7bnSfF4/6Vk=; b=OjPtHlDvsnsRD6sVuOAPmGwlNE6WKosmuS3qkhWJj3ZpETa8OPgkcMEo 9uSh/iKOXXIga4/hYP0/f0GAqcl82Kr1flUPyDQltrJ1MqJHlVYHXzSZQ uotVYccgsnCavRXGdDYIQkx640YKXDXpdDZlnCo5aciHP3PFYstOyAxdx eSo3V2UFWj6XxboL/VdfRR6TGEsgqqiL77FJ7RyrSwk+U8C1ecbQrXSZB dUn+24zMh/UYa6DlEf3PPdbmk6tfPnqwglH5T6Nb/RgC5SBoScBjXh/YY mcg6zXNzkuaN/NsfAK6Pj5rarGgz+BsiZw1inLgrYbDANed83ywze3Rps w==; X-CSE-ConnectionGUID: Edkn+9+JQ6+ozqHW7GN9PA== X-CSE-MsgGUID: pGZGnUmNSKCHOzZ2WhuPyg== X-IronPort-AV: E=McAfee;i="6700,10204,11233"; a="29472832" X-IronPort-AV: E=Sophos;i="6.11,225,1725346800"; d="scan'208";a="29472832" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Oct 2024 01:45:22 -0700 X-CSE-ConnectionGUID: ax+KPFUmQt+be2JCEmOxDA== X-CSE-MsgGUID: Ot6elf/iQsK9c2xwI0Y3/g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,225,1725346800"; d="scan'208";a="84759588" Received: from kniemiec-mobl1.ger.corp.intel.com (HELO localhost) ([10.245.246.84]) by fmviesa004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Oct 2024 01:45:18 -0700 From: Jani Nikula To: Maarten Lankhorst , intel-xe@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Tejun Heo , Zefan Li , Johannes Weiner , Andrew Morton Cc: Friedrich Vock , cgroups@vger.kernel.org, linux-mm@kvack.org, Maxime Ripard , Maarten Lankhorst Subject: Re: [PATCH 2/7] drm/drv: Add drmm cgroup registration for dev cgroups. In-Reply-To: <20241023075302.27194-3-maarten.lankhorst@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20241023075302.27194-1-maarten.lankhorst@linux.intel.com> <20241023075302.27194-3-maarten.lankhorst@linux.intel.com> Date: Wed, 23 Oct 2024 11:45:15 +0300 Message-ID: <878qufus10.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: AE2C2C0013 X-Stat-Signature: u3iuje5dm18fbinfs1g4tucyf8huiksg X-Rspam-User: X-HE-Tag: 1729673116-743415 X-HE-Meta: U2FsdGVkX18fXfY59GKfhYgVlDoJ6THhlCVJwoXPiPyd1/MMpUdWeSZLFUXh0QGfrsNPiamXnoX7N/xd4CX7th13d4ur5fLaoJkWw8ivxu4Uoj0jtfHvdchHpTt8ipUK43PosZ65xLBDGUjTxofKOOS4ouiHyuTbJxq/6vMX1QwR87CjxCYIJQd4KEEUFnlP9mSJg7Wq3KDIgN5BzLx2iLQKh61xx5vPPdRD0I1hpbV73hXTvs+FdnGUVjYHFFJKjOpqAK587DkNOCh380LU/iOGyoG038O8TYM+zIhicRq+tZT/JgORuKjKAba8l8gjaOjCRbbOoXPD8u5o/stbfF/xapH/fEB1lsKUznWBsWIIdi/vs3jcz9WmDVF9OGOujVr2KNqK0rtWgzceJA35/Op93ZuM72uoPrruAebmJVS7ZZr2N/MHeUn8ShsrpBw0vgh7a5hfybudwiiJU3sFwuIM0N6E/EgOuRkcHU/OJ92YrBEWZhV0qD9tqNsFo1793+m5z0wF5KHPaZUB588+2fqQVigji0BsF6fl5lKxNGzAcartyjcNck/Fvt9nv5yc8jngE4jxdXPzY8ZWS7uOi+5qBKrAJXyTZJnmrH52zII4YaNoBMlpY5ASMKcTbyGzDBoHLMr8YH3I8xpiVFKKIvXJ2GRWUGo4tGuCKkS9hx6inwZ8gL7Ir75xlDV58bWeOVZDbzvgZlsofyV7CxVsruFA7pr8XnDD5zjGy16tmn6nBLOTiSMLuPjRy8MZKZF1mzaoyPwcN7zTvSI1wwSs62dVoYAoF3GOwHsXd2yRQb5+L0zlHmqc2rmSUcMyVwpjKZU+2Uj0wazOJzq8oPHoTEaKvZhFU5iMuBEMAvTa+G1q1IkQe3sm9Yc2v06jEBjfg40/naoT2Y5/7F+5IRmAsUxxdQwNosv0hcNY6wwe8Iqg142Zos9dPQEY+WsiQaCKysK897HBSZryFG3NWIY NMVKsL+v 8xegsNUi33aAeQRbbmoYHexuG25ohmoHpSvKYBa2/AtpoyNKz0HzyJ/CBV1IkenqBesJAo0YIQSbIr1/VxWLkYCreD7edihlPTZY0AQq6/CaR/6PPEaE82x7jMjVzBvVvaZjYpiLuOEfTAuYXBXqG4WFzbIiib1vhF4ugdPandL5WKqWtpU5EPBds+B52vG4N3tMxuEbDVX6mTcu3MlzjgDsMKaX3VrniUiSwOG1ELeY3eWjItqrcoYVbS9lVAfrpz9CXHNISg/MKr83dhqWIy01MmtjkHiD7JG+n0DUOE0Gb2GsUcQRyUEy2flu05RO5chYO7pRXKV4OrLtQwTtsbaehE6cxqn+JFrCu52mvBXH6I5pSy44Tl6jcWBTQrHw38YM2wN6mImHFQFpkwfYu0YTACA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 23 Oct 2024, Maarten Lankhorst wrote: > From: Maxime Ripard > > Drivers will need to register a cgroup device at probe time, so let's > give them a drm-managed helper. > > Signed-off-by: Maxime Ripard > Signed-off-by: Maarten Lankhorst > --- > drivers/gpu/drm/drm_drv.c | 21 +++++++++++++++++++++ > include/drm/drm_drv.h | 4 ++++ > 2 files changed, 25 insertions(+) > > diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c > index c2c172eb25df7..251d1d69b09c5 100644 > --- a/drivers/gpu/drm/drm_drv.c > +++ b/drivers/gpu/drm/drm_drv.c > @@ -26,6 +26,7 @@ > * DEALINGS IN THE SOFTWARE. > */ > > +#include > #include > #include > #include > @@ -820,6 +821,26 @@ void drm_dev_put(struct drm_device *dev) > } > EXPORT_SYMBOL(drm_dev_put); > > +static inline void drmm_cg_unregister_device(struct drm_device *dev, void *arg) Nitpick, inline in .c files is mostly useless, just use static and let the compiler do its job. BR, Jani. > +{ > + dev_cgroup_unregister_device(arg); > +} > + > +int drmm_cgroup_register_device(struct drm_device *dev, > + struct dev_cgroup_device *cgdev) > +{ > + int ret; > + char dev_name[32]; > + > + snprintf(dev_name, sizeof(dev_name), "drm/%s", dev->unique); > + ret = dev_cgroup_register_device(cgdev, dev_name); > + if (ret) > + return ret; > + > + return drmm_add_action_or_reset(dev, drmm_cg_unregister_device, cgdev); > +} > +EXPORT_SYMBOL_GPL(drmm_cgroup_register_device); > + > static int create_compat_control_link(struct drm_device *dev) > { > struct drm_minor *minor; > diff --git a/include/drm/drm_drv.h b/include/drm/drm_drv.h > index 1bbbcb8e2d231..3e83c7ce7f2d0 100644 > --- a/include/drm/drm_drv.h > +++ b/include/drm/drm_drv.h > @@ -34,6 +34,7 @@ > > #include > > +struct dev_cgroup_device; > struct drm_fb_helper; > struct drm_fb_helper_surface_size; > struct drm_file; > @@ -438,6 +439,9 @@ void *__devm_drm_dev_alloc(struct device *parent, > const struct drm_driver *driver, > size_t size, size_t offset); > > +int drmm_cgroup_register_device(struct drm_device *dev, > + struct dev_cgroup_device *cgdev); > + > /** > * devm_drm_dev_alloc - Resource managed allocation of a &drm_device instance > * @parent: Parent device object -- Jani Nikula, Intel