Re: [RFC][patch 2/5] mm: Node-setup agnostic free_bootmem()

[Johannes Weiner <hannes@saeurebad.de>]

Hi,

Ingo Molnar <mingo@elte.hu> writes:

> * Yinghai Lu <yhlu.kernel@gmail.com> wrote:
>
>> >  Yes, it should work well with cross nodes case.
>> >
>> >  but please add boundary check on free_bootmem_node too.
>> 
>> also please note: it will have problem span nodes box.
>> 
>> for example: node 0: 0-2g, 4-6g, node1: 2-4g, 6-8g. and if ramdisk sit 
>> creoss 2G boundary. you will only free the range before 2g.
>
> yes. Such systems _will_ become more common - so the "this is rare" 
> arguments are incorrect. bootmem has to be robust enough to deal with 
> it.

Ingo, I never doubted any of this, I was just asking more than once if
and when this might happen.  And I don't want the allocator become
fragile, just not completely ignorant about bogus input.

But the situation is still not clear for me.  Ingo, how are these
node spanning pfn ranges represented in the kernel?  How many node
descriptors will you have in the case Yinghai described and how will
they look like?

	Hannes

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>