From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@redhat.com>,
linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@suse.cz>,
kbuild test robot <fengguang.wu@intel.com>
Subject: Re: [memcg:since-3.6 493/499] include/trace/events/filemap.h:14:1: sparse: incompatible types for operation (<)
Date: Sat, 08 Dec 2012 19:47:03 +0100 [thread overview]
Message-ID: <877gosz8ig.fsf@free.fr> (raw)
In-Reply-To: <1354932053.17101.113.camel@gandalf.local.home> (Steven Rostedt's message of "Fri, 07 Dec 2012 21:00:53 -0500")
Steven Rostedt <rostedt@goodmis.org> writes:
> Sorry for the late reply, It's end of year and I'm getting a lot of
> pressure at work to get things done.
Don't worry, no hurry in here.
> Hmm, this is mostly automated via the macros. Not sure how we can
> differentiate a pointer from other fields. Would this be fixed if we
> did:
>
> #define is_signed_type(type) (((type)(-1) < (type)0)
Yes indeed, this quiesces the sparse warning, and keeps the original purpose
AFAIK. And I don't think C standard provides a way to typecheck for any kind of
pointer, so this looks the right fix to me .
Will you submit the patch or do you want me to send it ?
Cheers.
--
Robert
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2012-12-08 18:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-29 23:46 kbuild test robot
2012-12-02 14:36 ` Robert Jarzmik
2012-12-08 2:00 ` Steven Rostedt
2012-12-08 18:47 ` Robert Jarzmik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877gosz8ig.fsf@free.fr \
--to=robert.jarzmik@free.fr \
--cc=akpm@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=fweisbec@gmail.com \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox