From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47249C433B4 for ; Wed, 21 Apr 2021 00:53:20 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9609660C3E for ; Wed, 21 Apr 2021 00:53:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9609660C3E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 86FAF6B006C; Tue, 20 Apr 2021 20:53:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7F9646B006E; Tue, 20 Apr 2021 20:53:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 64C606B0070; Tue, 20 Apr 2021 20:53:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0193.hostedemail.com [216.40.44.193]) by kanga.kvack.org (Postfix) with ESMTP id 459BF6B006C for ; Tue, 20 Apr 2021 20:53:18 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id EC8F52466 for ; Wed, 21 Apr 2021 00:53:17 +0000 (UTC) X-FDA: 78054550434.01.20BD497 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by imf17.hostedemail.com (Postfix) with ESMTP id 0417840002CF for ; Wed, 21 Apr 2021 00:53:13 +0000 (UTC) IronPort-SDR: tp3TZMEpsTb/T2OzNrZpYm6qEjkpUQNdp1agBHMaev67OQ4l1pfxkltRESOrX7LwIOQ2D/9PR0 B2Dvf/0F2aOw== X-IronPort-AV: E=McAfee;i="6200,9189,9960"; a="182751052" X-IronPort-AV: E=Sophos;i="5.82,238,1613462400"; d="scan'208";a="182751052" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Apr 2021 17:53:14 -0700 IronPort-SDR: vuoAgGJOiKXukaQlTtzHZ/Q2gJBD+wF/P20v3xuSrVlwliklefdMHTmVRnVc3ngGoW1ZCNX1q2 ziLMTfIpybJA== X-IronPort-AV: E=Sophos;i="5.82,238,1613462400"; d="scan'208";a="427311101" Received: from yhuang6-desk1.sh.intel.com (HELO yhuang6-desk1.ccr.corp.intel.com) ([10.239.13.1]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Apr 2021 17:52:45 -0700 From: "Huang, Ying" To: Miaohe Lin Cc: , , , , , , , , , , , , , Subject: Re: [PATCH v3 2/4] swap: fix do_swap_page() race with swapoff References: <20210420133048.6773-1-linmiaohe@huawei.com> <20210420133048.6773-3-linmiaohe@huawei.com> Date: Wed, 21 Apr 2021 08:52:43 +0800 In-Reply-To: <20210420133048.6773-3-linmiaohe@huawei.com> (Miaohe Lin's message of "Tue, 20 Apr 2021 09:30:46 -0400") Message-ID: <877dkw31d0.fsf@yhuang6-desk1.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 0417840002CF X-Stat-Signature: b3nnidkddjm71z9z3kd9x1557c6nos6j Received-SPF: none (intel.com>: No applicable sender policy available) receiver=imf17; identity=mailfrom; envelope-from=""; helo=mga02.intel.com; client-ip=134.134.136.20 X-HE-DKIM-Result: none/none X-HE-Tag: 1618966393-442266 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Miaohe Lin writes: > When I was investigating the swap code, I found the below possible race > window: > > CPU 1 CPU 2 > ----- ----- > do_swap_page > if (data_race(si->flags & SWP_SYNCHRONOUS_IO) > swap_readpage > if (data_race(sis->flags & SWP_FS_OPS)) { > swapoff > p->flags &= ~SWP_VALID; > .. > synchronize_rcu(); > .. You have deleted SWP_VALID and RCU solution in 1/4, so please revise this. > p->swap_file = NULL; > struct file *swap_file = sis->swap_file; > struct address_space *mapping = swap_file->f_mapping;[oops!] > > Note that for the pages that are swapped in through swap cache, this isn't > an issue. Because the page is locked, and the swap entry will be marked > with SWAP_HAS_CACHE, so swapoff() can not proceed until the page has been > unlocked. > > Using current get/put_swap_device() to guard against concurrent swapoff for > swap_readpage() looks terrible because swap_readpage() may take really long > time. And this race may not be really pernicious because swapoff is usually > done when system shutdown only. To reduce the performance overhead on the > hot-path as much as possible, it appears we can use the percpu_ref to close > this race window(as suggested by Huang, Ying). This needs to be revised too. Unless you squash 1/4 and 2/4. > Fixes: 0bcac06f27d7 ("mm,swap: skip swapcache for swapin of synchronous device") > Reported-by: kernel test robot (auto build test ERROR) > Signed-off-by: Miaohe Lin > --- > include/linux/swap.h | 9 +++++++++ > mm/memory.c | 9 +++++++++ > 2 files changed, 18 insertions(+) > > diff --git a/include/linux/swap.h b/include/linux/swap.h > index c9e7fea10b83..46d51d058d05 100644 > --- a/include/linux/swap.h > +++ b/include/linux/swap.h > @@ -527,6 +527,15 @@ static inline struct swap_info_struct *swp_swap_info(swp_entry_t entry) > return NULL; > } > > +static inline struct swap_info_struct *get_swap_device(swp_entry_t entry) > +{ > + return NULL; > +} > + > +static inline void put_swap_device(struct swap_info_struct *si) > +{ > +} > + > #define swap_address_space(entry) (NULL) > #define get_nr_swap_pages() 0L > #define total_swap_pages 0L > diff --git a/mm/memory.c b/mm/memory.c > index 27014c3bde9f..7a2fe12cf641 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -3311,6 +3311,7 @@ vm_fault_t do_swap_page(struct vm_fault *vmf) > { > struct vm_area_struct *vma = vmf->vma; > struct page *page = NULL, *swapcache; > + struct swap_info_struct *si = NULL; > swp_entry_t entry; > pte_t pte; > int locked; > @@ -3338,6 +3339,10 @@ vm_fault_t do_swap_page(struct vm_fault *vmf) > goto out; > } > > + /* Prevent swapoff from happening to us. */ > + si = get_swap_device(entry); There's struct swap_info_struct *si = swp_swap_info(entry); in do_swap_page(), you can remove that. Best Regards, Huang, Ying > + if (unlikely(!si)) > + goto out; > > delayacct_set_flag(current, DELAYACCT_PF_SWAPIN); > page = lookup_swap_cache(entry, vma, vmf->address); > @@ -3514,6 +3519,8 @@ vm_fault_t do_swap_page(struct vm_fault *vmf) > unlock: > pte_unmap_unlock(vmf->pte, vmf->ptl); > out: > + if (si) > + put_swap_device(si); > return ret; > out_nomap: > pte_unmap_unlock(vmf->pte, vmf->ptl); > @@ -3525,6 +3532,8 @@ vm_fault_t do_swap_page(struct vm_fault *vmf) > unlock_page(swapcache); > put_page(swapcache); > } > + if (si) > + put_swap_device(si); > return ret; > }