From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 613D5C433F5 for ; Mon, 7 Mar 2022 02:03:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 802B08D0002; Sun, 6 Mar 2022 21:03:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7B16D8D0001; Sun, 6 Mar 2022 21:03:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 679A58D0002; Sun, 6 Mar 2022 21:03:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.a.hostedemail.com [64.99.140.24]) by kanga.kvack.org (Postfix) with ESMTP id 5813C8D0001 for ; Sun, 6 Mar 2022 21:03:23 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 2977C61707 for ; Mon, 7 Mar 2022 02:03:23 +0000 (UTC) X-FDA: 79215943086.11.BE589FF Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by imf31.hostedemail.com (Postfix) with ESMTP id 7DF2520007 for ; Mon, 7 Mar 2022 02:03:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1646618602; x=1678154602; h=from:to:cc:subject:references:date:in-reply-to: message-id:mime-version; bh=gqHtffotMITavlLD4voRnfx+PSyUPRZrq9IzbMQ+N1U=; b=SEcajdNwcWrFICwYJmRULoFSCgr+t9cCdytrM4CSR0V8aCNdlb2fAOIr CZ0+2aWI12zsl1T90g9nMhs5/6zeuCPfdpQVAQ6D1GuP+IHdPi278HDHo XfHem9iX1kOLfziWeUw6kFQil5BhxmIqUtJWMpYnYK6aQnXevsbDE0hH4 oaLSZ856gUBEmqn2fw0wDQRE3gVILB6xaAMyJWIBSqFrpffpuzs+0Ea65 ipWXUqPurJOf/HHHBR+yvQWgqucnok8iBUY9Whu+MV+4cEk3nEFHZpmYp q+UWG36r3r1dtofwJWvD5Z7VhOWn1Le+sxzyXWlUCsYFpO97VyyshoHwW A==; X-IronPort-AV: E=McAfee;i="6200,9189,10278"; a="251855080" X-IronPort-AV: E=Sophos;i="5.90,160,1643702400"; d="scan'208";a="251855080" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Mar 2022 18:03:17 -0800 X-IronPort-AV: E=Sophos;i="5.90,160,1643702400"; d="scan'208";a="643066097" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.239.13.94]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Mar 2022 18:03:12 -0800 From: "Huang, Ying" To: Miaohe Lin Cc: , , , , , , , , , , , , , , , , , Subject: Re: [PATCH 02/16] mm/migration: remove unneeded out label References: <20220304093409.25829-1-linmiaohe@huawei.com> <20220304093409.25829-3-linmiaohe@huawei.com> Date: Mon, 07 Mar 2022 10:03:09 +0800 In-Reply-To: <20220304093409.25829-3-linmiaohe@huawei.com> (Miaohe Lin's message of "Fri, 4 Mar 2022 17:33:55 +0800") Message-ID: <877d967c4i.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 7DF2520007 X-Stat-Signature: qzufgfey4j1186dcrpd9onezx9g715qm Authentication-Results: imf31.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=SEcajdNw; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf31.hostedemail.com: domain of ying.huang@intel.com has no SPF policy when checking 192.55.52.93) smtp.mailfrom=ying.huang@intel.com X-HE-Tag: 1646618602-495847 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Miaohe Lin writes: > We can do prep_transhuge_page when newpage is not NULL. Thus we can remove > out label to simplify the code. > > Signed-off-by: Miaohe Lin > --- > mm/migrate.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/mm/migrate.c b/mm/migrate.c > index 50bc62d85eaf..bc1867a5706c 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -2025,12 +2025,9 @@ static struct page *alloc_misplaced_dst_page_thp(struct page *page, > > newpage = alloc_pages_node(nid, (GFP_TRANSHUGE_LIGHT | __GFP_THISNODE), > HPAGE_PMD_ORDER); > - if (!newpage) > - goto out; > + if (newpage) > + prep_transhuge_page(newpage); > > - prep_transhuge_page(newpage); > - > -out: > return newpage; > } I don't think this change is necessary. The original code is simple and follows the common practice for error processing. The new code is OK, but it's unnecessary to change. Best Regards, Huang, Ying