From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9639C433F5 for ; Wed, 9 Mar 2022 16:29:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6230E8D0002; Wed, 9 Mar 2022 11:29:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5D3E58D0001; Wed, 9 Mar 2022 11:29:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 44DE68D0002; Wed, 9 Mar 2022 11:29:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.a.hostedemail.com [64.99.140.24]) by kanga.kvack.org (Postfix) with ESMTP id 355B48D0001 for ; Wed, 9 Mar 2022 11:29:29 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id ECDED613D5 for ; Wed, 9 Mar 2022 16:29:28 +0000 (UTC) X-FDA: 79225383258.07.E3C10BB Received: from out03.mta.xmission.com (out03.mta.xmission.com [166.70.13.233]) by imf19.hostedemail.com (Postfix) with ESMTP id 539391A0010 for ; Wed, 9 Mar 2022 16:29:28 +0000 (UTC) Received: from in02.mta.xmission.com ([166.70.13.52]:35982) by out03.mta.xmission.com with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1nRzBm-0032OW-NN; Wed, 09 Mar 2022 09:29:26 -0700 Received: from ip68-227-174-4.om.om.cox.net ([68.227.174.4]:34582 helo=email.froward.int.ebiederm.org.xmission.com) by in02.mta.xmission.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1nRzBl-005i1Z-OH; Wed, 09 Mar 2022 09:29:26 -0700 From: "Eric W. Biederman" To: Kees Cook Cc: Matthew Wilcox , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Alexander Viro , Denys Vlasenko , Vlastimil Babka , "Liam R . Howlett" , Jann Horn , linux-mm@kvack.org References: <20220131153740.2396974-1-willy@infradead.org> <871r0nriy4.fsf@email.froward.int.ebiederm.org> <877dafq3bw.fsf@email.froward.int.ebiederm.org> <87bkzroica.fsf_-_@email.froward.int.ebiederm.org> <87h788fdaw.fsf_-_@email.froward.int.ebiederm.org> <202203081342.1924AD9@keescook> Date: Wed, 09 Mar 2022 10:29:10 -0600 In-Reply-To: <202203081342.1924AD9@keescook> (Kees Cook's message of "Tue, 8 Mar 2022 13:49:32 -0800") Message-ID: <877d93dr8p.fsf@email.froward.int.ebiederm.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-XM-SPF: eid=1nRzBl-005i1Z-OH;;;mid=<877d93dr8p.fsf@email.froward.int.ebiederm.org>;;;hst=in02.mta.xmission.com;;;ip=68.227.174.4;;;frm=ebiederm@xmission.com;;;spf=neutral X-XM-AID: U2FsdGVkX1+n6dmJ5h9NeMXTcHx08GyxJ8itHy6uo48= X-SA-Exim-Connect-IP: 68.227.174.4 X-SA-Exim-Mail-From: ebiederm@xmission.com Subject: Re: [GIT PULL] Fix fill_files_note X-SA-Exim-Version: 4.2.1 (built Sat, 08 Feb 2020 21:53:50 +0000) X-SA-Exim-Scanned: Yes (on in02.mta.xmission.com) X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 539391A0010 X-Stat-Signature: 4uptw91f1c6yjy1eke1cyz9cpmritqau Authentication-Results: imf19.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=xmission.com; spf=pass (imf19.hostedemail.com: domain of ebiederm@xmission.com designates 166.70.13.233 as permitted sender) smtp.mailfrom=ebiederm@xmission.com X-HE-Tag: 1646843368-941126 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Kees Cook writes: > On Tue, Mar 08, 2022 at 01:35:03PM -0600, Eric W. Biederman wrote: >> >> Kees, >> >> Please pull the coredump-vma-snapshot-fix branch from the git tree: >> >> git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace.git coredump-vma-snapshot-fix >> >> HEAD: 390031c942116d4733310f0684beb8db19885fe6 coredump: Use the vma snapshot in fill_files_note >> >> Matthew Wilcox has reported that a missing mmap_lock in file_files_note, >> which could cause trouble. >> >> Refactor the code and clean it up so that the vma snapshot makes >> it to fill_files_note, and then use the vma snapshot in fill_files_note. >> >> Eric W. Biederman (5): >> coredump: Move definition of struct coredump_params into coredump.h >> coredump: Snapshot the vmas in do_coredump >> coredump: Remove the WARN_ON in dump_vma_snapshot >> coredump/elf: Pass coredump_params into fill_note_info >> coredump: Use the vma snapshot in fill_files_note >> >> fs/binfmt_elf.c | 66 ++++++++++++++++++++++-------------------------- >> fs/binfmt_elf_fdpic.c | 18 +++++-------- >> fs/binfmt_flat.c | 1 + >> fs/coredump.c | 59 ++++++++++++++++++++++++++++--------------- >> include/linux/binfmts.h | 13 +--------- >> include/linux/coredump.h | 20 ++++++++++++--- >> 6 files changed, 93 insertions(+), 84 deletions(-) >> >> --- >> >> Kees I realized I needed to rebase this on Jann Horn's commit >> 84158b7f6a06 ("coredump: Also dump first pages of non-executable ELF >> libraries"). Unfortunately before I got that done I got distracted and >> these changes have been sitting in limbo for most of the development >> cycle. Since you are running a tree that is including changes like this >> including Jann's can you please pull these changes into your tree. > > Sure! Can you make a signed tag for this pull? Not yet. Hopefully I will get the time to set that up soon, but I am not at all setup to do signed tags at this point. > If it helps, my workflow look like this, though I assume there might be > better ways. (tl;dr: "git tag -s TAG BRANCH") > > > PULL_BRANCH=name-of-branch > BASE=sha-of-base > FOR=someone > TOPIC=topic-name > > TAG="for-$FOR/$TOPIC" > SIGNED=~/.pull-request-signed-"$TAG" > echo "$TOPIC update" > "$SIGNED" > git request-pull "$BASE" git://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git "$PULL_BRANCH" | awk '{print "# " $0}' >> "$SIGNED" > vi "$SIGNED" > > git tag -sF "$SIGNED" "$TAG" "$PULL_BRANCH" > git push origin "$PULL_BRANCH" > git push origin +"$TAG" Thanks. That looks like a good place to start. Eric