From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5D7FC54EBE for ; Fri, 13 Jan 2023 05:41:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 32DAB8E0002; Fri, 13 Jan 2023 00:41:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2DE298E0001; Fri, 13 Jan 2023 00:41:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1CCC18E0002; Fri, 13 Jan 2023 00:41:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 0E7408E0001 for ; Fri, 13 Jan 2023 00:41:01 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 8812AA0487 for ; Fri, 13 Jan 2023 05:41:00 +0000 (UTC) X-FDA: 80348677080.07.6A79E21 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by imf29.hostedemail.com (Postfix) with ESMTP id 27783120008 for ; Fri, 13 Jan 2023 05:40:57 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=MAcLwP0Y; spf=pass (imf29.hostedemail.com: domain of ying.huang@intel.com designates 192.55.52.115 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673588458; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bMVCYVMyt84k3lnyIll8s8yNSUPKkVgE0pKRSApzrqM=; b=30QczQ/OhPU4B105Os7GGNBmKfi9eKSNdyc+/rBgmWbncV4SULrClYoujSOQf0NFKTH1Ue 43hR/bKSdC1KsJPLMp4v5orY8Gpqu69mSV3RiNClinYBCK4HLo8kJciAjcAPYsh5YZev+a 3gVi0Lp63iUxBX8hqTjxMJxV/vjPd6w= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=MAcLwP0Y; spf=pass (imf29.hostedemail.com: domain of ying.huang@intel.com designates 192.55.52.115 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673588458; a=rsa-sha256; cv=none; b=Ym6dfBiSDZyeyQE0v17fQBaLwCr3sGHxf5p0ZAXO7wd0gHIidwcEGDPflLNfcFMb3Mjlti qI4XFEU9jBvDGbi3i1osxH/RE3GjxOHrJys8HAQTFZHagc1Z8CppytMcXa9QP7zuFCXGST JZKY+CAAxsdn8kjHDl8y2hQWx9hdmFs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673588458; x=1705124458; h=from:to:cc:subject:references:date:in-reply-to: message-id:mime-version; bh=vrAvHnOnXccx7yFGQ8ydXsgitzXgUkHpBIX5UAmmqEo=; b=MAcLwP0Yy8HTENiFfXXfrnfdOsUjMjsB4aG+JUOVdMxWDWfFB2J5hK46 RMJNTeAme0cMnolNzwgWL3hI/d9sSau9ZOKQz7gvhIhIt8poVRBOhymdB a3qzQsQDv+46I6EJwx7yYUATn0ykglDrcI0BXSVRf+uQDPQSkWoNvdZPb AKAFXLwqu0kcT4rKv6jkauHu90KlCIwg4T8vqDgfbVFSdyDHojkd9Be3A kOe8l5J+sW2djZJ+9ovVB1e2njG0LrNDiO7xrKtO7ikpAGF4LtLXta/Zg 5qqo1EWM71NSPuTZ7liHcW4ygNeiFcLwi67Q6ealPOlDDaTkzovt5VonT w==; X-IronPort-AV: E=McAfee;i="6500,9779,10588"; a="323979209" X-IronPort-AV: E=Sophos;i="5.97,213,1669104000"; d="scan'208";a="323979209" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jan 2023 21:40:45 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10588"; a="688627342" X-IronPort-AV: E=Sophos;i="5.97,213,1669104000"; d="scan'208";a="688627342" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jan 2023 21:40:42 -0800 From: "Huang, Ying" To: Mike Kravetz Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Zi Yan , Yang Shi , Baolin Wang , Oscar Salvador , Matthew Wilcox , Bharata B Rao , Alistair Popple , haoxin Subject: Re: [PATCH -v2 0/9] migrate_pages(): batch TLB flushing References: <20230110075327.590514-1-ying.huang@intel.com> <87a62oy5o9.fsf@yhuang6-desk2.ccr.corp.intel.com> <87ilhcrzkr.fsf@yhuang6-desk2.ccr.corp.intel.com> <87bkn3rw8v.fsf@yhuang6-desk2.ccr.corp.intel.com> Date: Fri, 13 Jan 2023 13:39:39 +0800 In-Reply-To: (Mike Kravetz's message of "Thu, 12 Jan 2023 20:49:19 -0800") Message-ID: <877cxrro10.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Rspamd-Queue-Id: 27783120008 X-Stat-Signature: eg93n53c79by63e4jayejkig4bhbgddy X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1673588457-33483 X-HE-Meta: U2FsdGVkX1+tI17anGAFlPtE/2m6PBVdUlJsqQb8T3S3eOCMS4UfO/pU+ehIkYEQTyTCwf2qN/2p5SfCx5LeN2R45QufWic/4SU0Ppg5Qd4vhHqo5U3UPrgW27HZrSDABjBFEUHd/WT7Ff8hWFeami1JQDjxRxRkSNaAoSg5XsB1E09nbWhMYDzqr3hiUHQCYl34cGPJeTaoRvFHvZ5UsHUo2+VSCkaZd1/eJFIU3dGyyLznpfdaY6QO5ryrWwtK95b6MScMAVAuHHfdKH+RLx+oonESw+pMU81PWxktN6G6z67bNsQtCjzZVQureUwNw3CWqZxDDqqLZZuFnvZdEZ25md8r2ZkHpo+Q0RBQ95mY5Rd6CkXgh2mZlDCjn6YORoQKqalDQ6ugC+Raf+dcPuvWodE58QrUWtS0ygj749LQzuPuRN1VQU7+oQJhBzTFu57Sj40KthMNAekxaDUYVhOmAj5yoInafKwdhm5UaY5FrvoiFgY8FLglaExo3mp4DRTnAu15D24LA59bUEKA89lVBDrd3DaskuVKuOHMqUOvchxALbOc/ilypdfZ3icF9S/Fcj+dQvrrBBmfZxWYhZuDPIoVoIc1hq3hasdlMUs58f9FO6KrPcE8Fnw5Xg58N0P//5/LM11g5vpcO1hxPo13jeZ5waCKDV3ZNVXk2K+YjSkDaSMCVTn7boEoMpj6XJb02aa09sQJA4kRInpSSrxEF/ZVwRFYf/TlMcqYsNeQamaaIvkz3iLnjT4zvkmF2kqNMTohpAGXtuS/iJh0sTkHH2Zrb7gz2CeMWHe8gLOxzWe9vF090k7ukH0SLuNuOi2+mxTo5nSKoMh2jvmwkSGb8/iY+spHUx3t4ovAceM4XVY767DptWgC+GreZy+NaFbWsU8cncitmpf0LBZdiNITAyKXy62C X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Mike Kravetz writes: > On 01/13/23 10:42, Huang, Ying wrote: >> Mike Kravetz writes: >> > On 01/12/23 15:17, Huang, Ying wrote: >> >> Mike Kravetz writes: >> >> > On 01/12/23 08:09, Huang, Ying wrote: >> > >> > Isolated to patch, >> > [PATCH -v2 4/9] migrate_pages: split unmap_and_move() to _unmap() and _move() >> > >> > Actually, recreated/isolated by just applying this series to v6.2-rc3 in an >> > effort to eliminate any possible noise in linux-next. >> > >> > Spent a little time looking at modifications made there, but nothing stood out. >> > Will investigate more as time allows. >> >> Thank you very much! That's really helpful. >> >> Checked that patch again, found that there's an issue about non-lru >> pages. Do you enable zram in your test system? Can you try the >> below debug patch on top of > > CONFIG_ZRAM=y > >> >> [PATCH -v2 4/9] migrate_pages: split unmap_and_move() to _unmap() and _move() >> >> The following patches in series need to be rebased for the below >> change. I will test with zram enabled too. > > A quick test with below patch on top of [PATCH -v2 4/9] (without the rest of > the series applied) makes the issue go away. Thanks! Thanks you very much! Now I can reproduce the issue with zram configured. Will send out a new version to fix the issue. Best Regards, Huang, Ying