From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A633C0015E for ; Wed, 9 Aug 2023 10:47:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 907316B0071; Wed, 9 Aug 2023 06:47:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 890C38E0002; Wed, 9 Aug 2023 06:47:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6E2558E0001; Wed, 9 Aug 2023 06:47:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 5BAAA6B0071 for ; Wed, 9 Aug 2023 06:47:22 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 1FF07B24D4 for ; Wed, 9 Aug 2023 10:47:22 +0000 (UTC) X-FDA: 81104239524.03.0384C7A Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2065.outbound.protection.outlook.com [40.107.94.65]) by imf20.hostedemail.com (Postfix) with ESMTP id 336031C0017 for ; Wed, 9 Aug 2023 10:47:18 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=Qcr7nOm3; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf20.hostedemail.com: domain of apopple@nvidia.com designates 40.107.94.65 as permitted sender) smtp.mailfrom=apopple@nvidia.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691578039; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TicswDNSeh1afw3vfO5NkZMIDMmG4riqRqaHMLjJ9qc=; b=1chDNJGhdNirERBDC7QS6yzWewZ9lI9FKv4cDqLfLaXhyb5XXJ3maxOE52yiTQ3vdFAv4G Mgrzl3yrFPpskziEZ7eRGqcmv4/yvuUDRYsn82m604l1oFe8SQAmQ9l22Q7whmAVtZLQ8d pVF4YbAkMiG+1Fo+0funJge81JxlrnU= ARC-Authentication-Results: i=2; imf20.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=Qcr7nOm3; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf20.hostedemail.com: domain of apopple@nvidia.com designates 40.107.94.65 as permitted sender) smtp.mailfrom=apopple@nvidia.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1691578039; a=rsa-sha256; cv=pass; b=PHBCR3epz6pJ8f0Z100J8FY0KyN3Ql6X7OnHskyQEeLagaxCsdoDiUdJbv3g8N4ur+Ox4R FbZlYK637E+2cQDojiPbOYPUxOmnplM5BMQ6Qynf6QDSUwGOWg1a140GEr2KQ8j6d+rY80 vOKanwlYX/vG8WcV/zTCTuPyrXNHTbI= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HYt/BRopO0ZLhwIaYMF/Iv0ZjczoUPJSCQFiNzKPSIcOIOOa86E5Xvfp/+Xdkcp6bBydH2JMiEuglJLRhR/JqKLJlq6ZP9XUqV5MNt4twFBOFPrlAoirq7sSeOmMKFw51jK3RxQPqei7vq62BaDiQwGm/cVJKhGQTaJOzGMFeo46v6b97+fotXTzCaN+41OYknHgzpuuA9AWc3T4iH94bmaZlKPFLnZ50MQ+LrN+bYA1/HSS479+N4/FjKvi+hw58fhC6utczDe1q5R0ARxoGEdTr+eYO5cGwIHWhEAZbJMqgOzz2QXyRv9fx5gW9EOaKaCekzHz6a+1e3NZCKZz2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TicswDNSeh1afw3vfO5NkZMIDMmG4riqRqaHMLjJ9qc=; b=axAV7UIcb+tXZC+oF85lgbBl5eOsckFRq9Z3fRSJb7TBvCiaE7Dt+WjM7CR5q+oT938jvf5v0FqCzsWPqUpuUJFNlsozr83HztZwffiA9IqMpuZs2GFa9xb8zjf56p++7n2UeBeto6MTw/G8jV9dQxmhqfG/+SncMbc8wpBYwXWBG0M9lCZvCXW52g6Fj+hC8Kltz5BlXNzuUe19mkL9tpa0wQf/YQiw0VQIGomp3pIQU1eIROggSulNrueyCapVj7T+7VI+l87hre0YaQBIa6otgpL7JTYceWln1bo1J0R3URhQVIZQ0G4UdaazeSzfq4YSCdSzPwZ5AahAAGQIqQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TicswDNSeh1afw3vfO5NkZMIDMmG4riqRqaHMLjJ9qc=; b=Qcr7nOm37NRC8hnRLolsbOzPbPWdhEObeBRcB6/unv+rWPlPC44FiCpj0qb4kIRCPNGfnnjKfVxVhEHlTEWjdJfpaf7VI2ZD05/mn3dbsJh+5acRN2xcVRc01/B8XnrdHL9wt/rRdAMYQ7HfBxS3uhxTvANfzPtU6lnPaI9LKN8+dXtvOoeW+3cY3hg6rH29nViY+X7uxKfHTuuEBThfzmGQ0LR7t/UwUy7X8xk/kGRAQJgqxk2g4PKcWi1iP4hwWjhRlJl2eVIk4fk2nAHRLJ2+ZoH/OP8KiYeu4Z5JUzUODMq0ktZqHgOokCQqQT7hW9lsdho7MZ0CRGhoKu8zZA== Received: from BYAPR12MB3176.namprd12.prod.outlook.com (2603:10b6:a03:134::26) by SA0PR12MB7477.namprd12.prod.outlook.com (2603:10b6:806:24b::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.28; Wed, 9 Aug 2023 10:47:16 +0000 Received: from BYAPR12MB3176.namprd12.prod.outlook.com ([fe80::b2b1:755a:a175:c160]) by BYAPR12MB3176.namprd12.prod.outlook.com ([fe80::b2b1:755a:a175:c160%4]) with mapi id 15.20.6652.026; Wed, 9 Aug 2023 10:47:15 +0000 References: <20230807063945.911582-1-apopple@nvidia.com> <20230807063945.911582-2-apopple@nvidia.com> <0950ca9c-4f39-f56a-fee9-5ee42ede86e3@redhat.com> User-agent: mu4e 1.8.13; emacs 28.2 From: Alistair Popple To: David Hildenbrand Cc: Andrew Morton , linux-mm@kvack.org, mhocko@suse.com, jhubbard@nvidia.com, ying.huang@intel.com, osalvador@suse.de, baolin.wang@linux.alibaba.com, ziy@nvidia.com, shy828301@gmail.com, ryan.roberts@arm.com Subject: Re: [PATCH 2/2] selftests/migration: Disable NUMA balancing and check migration status Date: Wed, 09 Aug 2023 20:46:27 +1000 In-reply-to: <0950ca9c-4f39-f56a-fee9-5ee42ede86e3@redhat.com> Message-ID: <877cq4a3wz.fsf@nvdebian.thelocal> Content-Type: text/plain X-ClientProxiedBy: SY5P282CA0020.AUSP282.PROD.OUTLOOK.COM (2603:10c6:10:202::17) To BYAPR12MB3176.namprd12.prod.outlook.com (2603:10b6:a03:134::26) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR12MB3176:EE_|SA0PR12MB7477:EE_ X-MS-Office365-Filtering-Correlation-Id: cd31290c-6c0f-41e4-64cd-08db98c5feb3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Llij6hKdOftwlxLrlbJ0VHeLtsdaRIuK01KPDShUo6d3AxY4+qjHS6maC4hUmjVJkOFCr1gq4UVSrFAzaTgGDqo3gZgn8gQEJGNQi5Mo4qvbH66S19ZmvQftgNSq5Rrt7Gg7X7+uvf/82JjcBM4y1DmShCmK5j5aINRKbApBGdL4vufWGR4j40aRwDWZhabI2nIpprC1JKqn+DOeyIEeKVAw3bMYjoIElt5h26mYjR3dRYrXT4ovTH+EjEDYD4SKEhRC088gBkxJF6DMUJ4dtiAbsJQs+QUZSeVHcChEB0HhIK/juDRa5vF9nyE0j4G7q+ypfpTfowJKTcTQ5cU6d/yDNN/ly0IPkDHw0WYp3i1KQ8V0vQaWypuGAE59Ls9f1kDV32QR4Oby0ccxnOycAa2yT+tbcHVLnFAzM4cekdpWAr64JppYCUTzd//EBhbRF/nMUZyQ8FAH0kwP5SVpeiFNOz9xkXWOo1DDI0fwyMTHsYDw0m3YhvpA0KrxetkvSZJIT+tuExMT9K0y1F6jz2iGxePQTryOML7O6504DFXf2p71wTTxw5ZFxXwnohK2 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR12MB3176.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(366004)(376002)(396003)(346002)(136003)(1800799006)(451199021)(186006)(6486002)(9686003)(41300700001)(6512007)(6666004)(26005)(6506007)(478600001)(53546011)(2906002)(4744005)(5660300002)(38100700002)(86362001)(8936002)(83380400001)(8676002)(316002)(4326008)(66476007)(6916009)(66556008)(66946007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Jjxkx+5rK/l+SBx1W4WRIPhhGG31OZtgxGBik/iv0iTohzmuoOSuyQ4pYhr3?= =?us-ascii?Q?GyM1w5EzgZN/5sI9/oPwkNe8UUqff5H6sVWXnLSjNu7wzZUFAvlj5MamJ6SU?= =?us-ascii?Q?neV6CkF5ZKyOMjF7QjnDNPIairkJu9gszuKTt53q/o6CxRuDOGeHSkkSlsUn?= =?us-ascii?Q?jYmVUT7RWLH8isxqUqYZLs5ofofp9caTNcRArx3tvqy4fAvy15QMB5fdOyZP?= =?us-ascii?Q?K/OXmNrEwvd0g5Ya5Jbr6lDQoP+RBoUjYHiHtaFRhT2H/HOcltQJFo32K+2P?= =?us-ascii?Q?gp5SiTTzwd3s5/qv3eIWXtn06IwRyhpa9S5QVab2Bt11+L6JCqmI/9LpxqQZ?= =?us-ascii?Q?t/ilei73/N54y2/xCAKqDZ3uvieZwaetLTmDH9dxhlYy0ANWGVHgYLnhhcKp?= =?us-ascii?Q?2B7ifg33KvOzXNxZWFBo6Q0cSGuDpEvhsYrrTgDfVLK3LMbV0QXtk0eLEZm7?= =?us-ascii?Q?XzovvHYWOfLvcrVILO7Mi9pdJaLD00iaN4HehISNqHNYMJiYFhX8iFetbgbg?= =?us-ascii?Q?0z2GBvhI8Qx+0GAYFEpfAgFsFL58UlQx5KCTt9pBeSP222+w1gwXfK9tPdHo?= =?us-ascii?Q?QlPx/G/uSUglJTE+aZ2du5MCZ+nMXqbWpgWVLzgwTZdp/+2gBpcmHojuj6Zf?= =?us-ascii?Q?gNZBcFawc+QJj5JKGOC4T7xKUdNrybxyhwal9LF4qZcYxpPQfIB0SvuHQbae?= =?us-ascii?Q?DTpe0cqaslvhB+eEKrcqhQaO76NC+WVxNa78A+1pQpIZ1oCpoGFsbMnATIlV?= =?us-ascii?Q?DV9uhvrTbfAB6FJ/9ZMP312TF56sw6vxfOxoEyQFgHTnLx/q4G9jlJGCI3LP?= =?us-ascii?Q?9OSzWwkRS1W2zWDvnkbMGq+8guYRlqYYYAfmB7P15xNeq8BxSyPiyOAT2twV?= =?us-ascii?Q?f2q9ZVBm+ioa82skGGPji/9H20m4q6RZBtbdgUq1k8HAuK8rq0By58YuMqf4?= =?us-ascii?Q?DrL1oq4CTd7xJZvyav2VcwDjvGyoqti85OOYNVGcQy6TBJy+NKfO8RSk80Ng?= =?us-ascii?Q?H6T9ovogUR/cyPtk4Kg8Au9xNfUkC4s4CpCDQTTeVYX052H2XozP7p/Ly0/x?= =?us-ascii?Q?XK8NtgdJ9wOk//QnQLXhlpgyBaZx/S6s/IMwdinbK6yRguO8IvJ3fnHXDQd/?= =?us-ascii?Q?/JEVW9RHwBHFvlEzhYo3OoMFUCsQ/Oi7vjN7AGiRd0QiHaq3H20ZcPNucQC/?= =?us-ascii?Q?r/gxYF/kRdCb0HM6LUuV440EEfSHIwzD4A1YiM2/4K9kFhDekhWMfnHjNBTk?= =?us-ascii?Q?r81uWahdD0P109davrxk/zPfR9Yfmtq9ZZ527G8QWnR2xmRL4bbRpG2bkSci?= =?us-ascii?Q?jTdo5ghmY2gDIiGodMuoqmnix15BFar/8OF1CdrL0QAqL/5RJjWgbmfbzau7?= =?us-ascii?Q?aD3JvghrDtlLXb9U3F0aaxnrcP3wTX2H6JROYaDvRbM4SG03w1bD8A9MT5fx?= =?us-ascii?Q?3bcrprWp2yoON4BbqjH8OoCv+XhtlnNNQYG7kJOKlmAjCzqu+VqVArIN6pJn?= =?us-ascii?Q?wiqQE1CmunaehPYkdNdI0jdepY2l+vtJZLd2CKd8nVqkZ4ylho5+7C80Rz/k?= =?us-ascii?Q?bl1h7fUaL8IRPTz/QMT4KTp4Vfz5d/USHrqO3iMX?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: cd31290c-6c0f-41e4-64cd-08db98c5feb3 X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB3176.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Aug 2023 10:47:15.4577 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UXNwvKOYqYtwWQDP6eziu+PzBmfLLTttS6ugmzwSK2LFAwg8aXKxnhSP9HSUkYLt1bDH8tYHhWeZ6HILj9aqog== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB7477 X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 336031C0017 X-Stat-Signature: ue6wggb3zubjueiq1s5nroryzpkietsu X-HE-Tag: 1691578038-895492 X-HE-Meta: U2FsdGVkX1+SeZY5zErcP61efUNb8QOjRwKLmSEcwJzwWy4ug+KTtySFhJL7rupdE4pPTyv5twwtvBYBqsva/eVYZ49weqPyHKefw43CnSXMqkKmEPCtCOj+3AxtIeLgx7XeFdP4PfSIZEqEi3rMHLOBobL0CUuUTp6IY0UeMtGtgfNRw05vGnvYELbVjywbd+aWGUVmHWYWYlo4WR9DJnJKKWeP+cN9OnrCpJHIkkGiSpjZzT1pWbCW/cmAetQMgdyzOHj6x3u1MarOXB7/41YP+QxEod7d4lW59X+rqDJ1tV4eoECvTQb7LtSkMeqsDqOZoCVNbBcHzmOxk+o+L3aZuCuDzSv29uIJDJ7NxydhoQnp2L3Qg5wJ9zd0Gki9g/PROGnaLi5mNS1J52TmXvJZRVn4kEzT2Ua0d+SHkDQ+zkcb2/c0tTwrHX/cu6F5YJs+hwoCzVr57UhP6OHdOwvQsrermPqGmSI34UwXBB9WAM6ayyFsHKE+MAmev6lDbpp6O++kX19r+MHTnCgNLtF9fJc0SqEAQ+8D8nR+JVl/ebhuek/9HUhxvGq1t2V+mdy+ab5vJ30SlA9pYn0SOgSn5Mf7j4UReeiqU91OcW0bP8MrqTnCuSN/F/5j/IL1cOpfhMl+caMBcLW6kzGc0kj8jGhWYQNcR0ozoKEOb6DZX9xMw/oUpMNb9mZCmNZ9zWNFg6dpiZZL3inxcWCD/jNK/zQaaBmZNQw/0EKmCYAVeZ2IBMWS5lRh6eeCBlNwmKDIUMTkvaL4FXrGJTJU8PUZdBqXNCbQpsod/3fUv7AndA5Q4VjjHOYdxgRNPZSBbE/2vsIHDWm6bExheYglE7MWaZqEO6jJFYA+vP55/3crtkznyf6gT+jnG72qIDPVWYDdbf1QpLo6hIojXkeqv7SgJBI5GN0eGJMxgYE8slpY8qdEwSuB5CasNj1NblOgka/1tZzsLcd3xXjnSMR qVn7axgp XVW13d+Aig5Q0vC/U0bzV7fdJzctyg5nM35mb2+12gEBXQm6DUWm4aena6tTCViLxQLKjax9diPKCK47VZquSl2fTWxbc3gjZk8DUHCQbHEbaq6Ikga76rOKy35YlDv9wuXNiisJGuYR2Z5g= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: David Hildenbrand writes: > On 07.08.23 08:39, Alistair Popple wrote: >> The migration selftest was only checking the return code and not the >> status array for migration success/failure. Update the test to check >> both. This uncovered a bug in the return code handling of >> do_pages_move(). >> Also disable NUMA balancing as that can lead to unexpected migration >> failures. > > As raised in a sub-thread, is that still required with the mm-unstable > patch: Oh I must have missed that sub-thread. I will give it a try. Thanks! > commit 3c471b04db7604974e3bea45e2d9c7c27a905536 > Author: David Hildenbrand > Date: Thu Aug 3 16:32:02 2023 +0200 > > mm/gup: reintroduce FOLL_NUMA as FOLL_HONOR_NUMA_FAULT