From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09195C61D99 for ; Wed, 22 Nov 2023 15:19:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 87DCE8D0033; Wed, 22 Nov 2023 10:19:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 804D18D0008; Wed, 22 Nov 2023 10:19:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6305A8D0033; Wed, 22 Nov 2023 10:19:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 5137E8D0008 for ; Wed, 22 Nov 2023 10:19:40 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 244B41A0CEA for ; Wed, 22 Nov 2023 15:19:40 +0000 (UTC) X-FDA: 81485949720.03.9EF3A3F Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.120]) by imf15.hostedemail.com (Postfix) with ESMTP id 4042AA0012; Wed, 22 Nov 2023 15:19:35 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=CmDuEDQm; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf15.hostedemail.com: domain of jani.nikula@intel.com designates 192.55.52.120 as permitted sender) smtp.mailfrom=jani.nikula@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700666377; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pZ1c+9X04FrYrFYPjnCvJIC3RwZu1k3OXvLEgz+oyeM=; b=rPW9ibnoRbME6rxWLMfJtpp390VGnQN8qRt+2krHrepc4t3zX8fGca944FicLn48R32KCk NcK/OG+VszBWBjrc0fGapfgl5gzRe8PeOY17UbqKFNotVIXdxRxEJP5Q7mW9tJinirex4k upm49q6KJYq6228dBV7ZrHjT5bBBSAg= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=CmDuEDQm; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf15.hostedemail.com: domain of jani.nikula@intel.com designates 192.55.52.120 as permitted sender) smtp.mailfrom=jani.nikula@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700666377; a=rsa-sha256; cv=none; b=I4WCeD6ak/aRiCR+RnxIIAqBHb6hj7F6sU66kR/OQDkInnbnxL7KMcSdumKZNgAYAnqLWn fNDQX8W5GdaYuvx0DcnjkDPS2xlq4iHiOV2K9qmWmQTFRuZ29Hl58GMGirKQHTinnyZS4C 347ManAHCyY6oxJAX3xoEJdk42PUVcI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1700666376; x=1732202376; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=nrNPcz4uYEQBP3pOrCUXcuO8X6G/FSLQKBhZfBz9dLY=; b=CmDuEDQmq2H5tlnyhqDOHsrqmK/hzcD4/jQgzRIgUEwfjEc3nodzq6VJ D8Da+oCNuubX8jOHPZTVAxmwgdg2RFvGR/VSQo4B10cggRBOcZjPe35s5 /kHQ+3707EQpqx1yH8TxDJl6FS4/xXx2aNMEAPyzqHMdUPSwOjamGs5Fr YzNsgt/BYeBSAXVrKBo9SNNtP/R5MtFBhr2o6vogjBO77a2BJa6iXYjnQ 9MaF0DgGZak21DtCTqKcYDSlvN7wMrnS2YYx2QgM9XDWYtdZmPQbY/JDZ vbVMsNwYpoz0vrohqXqfIKbHQfe7Mi8BP0bnh3wZBfjpVAciT4HxEKRgl Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10902"; a="390932779" X-IronPort-AV: E=Sophos;i="6.04,219,1695711600"; d="scan'208";a="390932779" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Nov 2023 07:19:32 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10902"; a="833052538" X-IronPort-AV: E=Sophos;i="6.04,219,1695711600"; d="scan'208";a="833052538" Received: from tjquresh-mobl.ger.corp.intel.com (HELO localhost) ([10.252.41.76]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Nov 2023 07:19:09 -0800 From: Jani Nikula To: Christian Brauner , linux-fsdevel@vger.kernel.org Cc: Christoph Hellwig , Jan Kara , Vitaly Kuznetsov , Sean Christopherson , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, David Woodhouse , Paul Durrant , Oded Gabbay , Wu Hao , Tom Rix , Moritz Fischer , Xu Yilun , Zhenyu Wang , Zhi Wang , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , Leon Romanovsky , Jason Gunthorpe , Frederic Barrat , Andrew Donnellan , Arnd Bergmann , Greg Kroah-Hartman , Eric Farman , Matthew Rosato , Halil Pasic , Vineeth Vijayan , Peter Oberparleiter , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Tony Krowiak , Jason Herne , Harald Freudenberger , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , Diana Craciun , Alex Williamson , Eric Auger , Fei Li , Benjamin LaHaise , Christian Brauner , Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Kirti Wankhede , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fpga@vger.kernel.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, linux-rdma@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-usb@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-aio@kvack.org, cgroups@vger.kernel.org, linux-mm@kvack.org, Jens Axboe , Pavel Begunkov , io-uring@vger.kernel.org Subject: Re: [PATCH v2 2/4] eventfd: simplify eventfd_signal() In-Reply-To: <20231122-vfs-eventfd-signal-v2-2-bd549b14ce0c@kernel.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20231122-vfs-eventfd-signal-v2-0-bd549b14ce0c@kernel.org> <20231122-vfs-eventfd-signal-v2-2-bd549b14ce0c@kernel.org> Date: Wed, 22 Nov 2023 17:19:06 +0200 Message-ID: <877cm9n7dh.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Queue-Id: 4042AA0012 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 7g97xyye1pej5fmgy96ztmbo4bti3f9y X-HE-Tag: 1700666375-267955 X-HE-Meta: U2FsdGVkX1+lGtXueJHXMvyx5Ro5OZyIeQiTdMDTZ5PaDRFu83k1IXIhnX56V8CwuaxMTtqLVj/jddhvjX1m2UpLG4IEhrp+INzPK/3j93x/+61UHDnaIjnx4UCj263bzZlZl46acokzms4aVAYY2qUyeLZ1PlVEvaKiZpB7oQBUGwmK39O5N7oS9OV/RrAjqsV3MTOCj6TEtKhT4ooT7tlYHXnA9kB/6V+3aFjDR2TUj/9VXC5lhU/O0ldT7YqDiJCqU5YxfjUx3encQo0GXoEl5h//S1TloKBE6pxgU3ZawAdS+gMN5U+/+uIjgiHfUeJvDlQGMHKYavIaoj98upQUwSnE7HpWo29Ruwf5lcWeMD6E9B6k4NrLKk6s/Dg7SyFFr0i6qLruCqZYVluztPtgYIijSfCWE8XA14AEoaUEUaQJ0toF2QLMYVjUoJo+wG0sF3hrxP2V2AEBYKPpPwM7hlIwDrAKf2ilYq0LWKc6Y/YDzJ8Pq+YFGWBb/ii6jOfbRX3tkd/xE9pI+RvfLzFkkP20H+/r9qQyz70i5ldOXAkqBgXT+Tk6F0+cvVIyvVRUJTEbSSd4XTZPYxk7Q5pmGfMGOVfelm3rjgp4pmek/XQx3Rk2Qquk8GU+yQ6/zNEnqyu3IFUU8pqd+BmajwaR8Y9IIqEkU1bre9QshzDIZt+YptH3cnBW1JmjefDYPKR4Xqem7h4eqI1uTdfq4XyfzNBvkKspCM4X7tcj2nJ7XXaB3tUiq012qIUvT+2LM4K8rnEwut3eUil9JwbkFYi67OTzz0aFpEsIjY24GsxkGOirP4MwFPx1GgRIzU6pPOKjSHyXIcuxVKOfaAi1GS8HoO/vUmWAzp0bfWSZKJ4GtLGaEPskQ2XUx3QKEkeIhx4GnHoXNSKGlqzYzvf7obZUWdscq1vC+c7w15xkQ3KkRx9wfWL5fSDVUmxDgMTevSR1JsbcTeI0tawxT+b z5SrvuLD +XqdWsK9ES5MOeRTYe/RJXDFbHCsyUfhzdE4Cchlns07kCTecOSCH/97umFXwCq5l4HCk4vngAgRmg/iAAvfAnuksCF2d7iHHG+CpI3C6y75DbR3K9LB3ZN7b8m9YgwNQq6s2f6EiSxRyXPGpxl4/itiAUN2H/GRJybmWE5tHBkBNxYLe6u97+4Wamv5NYxUabrBl8Msdy4QXpLtckSjNfIuFQfp4qQhkZrUlr+oymToiKD9PNWA2xy/8EdqMrUuStvvGZvIPWg3aj38/bw/ju1yFDlCn1A9EVN3dBqCTMpCpBPq7M7CemFnVETscK2ATlaa4LbdEV8+ZLn/hh02b3vZS3YZf0BWqqOFrFYCfSx16dqkprIxr6X24CU05lwdUg4vpZDHMYZRpY75mPgNAeSvYXgyODJKRNXB5hoilRfxNX+kFoQHKq1esezrZGl4uNfyjBEvPJXdKMQ85wuSL4vvYxtELqZeBYbem X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 22 Nov 2023, Christian Brauner wrote: > diff --git a/fs/eventfd.c b/fs/eventfd.c > index 33a918f9566c..dc9e01053235 100644 > --- a/fs/eventfd.c > +++ b/fs/eventfd.c > @@ -74,20 +74,17 @@ __u64 eventfd_signal_mask(struct eventfd_ctx *ctx, __u64 n, __poll_t mask) > /** > * eventfd_signal - Adds @n to the eventfd counter. This still refers to @n here, and in patch 4. BR, Jani. > * @ctx: [in] Pointer to the eventfd context. > - * @n: [in] Value of the counter to be added to the eventfd internal counter. > - * The value cannot be negative. > * > * This function is supposed to be called by the kernel in paths that do not > * allow sleeping. In this function we allow the counter to reach the ULLONG_MAX > * value, and we signal this as overflow condition by returning a EPOLLERR > * to poll(2). > * > - * Returns the amount by which the counter was incremented. This will be less > - * than @n if the counter has overflowed. > + * Returns the amount by which the counter was incremented. > */ > -__u64 eventfd_signal(struct eventfd_ctx *ctx, __u64 n) > +__u64 eventfd_signal(struct eventfd_ctx *ctx) > { > - return eventfd_signal_mask(ctx, n, 0); > + return eventfd_signal_mask(ctx, 1, 0); > } > EXPORT_SYMBOL_GPL(eventfd_signal); > -- Jani Nikula, Intel