From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40FBDC4345F for ; Thu, 25 Apr 2024 01:47:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A679C6B0083; Wed, 24 Apr 2024 21:47:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A180C6B008C; Wed, 24 Apr 2024 21:47:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8DF456B0092; Wed, 24 Apr 2024 21:47:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 6FA1E6B0083 for ; Wed, 24 Apr 2024 21:47:54 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 1CF9140242 for ; Thu, 25 Apr 2024 01:47:54 +0000 (UTC) X-FDA: 82046368068.22.112918A Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) by imf24.hostedemail.com (Postfix) with ESMTP id 87825180006 for ; Thu, 25 Apr 2024 01:47:51 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=ZcSlND4x; spf=pass (imf24.hostedemail.com: domain of ying.huang@intel.com designates 198.175.65.20 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714009672; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TOWCJXaUYz8LvaB7QyVIP9pABuSohi9sZGnHr5lsGjI=; b=O29V/XVT0lGeQm5XiS7yJzsoKdrrF4+KvMOJ3/v4Ldgiivtn9Me4PSkqXSD0/e65h4tpg5 paul69A/EMzC+lUiOb/xuy3LCiP827oI6uYFLRILsg8ISc7+8PB4Eu84cjGkOqnV8EnHWR /ZkG8SqOnUqCO31LOKWgpYmxiWzOjd4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714009672; a=rsa-sha256; cv=none; b=OFn0LkgtP2ZB9Hqn8ex2EVsW7AG0aZ3CTY2XP0oEsXZGfsStbmQiE73WonHhilIpVbq4Xm zrLSRnJEPnNGVwuTBo2TeDhTtAiSn0JHLC3mTO+S5UBcRcWMEMW8G8j0U/3PaBvQAT+Lyd GRa+scrjQoYN/4+Ex++B0QDCheWmOGc= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=ZcSlND4x; spf=pass (imf24.hostedemail.com: domain of ying.huang@intel.com designates 198.175.65.20 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1714009672; x=1745545672; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=84OBV4AVX5jU21PKxSUDJXv7xn2sKhHvHcieaawC13s=; b=ZcSlND4xcoqbgIBdcz8K5fkcBmBSVIKhR0R0dTIbpkdCDpUx01amT/Gy 40tW38w5rLpM7FOSdGkCCZaQQ07DbAklA5qF4K8dFF8NvZ+w4xiLEq5Bs JONWmP1soKe6oJaO8aGnIJMnr55Q/xm6DnK5SC+dfYmWE8d437LxKU5dr sjxL7CmA65TIc3YUhbPtYTFFgeppDIFLesL0RfAuYwGuHJgNXeJ+RMavu UAPxfVhZgvzfPt1Uw1kmSffZ8ZYlQPamyLCMXhjP1q7VTNLdSx29h6471 LIe7hU7OYwAaFonKSJhiys+kte1DDTCzjloclLx3oW5zD8wGPa89TT48T g==; X-CSE-ConnectionGUID: F3INSDmSSomRdMV+f+JGHA== X-CSE-MsgGUID: GWdYxTHeSTiMrUIbD/oJEw== X-IronPort-AV: E=McAfee;i="6600,9927,11054"; a="9499729" X-IronPort-AV: E=Sophos;i="6.07,227,1708416000"; d="scan'208";a="9499729" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Apr 2024 18:47:50 -0700 X-CSE-ConnectionGUID: t74vQwVwTYWHrQmRZeMvaQ== X-CSE-MsgGUID: pryjdDcETT+potaQIaxHJw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,227,1708416000"; d="scan'208";a="24945132" Received: from unknown (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by fmviesa007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Apr 2024 18:47:45 -0700 From: "Huang, Ying" To: David Hildenbrand Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Hugh Dickins , Alistair Popple , Anshuman Khandual , Mel Gorman , Miaohe Lin , Minchan Kim , Ryan Roberts , Yang Shi , Yu Zhao , Kairui Song , Barry Song , Chris Li , Yosry Ahmed Subject: Re: [PATCH] mm,swap: cleanup VMA based swap readahead window calculation In-Reply-To: <49d85e19-feac-417b-9640-ff8059bc8b0b@redhat.com> (David Hildenbrand's message of "Wed, 24 Apr 2024 11:23:10 +0200") References: <20240424063042.665018-1-ying.huang@intel.com> <49d85e19-feac-417b-9640-ff8059bc8b0b@redhat.com> Date: Thu, 25 Apr 2024 09:45:53 +0800 Message-ID: <877cgmrz8u.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 87825180006 X-Rspam-User: X-Stat-Signature: 5trhpz9ge5k7yp3jf1aensfd39gx361o X-HE-Tag: 1714009671-303536 X-HE-Meta: U2FsdGVkX1972t/eMP7g5iwnGkHALXndLPDtybhnlOjdb5RjsyVE+sxycQKayCH2N1GoHPvPlQIe0j9oJn7VGQUD+rNMjWMBOThCPhKmbLozSF9MPlYMEj2lMngN90EdSWF2lYFB6BflJSzYo7r0wQNwPK4sQz79nRcnzS//SPpvQhNhsMg5KyRn0QtAA+EWSxPNH6ZNXTCsRSic7KAMkznD06ke45FHoD1MKCxMtQ/0rs0HomnJU2iM5Kzm7TyQwFQAmNREKiO7d/xAyM7tWYzA0SeoMxyTwVNKa6VMI1KWk09bJue8kjkHsyGF8z6FZJVi/Jh8SbmddZ/sw8Kxqnh/6p3e3vtsge8kNrqE+urUFyzjv0sYvV9b5HCC9z5JQ2VvBkIz4Zty6kGFcdskf9YWV8ioJCbAMyfQ1Mjkfp/3FYoRzfDcAQTdUHlfSbRYDD/VjBE/eh6KPMbrIBjvFaHdNld4P7s21/Lv9kEMzj1X8/9Q0iLITth5x1wQKyBX3pdknJnFr8qWydqtfxPOtFaPcjUxv3oRsW1Obrlr07rWiU5wo+pLRleZQfnOMWVmP3u3RA+ympnICA5Lnl4T3kwd/sWE+uEJ+ZGPTa5i5dWjKuE9m1iOaCXo/VFHsn0hZiL3zx1LmnT6AgGDJR/h/8E0scpW/L/1YIHNeldvzjMiulOJe53hoxnDZ5ieum6NQ5mMr5T5R+Fguav8s9nHnMO+ykpoJDoJs9IkSTTZK8xscLX+RBgh06mbZ0YR3QDYCl7Sj6L2uRVVU7VOR/8lsWivTVxwNJENyAfDFD3cGgJMrlVWxC1I2ZK+hwBhsGaNKQ33UgM4+GgN+yN5ZxuwAslQQYbMeUhw5j8r0u6nDXbd+hjJF3IAsRCZSNw4HlO17+HejRzuKj+z/O4leyzwx6alNVeYmyIB6V/0H8WCjq5Xl9NzUfFrKwGs5N7xTVPIf0GGXG3K3Zj3oql8WSn N0MF+n9P u2VEtbLlvnwDFMv/9tIzoPk41Oi7yGfPZBRpcMmge4vwivaz7fegGAa5ovX+56Oe1ldlzv31pz4f15lrSzDyM83n19y/07/WZcTSskMJ9z/fn43qMLCwMXjlLv18gMLRHBAj1j/1ku66GHejEWurAUngl2JP8Zclm9OJR+gvlOZe0IrM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: David Hildenbrand writes: > On 24.04.24 08:30, Huang Ying wrote: >> When VMA based swap readahead is introduced in commit >> ec560175c0b6 ("mm, swap: VMA based swap readahead"), "struct >> vma_swap_readahead" is defined to describe the readahead window. >> Because we wanted to save the PTE entries in the struct at that time. >> But after commit 4f8fcf4ced0b ("mm/swap: swap_vma_readahead() do the >> pte_offset_map()"), we no longer save PTE entries in the struct. The >> size of the struct becomes so small, that it's better to use the >> fields of the struct directly. This can simplify the code to improve >> the code readability. The line number of source code reduces too. >> No functionality change is expected in this patch. > > From a quick scan, you perform quite some unrelated changes that make > the code harder to review than it should be. Consider separating any > cleanups from the core change of removing the struct. Sure. Will separate it. -- Best Regards, Huang, Ying