From: "Huang, Ying" <ying.huang@intel.com>
To: David Hildenbrand <david@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Hugh Dickins <hughd@google.com>,
Alistair Popple <apopple@nvidia.com>,
Anshuman Khandual <anshuman.khandual@arm.com>,
Mel Gorman <mgorman@techsingularity.net>,
Miaohe Lin <linmiaohe@huawei.com>,
Minchan Kim <minchan@kernel.org>,
Ryan Roberts <ryan.roberts@arm.com>,
Yang Shi <shy828301@gmail.com>, Yu Zhao <yuzhao@google.com>,
Kairui Song <kasong@tencent.com>,
Barry Song <v-songbaohua@oppo.com>,
Chris Li <chrisl@kernel.org>,
Yosry Ahmed <yosryahmed@google.com>
Subject: Re: [PATCH] mm,swap: cleanup VMA based swap readahead window calculation
Date: Thu, 25 Apr 2024 09:45:53 +0800 [thread overview]
Message-ID: <877cgmrz8u.fsf@yhuang6-desk2.ccr.corp.intel.com> (raw)
In-Reply-To: <49d85e19-feac-417b-9640-ff8059bc8b0b@redhat.com> (David Hildenbrand's message of "Wed, 24 Apr 2024 11:23:10 +0200")
David Hildenbrand <david@redhat.com> writes:
> On 24.04.24 08:30, Huang Ying wrote:
>> When VMA based swap readahead is introduced in commit
>> ec560175c0b6 ("mm, swap: VMA based swap readahead"), "struct
>> vma_swap_readahead" is defined to describe the readahead window.
>> Because we wanted to save the PTE entries in the struct at that time.
>> But after commit 4f8fcf4ced0b ("mm/swap: swap_vma_readahead() do the
>> pte_offset_map()"), we no longer save PTE entries in the struct. The
>> size of the struct becomes so small, that it's better to use the
>> fields of the struct directly. This can simplify the code to improve
>> the code readability. The line number of source code reduces too.
>> No functionality change is expected in this patch.
>
> From a quick scan, you perform quite some unrelated changes that make
> the code harder to review than it should be. Consider separating any
> cleanups from the core change of removing the struct.
Sure. Will separate it.
--
Best Regards,
Huang, Ying
prev parent reply other threads:[~2024-04-25 1:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-24 6:30 Huang Ying
2024-04-24 9:23 ` David Hildenbrand
2024-04-25 1:45 ` Huang, Ying [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877cgmrz8u.fsf@yhuang6-desk2.ccr.corp.intel.com \
--to=ying.huang@intel.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=apopple@nvidia.com \
--cc=chrisl@kernel.org \
--cc=david@redhat.com \
--cc=hughd@google.com \
--cc=kasong@tencent.com \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=minchan@kernel.org \
--cc=ryan.roberts@arm.com \
--cc=shy828301@gmail.com \
--cc=v-songbaohua@oppo.com \
--cc=yosryahmed@google.com \
--cc=yuzhao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox