From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8FC4C3DA64 for ; Thu, 1 Aug 2024 20:19:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1EFEB6B008C; Thu, 1 Aug 2024 16:19:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 19F866B0092; Thu, 1 Aug 2024 16:19:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 066316B0093; Thu, 1 Aug 2024 16:18:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id DBB806B008C for ; Thu, 1 Aug 2024 16:18:59 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 8F3C1A1039 for ; Thu, 1 Aug 2024 20:18:59 +0000 (UTC) X-FDA: 82404790398.05.B68744C Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by imf08.hostedemail.com (Postfix) with ESMTP id 9BFFF160008 for ; Thu, 1 Aug 2024 20:18:57 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b="46SWz0n/"; dkim=pass header.d=linutronix.de header.s=2020e header.b="/SWkC2PP"; spf=pass (imf08.hostedemail.com: domain of tglx@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=tglx@linutronix.de; dmarc=pass (policy=none) header.from=linutronix.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722543493; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9brb0g5cHyHLjZZ88SgjMpAtNZQfiLpqo2Zn3LJIxJA=; b=yIKO46QCbrH1Cvy2QRJz/JeCWMzM1Ig10rT+8oyiYe8PYChSiZ6mNE5//dqr9fEj5GKs0i +TrpqV46etxcH8EPB4XJRq8yuQxOJXRP9CyLAWpqF/d0S2PrUhB9yIDq9utb19QiyxdksC 0ETJjTE5blTpYwf9+UOXKoYC5uP9Zbs= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b="46SWz0n/"; dkim=pass header.d=linutronix.de header.s=2020e header.b="/SWkC2PP"; spf=pass (imf08.hostedemail.com: domain of tglx@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=tglx@linutronix.de; dmarc=pass (policy=none) header.from=linutronix.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722543493; a=rsa-sha256; cv=none; b=AFVH6KQF2/4mJsPAOoKSiqVyy2mkzcXTxdO2MHh+Ab2IDwupEilOh0RvOtfsttolvicKL5 DU19RrRlPlkVs57+nkKMTqH3m+Myg+980G0l4p9zOP55SFNEoANPGH3au5mVYh51NZ+AFz cHPS16dUYZwpuck9uSkDi2NnS7SBrOc= From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1722543535; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9brb0g5cHyHLjZZ88SgjMpAtNZQfiLpqo2Zn3LJIxJA=; b=46SWz0n/qHoheH1igvZp3Fk8J8jwjtMUmW9lT4ZM6n5ISglwvNQEDy1AZDiyxyhvhVWUPU owQylw3oMGYO4P1icQzlQPYSVHSvcLk3KOE31TZqy3ayEHeeDzAIfXIuVYZCb8J6ffqg8C EguK+Y9elgpt459sC3z0iMKIdPBDk1PqYG7S7h7syn4N8659AdAHoRt13mbydMBHJXthW4 eJdnvQ4+e3cUFpmdqbS5vfG2VY3+qIyPRD2/s3epMOeWVKr2rYVtqETb5t9/+19Z9UiCn8 zOARgEHdcL7IIzMfi0zwtlupmbdJCPS0RDSTDkjSbEqbHT+Bk8OdXutH/7jQ/Q== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1722543535; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9brb0g5cHyHLjZZ88SgjMpAtNZQfiLpqo2Zn3LJIxJA=; b=/SWkC2PP+lnx4oMKJ5VMvEwhp559g29hFh+kIsSydpZphym7c6R/12X8nK7R1UwhJb2grm KRYDdQUJmNQaUCBw== To: Aruna Ramakrishna Cc: "linux-kernel@vger.kernel.org" , "x86@kernel.org" , "dave.hansen@linux.intel.com" , Ingo Molnar , "linux-mm@kvack.org" , Keith Lucas , Jeff Xu , "rick.p.edgecombe@intel.com" , Jorge Lucangeli Obes , Kees Cook , "sroettger@google.com" , "jannh@google.com" Subject: Re: [PATCH v7 2/5] x86/pkeys: Add helper functions to update PKRU on the sigframe In-Reply-To: References: <20240801065116.2088582-1-aruna.ramakrishna@oracle.com> <20240801065116.2088582-3-aruna.ramakrishna@oracle.com> <874j844o3q.ffs@tglx> Date: Thu, 01 Aug 2024 22:18:54 +0200 Message-ID: <877cd02dzl.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Stat-Signature: u5bb88uadcjod49yc9wy36r53fwoino6 X-Rspam-User: X-Rspamd-Queue-Id: 9BFFF160008 X-Rspamd-Server: rspam02 X-HE-Tag: 1722543537-258918 X-HE-Meta: U2FsdGVkX1/bO7sz3pOnmcxz4EMEfysK0wKBBn/RBNTyFRDg3OqaVKii4iRdqGEvAaVBDexDYdNqfPYByqflZUWUPBBS5W/phE3OvEnmt3hk10rNurvp6QTp4kNUYzNkIyH4+9q3rTUxKagqOsJlMxVDWz5v+Cz9+/9+aNDBHlQptXFLTb5Mzo1XdfKAY+58VfJygQunXk1+xB14XaXs5IScu5OwPut25ZzxpoAUDtSTtIAZXsr+b4wVZtAM02+e5ybg+NaRvDL3ZZs+D2boTBPtKKqBVzlNnqZcYtJZWxLVAK3l8dQeZLvRvAeNLEHGLPvUibvIFVA5xZlcmSBWRZZOFei1116htGmk2k/h3f3QhB4UIDpHZLCValiqmi3uhJIUr4sYzHIhI1UNc7m1W33KgIU3vZsXBTHWmdRJoh27oZVQNjbCLtvr5y6Myl1+tWjEI7W3XhKXY4/qJqJF3r7EAKoAGJSNIrOcRkKRfW/JPXHfHwe3YOSiUGRmRNisYKSKnLP8VoB0iH2o2/eRa6QIReWGd+SGKipza+1tF7AHQOa23k9kY0V4Mk0hA786ygU3F68S/t/dZsLpWWqXybax31BZehiCBkmWfMqYfSYXqbat4vuYVAgspKTXc1vDqh2aZOwaxMnqNXJK8jP9DzQggdY6F4AYdh3NZVqKULRWghe6mBMQhSJh6E+jNLIRpRt4h/uLkTCgLienFmj3DRRfY72rQbGvZixkW9y2aolzjYl4wKWTO60IaWkNKIviBnB2Ufd8W/Va3t7nJaTaHpS6+nzKCPxxWj1Pl9WEXdZRZXEU2ghGwcY9FB9ZQDC9LM170IrZPU3K+0jyzHDZg4T4qU4BWBhlUzxYiMeGfM2Qnw3ZjRU2T9X6em26QwgW9K+V3qIPbJfR9HCvN3D9zUrvbM5R51eSCkzofBIWDKB9mTSseDjDOyDr3jFggOVe6e/Snn8Yi137WPt+TAL XQcRi27G j1oVnVTrVUi4cce5jq4MLLcDkxn57mxCin2qYKDEt3WJ5Dk166qYpFUHGtrJ+ND5o8kwyHDOkmiOUi0nkxzNLTAv+hcqt/nxqpqCaCS3MSHIbPVz3HRq47OZ+00pyI4GOtxBbNl7RNLZx3Q/XFIQKqMVyZs0qbI1SGWNbZdw2ixP3V6cOV8VDY+tuCUGs3rIwjqYUlJrFLFObSaQajP/hALoiTHkYDMtZJM0r8FX9/Mohff1Bqx/dxP9T0/9CyuQLqq0NlKsISYVvjQPID+PiI5dLnmK4/mW+UChVOMPy0dKStE7JVHjlrWOBe3Zurce3lDA6MH22yu5yHdg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Aug 01 2024 at 20:14, Aruna Ramakrishna wrote: >> On Aug 1, 2024, at 1:57=E2=80=AFAM, Thomas Gleixner = wrote: >> On Thu, Aug 01 2024 at 06:51, Aruna Ramakrishna wrote: >>>=20 >>> +extern void __user *get_xsave_addr_user(struct xregs_state *xsave, int= xfeature_nr); >>=20 >> *xsave lacks __user >>=20 > Did you get a chance to review the rest of the patchset? If you have any > additional comments/suggestions, I can batch those fixes into v8. I did not find anything problematic. If you spin up a V8 you could polish your changelogs a bit and give them some structure. They mostly consist of one big lump. See: https://www.kernel.org/doc/html/latest/process/maintainer-tip.html#change= log for some examples. Thanks, tglx