From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E396CCF8543 for ; Wed, 2 Oct 2024 21:29:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7692D6B02C7; Wed, 2 Oct 2024 17:29:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 718CD6B02C8; Wed, 2 Oct 2024 17:29:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5BA606B02C9; Wed, 2 Oct 2024 17:29:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 296B66B02C7 for ; Wed, 2 Oct 2024 17:29:38 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id C65F3141018 for ; Wed, 2 Oct 2024 21:29:37 +0000 (UTC) X-FDA: 82629953994.12.907E747 Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) by imf17.hostedemail.com (Postfix) with ESMTP id B2DD540004 for ; Wed, 2 Oct 2024 21:29:35 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=krisman.be header.s=gm1 header.b=onbSexGJ; spf=pass (imf17.hostedemail.com: domain of gabriel@krisman.be designates 217.70.183.194 as permitted sender) smtp.mailfrom=gabriel@krisman.be; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727904447; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HncRwIusYKLU1a073mDPta5phkAfT1syOg05rFDwoQs=; b=r5fpN5QcVgZVhlwWcuCJ7evcoay8MozQDTZh6Xf1TZ4tRPuGJW3YC9o0Wa3uoQqw18T17O 5ZLchyLoMfI9kJoo1J6rvlHxY+vwg41IwlcIBs7HbNp634EHvi7uY4wLriQ3SCQl/tYc/w aFveYquXvAW2RwOsf6O3UBGgF9P7FPo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727904447; a=rsa-sha256; cv=none; b=h7OQDQiy7kQLwvV4LDEyFlQAWut70Cj/zhahDc8VmpDFt8G9DrsBPoQQL2oyJbDQ7XJoIo RQCSLUILM8C1Lx9NMxoi7ZvSC84crDgJQyGLa9MKR/OhMKVHe5g9GXZlyRs7bF4lplMrHr mJkZhN0R0whjeNBm9oBoTOIvOwhRfGg= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=krisman.be header.s=gm1 header.b=onbSexGJ; spf=pass (imf17.hostedemail.com: domain of gabriel@krisman.be designates 217.70.183.194 as permitted sender) smtp.mailfrom=gabriel@krisman.be; dmarc=none Received: by mail.gandi.net (Postfix) with ESMTPSA id 2688440002; Wed, 2 Oct 2024 21:29:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=krisman.be; s=gm1; t=1727904573; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HncRwIusYKLU1a073mDPta5phkAfT1syOg05rFDwoQs=; b=onbSexGJeEjE3hP6YPlRHUL5A36yM9CyJsX/NdT4QU8UK+9FQ6lT1rNLTNVDbHP1yPIUsA 2ElZyD6CfFiTF5vni2SV87o12V/F2Xve0JH27U7ksguHlPOyUUoBwKaPYd0S+XdnDNA71W amD5yQFqC2Tjwr37RBKrNCiH9N7Q0SNa6E4EWkwFmUDLBcZJt2p2QjMLGFA/jaBXu0lg7f 1lUbulrfVzFAyl4czGiB4Q0PoRRR06QFwX+/6z83eTQtxNQ19l/ZfHgxVhbxVOtBDNrE3e 1pLDmWQlyeERljtbRmb5XiF9m6/EgOuQCndO4ful3QacW6xb1VPC+eBURkvtCw== From: Gabriel Krisman Bertazi To: =?utf-8?Q?Andr=C3=A9?= Almeida Cc: Gabriel Krisman Bertazi , Hugh Dickins , Andrew Morton , Alexander Viro , Christian Brauner , Jan Kara , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, kernel-dev@igalia.com, Daniel Rosenberg , smcv@collabora.com, Christoph Hellwig , Theodore Ts'o Subject: Re: [PATCH v4 07/10] tmpfs: Add casefold lookup support In-Reply-To: (=?utf-8?Q?=22Andr=C3=A9?= Almeida"'s message of "Tue, 1 Oct 2024 22:40:17 -0300") References: <20240911144502.115260-1-andrealmeid@igalia.com> <20240911144502.115260-8-andrealmeid@igalia.com> <87ed5olmmc.fsf@mailhost.krisman.be> Date: Wed, 02 Oct 2024 17:29:29 -0400 Message-ID: <877caqw5vq.fsf@mailhost.krisman.be> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-GND-Sasl: gabriel@krisman.be X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: B2DD540004 X-Stat-Signature: nndbe4jmwbrkewgtwpo4bn1j53ayqcuc X-HE-Tag: 1727904575-905926 X-HE-Meta: U2FsdGVkX1/WMk8O08JueKnHgnxAf32C/QjjOfdi/ecBuIVrkBbG6u9J47kjpSECCMwggu3S6q/dDGbWLW9otpNiADWxu7dr94Ul85SllqKcO6WT54wAmozFgmNdYnkMTbOx4oyESOUvqp+840uYa0GwtRCc6A82d6Ql0LhmdGSorWPpE+pQBwDGucbmAstAY7yCEQlcdCUOpEsik4laSnsxjeqst459WlegqRI9eYEYA/Hd8dqKO6ilKdq0WcTKqz/jOB7ZefCxnp2QnUFP4rQQAkiAAss2RTqX6Ck+STNirJUCoQuUCJiRWgjbPCwZIkcVJCkks8qoAVTa2zxc6Xt8U0a3g2uAD+eaCwaRTxMVxIqhAa2L870SHF3FzluQ42oyUA+gNxNOVw9Mpu3lTwDW7r/3fK69+ZirJ6NwuUxkZkfgZxnvnip8iBuD3tG8QoG2pgPZBK7EM0WwAQSEahmHRFOub5trs4AKaHaO+qsyA/vs9DFf3lQaw1ADHFAZToM8N8p3ASh734C56IzuyDo1qzlPruKUze27De4xNmt3CG09ihJk5BZDh4eX+lG9lrhAT+K71k3Jh9PlNAAb0YrPeJHfbWPG8+g9WmFZ1WnoYMtfm0WcHjjeLBHiAkmjSz0rRF8zkyHKu0oaBpAdiU6A8Yc2JSB+btQUd6PWmnU9AWS+f3z0BkffogBAc4bSJM5Bkykn2AQNUawEdNvpoKggwPX+MlB0QJXA3R0vEi5zmTHqzypaW9l9fzzzFzZ3aKWNKmVdfSsXJ4OW8TY7OFTOJqQkPApH03CfiPwwjgNbWsZoZlDZOXN7xR7o5UIJbEpDOJxnks+xcueV62hNH0P9UFkJNdwtKhU07k8G3tQWxfZgN5ulZLcoZnhdMFf3XH/eYoZePnqRyXtCe2neNxZ5MvP5vXngU72nABvUdBpYHrspR6Fkum459idTdFqx58llwQHqyOmR8hSoUmZ K5Kfg7uL d/CNbXQLx3FrZNktlbN1PvEwbDF+rwc8noSGsivnzhQKOGw5x2rbycD23FQJE/4nLK449Qt9dFP3ZJCiduMf9/9qXQ5VozWWinycAT57pOWhGUsg6B4c0PnluMqTGcnGgBJEe/FRXldI/HjbBASDkY8/PjnsZXHAjoPEPF9YkzaNeKAttQEEqd3TwSjo5oAUyo0FPNmzof+damfoBurjh/zhBIRQ6XuCr57xOgn5gE02Dn7jcEAzNh+48ib027Wsu62St40Gbbyz95s2YJuM7+Rxyv+BdqFug/r9/eyHi/9zMKk0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Andr=C3=A9 Almeida writes: > Hey Krisman, > > Em 12/09/2024 16:04, Gabriel Krisman Bertazi escreveu: >> Andr=C3=A9 Almeida writes: >>=20 > > [...] > >>> +#if IS_ENABLED(CONFIG_UNICODE) >>> + if (ctx->encoding) { >>> + sb->s_encoding =3D ctx->encoding; >>> + sb->s_d_op =3D &shmem_ci_dentry_ops; >>> + if (ctx->strict_encoding) >>> + sb->s_encoding_flags =3D SB_ENC_STRICT_MODE_FL; >>> + } >>> #else >>> - sb->s_flags |=3D SB_NOUSER; >>> + sb->s_d_op =3D &simple_dentry_operations; >> Moving simple_dentry_operations to be set at s_d_op should be a >> separate >> patch. >> It is a change that has non-obvious side effects (i.e. the way we >> treat the root dentry) so it needs proper review by itself. It is >> also not related to the rest of the case-insensitive patch. >>=20 > > The idea of setting simple_dentry_operations come from my previous > approach of having our own shmem_lookup(), replacing > simple_lookup(). Now that we are settled to keep with simple_lookup() > anyway (that already sets simple_dentry_operations), I think we don't > need this change anymore, right? Up to you, really. If you don't need it to support casefold lookup in tmpfs, it doesn't need to be part of the same patchset. > This will be set for every dentry that doesn't have a > dentry->d_sb->s_d_op. Case-insensitive mount points will have this set, > so we don't risk overwriting it. I encourage you to send a new version with this. makes sense to me. --=20 Gabriel Krisman Bertazi