From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E185FC3601E for ; Thu, 10 Apr 2025 10:21:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 55F9428009B; Thu, 10 Apr 2025 06:21:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 50D3E280091; Thu, 10 Apr 2025 06:21:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 385D828009B; Thu, 10 Apr 2025 06:21:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 1A97C280091 for ; Thu, 10 Apr 2025 06:21:07 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 6A4C61603D4 for ; Thu, 10 Apr 2025 10:21:08 +0000 (UTC) X-FDA: 83317741416.03.198B14B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf07.hostedemail.com (Postfix) with ESMTP id 163464000E for ; Thu, 10 Apr 2025 10:21:05 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=X1qMkJe5; spf=pass (imf07.hostedemail.com: domain of toke@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=toke@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744280466; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0HdHV8YkTnBaBXnMWEUaMc/G+fwkVPu3nROxm55vQkA=; b=AJjOGGzAw74TwL9LDY/rR78X0uxilQ7fu6bEX6HOEcrQ85/ZpR0EOxfeC37IWPEym/+MOG y/mO9J/+c0qtwxPgQ9ucxsXghL4AKjmvDUnmXqpdeHbVzvaqG8nfI4itp4JqRTyPpE0tm1 KxWgyDAxzKLFTjX0ZkCTnEbvlbM1umM= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=X1qMkJe5; spf=pass (imf07.hostedemail.com: domain of toke@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=toke@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744280466; a=rsa-sha256; cv=none; b=RiCG1XN9MpUCKkwbEoV91mqJ9GosvUzW40xkGjBvig9zUn2uJHMqaJEOu84LijuQGGtLjM pj9skyWoiMf04a+fXv6r65Bx3AB6328Xhovv333syf0msSXdZYRSBd7hKcxoEM0Z+HvJTc JoMZ5fhZcHFDUbhuecgW0lhfVBzUg54= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744280465; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0HdHV8YkTnBaBXnMWEUaMc/G+fwkVPu3nROxm55vQkA=; b=X1qMkJe5BEXK9EuPJmeN9OYUAWzJo3Qk1YUOnVy18WX1tqULG5dMtp3zDSmYzxzycC076K zY4Dg7Rf0EHoNOvvEq2pxrx+VN8/F4cTQaEuj12X1W2VQzotmcmXyq1XCWx83PuxKmjeC/ sfNUlgB9rgseCiH+JZp7PRPAmFPT/vw= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-595-Ztrvj-pAM4aVRBUJ81cICQ-1; Thu, 10 Apr 2025 06:21:04 -0400 X-MC-Unique: Ztrvj-pAM4aVRBUJ81cICQ-1 X-Mimecast-MFC-AGG-ID: Ztrvj-pAM4aVRBUJ81cICQ_1744280463 Received: by mail-lj1-f197.google.com with SMTP id 38308e7fff4ca-30c07698ebfso2648301fa.0 for ; Thu, 10 Apr 2025 03:21:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744280463; x=1744885263; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gj0ddO5JcHA3x6pElFgDxfTHr6tMQmqLYvn6SHOTRag=; b=Apdeblc2f6SsNSkmuKs/KMgjyZZ/iN2VceB5OSTmGIqUcN+G9wwui+j6wkKxxscW8H XPjhbWSBw2l7z+elGA6SuVk00f3uhPeQj8fnZ/yPfVtOHBJyHQ0GHnV/ieXmibCFQKge fEW2Y643cwsJPqi1VqaCqtl+PVrzP2kxa7qLxeIPvrw9T0yxqjdUzI40APETTRtRprx8 5QZZdduPT4jydAAHs0jpUinz+u5gXPvRG1p6uQd9PjvaPdgTyIXjWqTwDXzmfIW2YZNz CWaf9dCQwoWJWPUG5qj639qe0Xb0wboYwNhecxw4gtqJ/URCevZWwtDAW/ls0Gw25YWf DsuQ== X-Forwarded-Encrypted: i=1; AJvYcCUD2m42mXWWD3JMjiibnnleJHZcNhdLXay6NuSTr4815iIskl3br3F3r49uAA5Q5vhvFEiXkzOIxQ==@kvack.org X-Gm-Message-State: AOJu0YwEdZreQWe4I8tKBrAwtA0qnCSnId22kRmGx7XJARR+jd1Y1D8U Pue6Cmgi435d4P+C19pwbKc9ArvyevADmYHiNdd7Rf9VOAAXj6GPbqh4bJdYEKvLujEJOmZcnZR pNWMjiDY5rldjEFopNI3xM/ZGw+V2+AR48PlDI8V+M9F13m7I X-Gm-Gg: ASbGnctId0CgN6Ze7pHKIj7ne6Bp9BPHffwzF21HYpXc4Qdcr4Ac8UrL4D63EVnvOb6 fw0CFd8zPpZKNOrvOPtBlgUDZwl9b5wr5IhW4Bqv+uDMwGWD6ZaAnEc15w24zq+YmGryFqH3NtT MOn0ppmUyj4jOcU6BQIvPkYy0EE6KoCMsQSmekCve3qAfr2DgofyHICrAlqET4MEKSvesL5wVpQ 4bFcBNgLk0ChBFxUQuEoG9v+/z/pS/S03fE4MCRWx5s722mU2pg+vYr5dRz3SxM0NsPxHnjgQym 0cgYzrlGcFP6XDK+YH2GOM8Mmy4xIn6Qb1zq X-Received: by 2002:a05:651c:1515:b0:30b:9813:b004 with SMTP id 38308e7fff4ca-3103ed4f35dmr5955671fa.34.1744280462772; Thu, 10 Apr 2025 03:21:02 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE17WxZoyH3rbLK0N6NfIbsSGtSK/hr9dYY0iDg1GJ6hNCoga/XB9dPSda2f4ZShTnw6cWIwg== X-Received: by 2002:a05:651c:1515:b0:30b:9813:b004 with SMTP id 38308e7fff4ca-3103ed4f35dmr5955491fa.34.1744280462404; Thu, 10 Apr 2025 03:21:02 -0700 (PDT) Received: from alrua-x1.borgediget.toke.dk ([45.145.92.2]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-30f46623c2bsm4318581fa.111.2025.04.10.03.21.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Apr 2025 03:21:01 -0700 (PDT) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 7F5E21992272; Thu, 10 Apr 2025 12:21:00 +0200 (CEST) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Zi Yan , "David S. Miller" , Jakub Kicinski , Jesper Dangaard Brouer , Saeed Mahameed , Leon Romanovsky , Tariq Toukan , Andrew Lunn , Eric Dumazet , Paolo Abeni , Ilias Apalodimas , Simon Horman , Andrew Morton , Mina Almasry , Yonglong Liu , Yunsheng Lin , Pavel Begunkov , Matthew Wilcox Cc: netdev@vger.kernel.org, bpf@vger.kernel.org, linux-rdma@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH net-next v9 1/2] page_pool: Move pp_magic check into helper functions In-Reply-To: References: <20250409-page-pool-track-dma-v9-0-6a9ef2e0cba8@redhat.com> <20250409-page-pool-track-dma-v9-1-6a9ef2e0cba8@redhat.com> X-Clacks-Overhead: GNU Terry Pratchett Date: Thu, 10 Apr 2025 12:21:00 +0200 Message-ID: <877c3suxkj.fsf@toke.dk> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: W0m8KQkEdiuKJ79vV351pG0QUc2jtIHHAtcap3Jeg08_1744280463 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 163464000E X-Stat-Signature: syqyehoiz43mbw68ioafkopnswk7f66t X-HE-Tag: 1744280465-601164 X-HE-Meta: U2FsdGVkX18pkqTdi7M9kix4xECMVvQzW5xgU2G/IfaaUqNKyfIZNe/gd9gETPl3dCzYqI0wkAsF1AJTePO15vMKHcgCbyU3iBMxA9AgvBoqborUPRzHNe65gIAlQq7LV8fReY1UJphRAk+54ZRlsG0CiAJQxF0iIpWgZvYo5QpcnQRrT+Hbt8FV6q3T0SpiE6ZnpIljsCgq7vkO9Fs5GsFB2WRGyAkWtdcrxuXg0tleHgrdTqQELQpK+wbO3LY8jIf8GwyOE150f0YOSnDbilTXkBNQ9ssLvAvFMh94+qGt0Ftrz6xUbmL4vTt2eej5qlosiVvZOTxDwOg5OpjzQZ3fqbdUheWkVq/UrLuvsZLqyA5iLLdn1WMGfj/FEK4MippyWD4cwIXelUcfeC95rWJ9UdDH8oXGiforw4G8NfUtveFlMXmRMn5l+JmF5RaIvLZR1+heXPP7pQIuztG9ebdvmA75k312fKjXmg2rklcjb9+q3m601YYooqdgMZX8VHQa5ic+EXj5VCCqDH5nj3HL4Rc2sO/cuONmijf9HiYK/G/rKoHK/pe3c1gS2OqYUkyejVFZstAJNinhAfQQ9pe6uJZrcvss6wjTznpOByzrnMtbNrqYt7naUaUYb3/7eUBRAjoapWd2/vAWKG8l4BmTlhULbY28aWkh6rVM9VMVihDtsicK8GrDn5s6uedUpyVjILJkP2JlUEQiQf0qvXI/lR14jTU29ELZ7tRxru9UggTOC0GF4ZKA4LWSp20K1UadczkyDoEt8V5X9lCbcx2uX5+c0l+c8X1X2FMHMiBc6n4MiLZaoZUaQf/zi8deWnHhBKiL6e6P3QHTRHMskJoL4KXDKEnN7bCChVitSKQpK5d+gJAvrYr08tbwMsBm0NswP5/PWmKIFlnpYu6WTOhb04Md8ahF+uC1ZLItNjvtMU0VodRvmRlg0TuK0+6hp0QCf69b8UeYGkvBU6L +bhfh26r +QhxLZlWQSlN0xYLvO9W0Y6cX+QKP0bQ+3hiuPs/vrOEBP2VWErxGUvmo6WsEZV1HJCaFfd+o5aC6HxaXrYGXZpC8tqiUMVXxC8TVOqyAZMRov2aPZgDzAImKRkS8AEpDSjB0eqWcXbD113NkM2oY4LVtWHlteFjCvIYoXqp3xF7sX3RR8ITYkDXO+NXAzPeXlg3AVCjuu+frpkfKVpeTRNJbvsMU2XB90a5MP2NAOXKWnOb5Eje8tSzr6mexoUAzSPV250qW6WL/yiSYefKqE1W8WVWW+djjE+yTL6717EzRqf8NuVsj2owc3+iA3wkrXPXER+oRIxQtTdGVjxX/HDOlqviSvBri1wJOpf+Tg5VmmE80/grdFJTmRGfo8kL9jkBx8L2VvUMCUDFdJTzRXVmF0zknqBFc+hY3HhkAsvFiCkmPAoOxnUBNSn+S9sB4Lrk6fozoJ0oP8EYJa2/3/8n7Ab3Xgx9HyqYNzOl16e62Ba9S9Z8jteEXAjrPlcM1QLZyz+NEaJ0wRBZuR057XFMYXb2OUgUDLj3iMyxRsIkikIcttw15NjpSLcDbpTBtBWGPTyQLbOd5b8iCk+mJpQS2e5KkbDimXs3jhjpoLkFzJLFdPLUxrpiLbid9cF7vgMGJUF0yCBSKHEBe+uM6URYdrKYDIpZo5qluM2AgjLf8PcjQ8x4FF6FdR5lzus/jdHP01jw1MTY/fqE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: "Zi Yan" writes: > On Wed Apr 9, 2025 at 6:41 AM EDT, Toke H=C3=B8iland-J=C3=B8rgensen wrote= : >> Since we are about to stash some more information into the pp_magic >> field, let's move the magic signature checks into a pair of helper >> functions so it can be changed in one place. >> >> Reviewed-by: Mina Almasry >> Tested-by: Yonglong Liu >> Acked-by: Jesper Dangaard Brouer >> Reviewed-by: Ilias Apalodimas >> Signed-off-by: Toke H=C3=B8iland-J=C3=B8rgensen >> --- >> drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c | 4 ++-- >> include/linux/mm.h | 20 +++++++++++++++++= +++ >> mm/page_alloc.c | 8 ++------ >> net/core/netmem_priv.h | 5 +++++ >> net/core/skbuff.c | 16 ++-------------- >> net/core/xdp.c | 4 ++-- >> 6 files changed, 33 insertions(+), 24 deletions(-) >> > > LGTM. Reviewed-by: Zi Yan Great, thanks! -Toke