From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Zi Yan <ziy@nvidia.com>, "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Jesper Dangaard Brouer <hawk@kernel.org>,
Saeed Mahameed <saeedm@nvidia.com>,
Leon Romanovsky <leon@kernel.org>,
Tariq Toukan <tariqt@nvidia.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
Simon Horman <horms@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Mina Almasry <almasrymina@google.com>,
Yonglong Liu <liuyonglong@huawei.com>,
Yunsheng Lin <linyunsheng@huawei.com>,
Pavel Begunkov <asml.silence@gmail.com>,
Matthew Wilcox <willy@infradead.org>
Cc: netdev@vger.kernel.org, bpf@vger.kernel.org,
linux-rdma@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH net-next v9 1/2] page_pool: Move pp_magic check into helper functions
Date: Thu, 10 Apr 2025 12:21:00 +0200 [thread overview]
Message-ID: <877c3suxkj.fsf@toke.dk> (raw)
In-Reply-To: <D92K7SAU1A06.1APBVXB2AK2HW@nvidia.com>
"Zi Yan" <ziy@nvidia.com> writes:
> On Wed Apr 9, 2025 at 6:41 AM EDT, Toke Høiland-Jørgensen wrote:
>> Since we are about to stash some more information into the pp_magic
>> field, let's move the magic signature checks into a pair of helper
>> functions so it can be changed in one place.
>>
>> Reviewed-by: Mina Almasry <almasrymina@google.com>
>> Tested-by: Yonglong Liu <liuyonglong@huawei.com>
>> Acked-by: Jesper Dangaard Brouer <hawk@kernel.org>
>> Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
>> Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>
>> ---
>> drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c | 4 ++--
>> include/linux/mm.h | 20 ++++++++++++++++++++
>> mm/page_alloc.c | 8 ++------
>> net/core/netmem_priv.h | 5 +++++
>> net/core/skbuff.c | 16 ++--------------
>> net/core/xdp.c | 4 ++--
>> 6 files changed, 33 insertions(+), 24 deletions(-)
>>
>
> LGTM. Reviewed-by: Zi Yan <ziy@nvidia.com>
Great, thanks!
-Toke
next prev parent reply other threads:[~2025-04-10 10:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-09 10:41 [PATCH net-next v9 0/2] Fix late DMA unmap crash for page pool Toke Høiland-Jørgensen
2025-04-09 10:41 ` [PATCH net-next v9 1/2] page_pool: Move pp_magic check into helper functions Toke Høiland-Jørgensen
2025-04-10 1:15 ` Zi Yan
2025-04-10 10:21 ` Toke Høiland-Jørgensen [this message]
2025-04-09 10:41 ` [PATCH net-next v9 2/2] page_pool: Track DMA-mapped pages and unmap them when destroying the pool Toke Høiland-Jørgensen
2025-06-11 16:35 ` Breno Leitao
2025-06-11 20:12 ` Jakub Kicinski
2025-06-12 7:25 ` Toke Høiland-Jørgensen
2025-06-12 14:05 ` Jakub Kicinski
2025-06-13 8:41 ` Toke Høiland-Jørgensen
2025-06-13 15:02 ` Jakub Kicinski
2025-06-20 11:01 ` Pedro Falcato
2025-04-15 0:30 ` [PATCH net-next v9 0/2] Fix late DMA unmap crash for page pool patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877c3suxkj.fsf@toke.dk \
--to=toke@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=almasrymina@google.com \
--cc=andrew+netdev@lunn.ch \
--cc=asml.silence@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=horms@kernel.org \
--cc=ilias.apalodimas@linaro.org \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linyunsheng@huawei.com \
--cc=liuyonglong@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
--cc=willy@infradead.org \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox