From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 297B6C4320A for ; Tue, 31 Aug 2021 14:23:14 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D35F960FF2 for ; Tue, 31 Aug 2021 14:23:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D35F960FF2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 604A78D0007; Tue, 31 Aug 2021 10:23:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5B4E68D0001; Tue, 31 Aug 2021 10:23:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 47C4D8D0007; Tue, 31 Aug 2021 10:23:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0034.hostedemail.com [216.40.44.34]) by kanga.kvack.org (Postfix) with ESMTP id 390BA8D0001 for ; Tue, 31 Aug 2021 10:23:13 -0400 (EDT) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id E1AAE1801BD99 for ; Tue, 31 Aug 2021 14:23:12 +0000 (UTC) X-FDA: 78535593024.17.049B5F0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf20.hostedemail.com (Postfix) with ESMTP id 717EDD0000A9 for ; Tue, 31 Aug 2021 14:23:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1630419791; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=urLJX4mD4+0+z3Cmi5p6BeY5jBhCGBwwOY1UjB3PyvE=; b=K/7ZzMkTwmaXgcEp/T0Ftk6oZEvqpSkwV5iLJlXsTv3VqYUNcfeZUxKcIs7Icl8EDn1KXz 9EkRArD8kSESS4X1lasmO7mTHWWIlHMGozQa4rlCcdIy/IVFd/ZjYVCZug2hkXuxB++qH0 8dZ56oy+QDaWW9q8E1QxcwISEeOqRB0= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-60-gBTPH1SXMXqzkNWr9ml9Gw-1; Tue, 31 Aug 2021 10:23:10 -0400 X-MC-Unique: gBTPH1SXMXqzkNWr9ml9Gw-1 Received: by mail-wm1-f72.google.com with SMTP id j33-20020a05600c48a100b002e879427915so6040725wmp.5 for ; Tue, 31 Aug 2021 07:23:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:references:from:organization:subject :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=urLJX4mD4+0+z3Cmi5p6BeY5jBhCGBwwOY1UjB3PyvE=; b=OWlNSa/UyupBTdBDZPp7PaJ0iWiDRMQSYSkDyKulILZuWZ8IzO0MFytkRdCpkWvv0o drtzV/8Kb3zA7hX0R2wKJCbLrsrhU++gOjXVgSjIIXzO/sGFLAhR0ARkmNYIrQFL/920 ZbzqKUTH/vLL4nWnyBhnCEn82uQHmCnf1Zk2NRIrkjM8JrTR9UmFRk3XHZlM2bCoVsXu 4SK1d2nLhTo47ZB7j9cL7sDkZ2Su1iIyTw662n8nHSRqpKaW2CsyRkYhpLiJ1+8exRMV 2YEdiVksORn1y05QTXjLQ7NNs89yxHPHZ7xPVhY0RxCaQIpT0N1GvrU/bhkYIwfhlfE0 iAtw== X-Gm-Message-State: AOAM5302LLTo65CkAn1JsmkEbT0Bu2eBW13cxMlsSo0m7pMnVnxInOpD jnyJZclgnZuVenVSwKRWFPLlKDEc8dGgjfhF3K4wJCEAvUM8vuN7mDpyhpOs25y6yLJ4PjeEect d8HNRlnAH4PM= X-Received: by 2002:a1c:f712:: with SMTP id v18mr4475216wmh.25.1630419789225; Tue, 31 Aug 2021 07:23:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw2oxz4h5PTJEcybV9HdfEeThpSVgOxrmM77fxTd1EzWzzl5aFc4X49pdQOHATL0hmWjMfzZA== X-Received: by 2002:a1c:f712:: with SMTP id v18mr4475189wmh.25.1630419789029; Tue, 31 Aug 2021 07:23:09 -0700 (PDT) Received: from [192.168.3.132] (p4ff23bf5.dip0.t-ipconnect.de. [79.242.59.245]) by smtp.gmail.com with ESMTPSA id d145sm2560524wmd.3.2021.08.31.07.23.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 Aug 2021 07:23:08 -0700 (PDT) To: Mel Gorman , Miaohe Lin Cc: akpm@linux-foundation.org, vbabka@suse.cz, sfr@canb.auug.org.au, peterz@infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20210830141051.64090-1-linmiaohe@huawei.com> <20210830141051.64090-6-linmiaohe@huawei.com> <20210831134311.GG4128@techsingularity.net> From: David Hildenbrand Organization: Red Hat Subject: Re: [PATCH 5/6] mm/page_alloc.c: avoid accessing uninitialized pcp page migratetype Message-ID: <877b7043-65c3-5e08-ac89-ad6f10e354b3@redhat.com> Date: Tue, 31 Aug 2021 16:23:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210831134311.GG4128@techsingularity.net> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Language: en-US Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="K/7ZzMkT"; spf=none (imf20.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 717EDD0000A9 X-Stat-Signature: i86x1xp35pr4h53cnu6c58zssfkzds6k X-HE-Tag: 1630419792-54900 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 31.08.21 15:43, Mel Gorman wrote: > On Mon, Aug 30, 2021 at 10:10:50PM +0800, Miaohe Lin wrote: >> If it's not prepared to free unref page, the pcp page migratetype is >> unset. Thus We will get rubbish from get_pcppage_migratetype() and >> might list_del &page->lru again after it's already deleted from the >> list leading to grumble about data corruption. >> >> Fixes: 3dcbe270d8ec ("mm/page_alloc: avoid conflating IRQs disabled wi= th zone->lock") >> Signed-off-by: Miaohe Lin >=20 > Acked-by: Mel Gorman >=20 > This fix is fairly important. Take this patch out and send it on its ow= n > so it gets picked up relatively quickly. It does not belong in a series > that is mostly cosmetic cleanups. I think the commit id is wrong. Shouldn't that be df1acc856923 ("mm/page_alloc: avoid conflating IRQs disabled with=20 zone->lock") ? --=20 Thanks, David / dhildenb