From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97E7CC83F3E for ; Tue, 5 Sep 2023 09:23:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 18A3A94000A; Tue, 5 Sep 2023 05:23:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 13A708E001A; Tue, 5 Sep 2023 05:23:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 02A8A94000A; Tue, 5 Sep 2023 05:23:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id E54098E001A for ; Tue, 5 Sep 2023 05:23:55 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id B0C69B3E34 for ; Tue, 5 Sep 2023 09:23:55 +0000 (UTC) X-FDA: 81202006830.15.2441C0B Received: from out-230.mta0.migadu.com (out-230.mta0.migadu.com [91.218.175.230]) by imf25.hostedemail.com (Postfix) with ESMTP id A53B0A001B for ; Tue, 5 Sep 2023 09:23:53 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=ECKeFPTD; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf25.hostedemail.com: domain of muchun.song@linux.dev designates 91.218.175.230 as permitted sender) smtp.mailfrom=muchun.song@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693905833; a=rsa-sha256; cv=none; b=z8j4vqPT0Qyd2D4IkvnTTeTDeK3e3z3osi3+9A/l7egMr4zHNKyBXMBZSTymguUrPmJ0se kOi362B8FgwVduhYO/6xoZgmjfR0Bn3smPj0afuNeVXjOuE9jrIFpftgcCPSzl6+7rHcFY wUsei9DJ0lZdLbyHVq11ksdB1tkr+DE= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=ECKeFPTD; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf25.hostedemail.com: domain of muchun.song@linux.dev designates 91.218.175.230 as permitted sender) smtp.mailfrom=muchun.song@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693905833; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FJe2kPA9Sxmw7z/XIyWlwHDMZhBSU0bPfBtmxDNTf2k=; b=Qj8c7FJfQfeoOHaKE1OSHaHM2GwgpziE6dUklr0GazNrCDb1B0NsH0hDCDcUO0sobiFZGm 4/U24uj1NLuvVD6I95U4JEv6tzXapDhHhaPL7JF55KOxn02TLkWr/UN6m/IIwP0CivSgwQ HCNRs9tON8cUZLgeJLqOENNVgkN0g+k= Content-Type: text/plain; charset=utf-8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1693905831; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FJe2kPA9Sxmw7z/XIyWlwHDMZhBSU0bPfBtmxDNTf2k=; b=ECKeFPTDFkic13yD/XlbpDH18ak7wMUojJO+NqHdMLim4YyohnpjmVIi/DLN8cSRDjGw8R Y5eSmW5+VlvnOI+4rVh31LNqG0JJ2L9AOCcUI91PwuS3j7EMzLyX2ZtRSf7YTsO7GN/jES BLZbJhwWtPc6K/MecCaNS4jYEyy2iUc= Mime-Version: 1.0 Subject: Re: [PATCH] mm: hugetlb_vmemmap: use bulk allocator in alloc_vmemmap_page_list() X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: Date: Tue, 5 Sep 2023 17:23:07 +0800 Cc: Andrew Morton , Mike Kravetz , Linux-MM , Yuan Can Content-Transfer-Encoding: quoted-printable Message-Id: <877C4C7F-C946-4B55-A4C5-A493EA21B6AC@linux.dev> References: <20230905071016.2818810-1-wangkefeng.wang@huawei.com> To: Kefeng Wang X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: A53B0A001B X-Stat-Signature: zdm36uzof8yo68kc4q3nfcnmyeaitw3f X-HE-Tag: 1693905833-685466 X-HE-Meta: U2FsdGVkX1+hVrC9kbngQX+i9qhNcwrNj69chKvPViCaUDEP5TKPDLWdufLd2wSRW9UFxQu9RXhrnALMJrfGhaj+2rhzSbgpkzmNTJeDVdbLj3ukfF43JvUCLAzyZfW9t06JsW2IceGMEREIZ4zPEdK/qxzCkbwxdA3dquQ/85KEO5nZsCBkQx4SP52KX8cagS/1jOqz06ZvHMCWScATaJe09pO82a5wclt/6s68WBcqYgeQmhKAq2ICvaceo3K8PfyX7iaKeYkvkLywr1pLU9W19bBRBILnF+MqrmxSaWNe4ozEcPuhhtib/t4wdgcdVd9t0lzEXeyCdAVHP5HkOpRZzQnRCUzhVSGjpyTTuWxmeXm51yHWQuNdt53oPU4Z3rB/5DQD6jobJnodBSGbpsEZGD5xdh2/VR7riDY+6gy/3XSP2OvowMjuQgEfukGf9APFjd7ds+pe+bz3gJrvuB4LeiaE6a/ectG12QKxuxhzcu7vcwOYIaVfDvb7FrQur8AH5/4yiEUAWBpgEE5MGdQSDAV4nAv20QOhJ9nCNM1gdG4NIOnx3GfIAAqN4sMcxA/Wc0awUJ5vMhPYDxApcNCRHY31qXJ9IW5ZNZhfYkydI2vbI3V4OWjjS9AjNv2iw679O3nk3sLVdw7K1V+zWTi+vDEx9prosHkT0dv4BKHF+If6sIWLnNcTQfKGgVmrN9IF83oKU2Ca+X3TfTzpmGdhMOqhlIptoxg8XgiBF1HuuNKcq2mLAgmQltta8Lt/vxZz/5kjLj6fFc8x2AJr1khnS6vL7+WgLHOdIyQ0hvIIHnezekrZtCksJcczcNMJAQTBn/ovlKvRnlyEXl4G/yx0vpO7R98rXK5V3xRP2wV+5d80lTq0UJYwAbs1BlsHrw5UUYN6OpbVjsSx/4K+Vx6t3FQ65GOO0A7V8vLYDNmGBkhDIp+h4dCODNudU337Z6cfByp+9m23wOyw7hG fN4L7seV MikMTSRwcpBaKbdYIv1a4hmOvAGSSV9EBzDydNYlWbf/+A27v61DANsjckV6QWIUMO8NyHGZwAgDStMiBwYren/m30cZ9fZa901kirF4PyrY60K8SEM1unRloZg+NVwrHDhL0EomPwh/AyAGIbVCXPV4T2YQvkwstq7L/sPAR0D/D6J/V8sNauPw3iA2gE8iR8+fh4+Fk/AgOh9LUZ7hKLLkDQnTiyeC18l90 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > On Sep 5, 2023, at 15:32, Kefeng Wang = wrote: > On 2023/9/5 15:10, Kefeng Wang wrote: >> It is needed 4095 pages(1G) or 7 pages(2M) to be allocated once in >> alloc_vmemmap_page_list(), so let's add a bulk allocator varietas >> alloc_pages_bulk_list_node() and switch alloc_vmemmap_page_list() >> to use it to accelerate page allocation. >> Simple test on arm64's qemu with 1G Hugetlb, 870,842ns vs 3,845,252ns >> despite the fluctuations, it is still a nice improvement. >> Tested-by: Yuan Can >> Signed-off-by: Kefeng Wang >> --- >> include/linux/gfp.h | 9 +++++++++ >> mm/hugetlb_vmemmap.c | 7 ++++++- >> 2 files changed, 15 insertions(+), 1 deletion(-) >> diff --git a/include/linux/gfp.h b/include/linux/gfp.h >> index 665f06675c83..d6e82f15b61f 100644 >> --- a/include/linux/gfp.h >> +++ b/include/linux/gfp.h >> @@ -195,6 +195,15 @@ alloc_pages_bulk_list(gfp_t gfp, unsigned long = nr_pages, struct list_head *list) >> return __alloc_pages_bulk(gfp, numa_mem_id(), NULL, nr_pages, list, = NULL); >> } >> +static inline unsigned long >> +alloc_pages_bulk_list_node(gfp_t gfp, int nid, unsigned long = nr_pages, struct list_head *list) >> +{ >> + if (nid =3D=3D NUMA_NO_NODE) >> + nid =3D numa_mem_id(); >> + >> + return __alloc_pages_bulk(gfp, nid, NULL, nr_pages, list, NULL); >> +} >> + >> static inline unsigned long >> alloc_pages_bulk_array(gfp_t gfp, unsigned long nr_pages, struct = page **page_array) >> { >> diff --git a/mm/hugetlb_vmemmap.c b/mm/hugetlb_vmemmap.c >> index 4b9734777f69..699c4fea6b9f 100644 >> --- a/mm/hugetlb_vmemmap.c >> +++ b/mm/hugetlb_vmemmap.c >> @@ -384,8 +384,13 @@ static int alloc_vmemmap_page_list(unsigned long = start, unsigned long end, >> unsigned long nr_pages =3D (end - start) >> PAGE_SHIFT; >> int nid =3D page_to_nid((struct page *)start); >> struct page *page, *next; >> + unsigned long nr_alloced; >> - while (nr_pages--) { >> + nr_alloced =3D alloc_pages_bulk_list_node(gfp_mask, nid, nr_pages, = list); >> + if (!nr_alloced) >> + return -ENOMEM; >> + >=20 > eh=EF=BC=8C forget to inc nr_allocated in the fallback patch=EF=BC=8C = will resend Do not change the judgement, "nr_pages -=3D nr_alloced;" is enough and simple. >> + while (nr_alloced < nr_pages) { >> page =3D alloc_pages_node(nid, gfp_mask, 0); >> if (!page) >> goto out;