From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail6.bemta8.messagelabs.com (mail6.bemta8.messagelabs.com [216.82.243.55]) by kanga.kvack.org (Postfix) with ESMTP id 33AF36B016D for ; Mon, 8 Aug 2011 11:06:22 -0400 (EDT) Received: by fxg9 with SMTP id 9so5480109fxg.14 for ; Mon, 08 Aug 2011 08:06:20 -0700 (PDT) From: Miklos Szeredi Subject: Re: [patch 2/2] fuse: mark pages accessed when written to References: <1311626135-14279-1-git-send-email-jweiner@redhat.com> <1311626135-14279-2-git-send-email-jweiner@redhat.com> Date: Mon, 08 Aug 2011 17:06:17 +0200 In-Reply-To: <1311626135-14279-2-git-send-email-jweiner@redhat.com> (Johannes Weiner's message of "Mon, 25 Jul 2011 22:35:35 +0200") Message-ID: <8762m8eydy.fsf@tucsk.pomaz.szeredi.hu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: owner-linux-mm@kvack.org List-ID: To: Johannes Weiner Cc: fuse-devel@lists.sourceforge.net, linux-mm@kvack.org, linux-kernel@vger.kernel.org Johannes Weiner writes: > As fuse does not use the page cache library functions when userspace > writes to a file, it did not benefit from 'c8236db mm: mark page > accessed before we write_end()' that made sure pages are properly > marked accessed when written to. > > Signed-off-by: Johannes Weiner Thanks, applied. Miklos > --- > fs/fuse/file.c | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/fs/fuse/file.c b/fs/fuse/file.c > index 5c48126..471067e 100644 > --- a/fs/fuse/file.c > +++ b/fs/fuse/file.c > @@ -14,6 +14,7 @@ > #include > #include > #include > +#include > > static const struct file_operations fuse_direct_io_file_operations; > > @@ -828,6 +829,8 @@ static ssize_t fuse_fill_write_pages(struct fuse_req *req, > pagefault_enable(); > flush_dcache_page(page); > > + mark_page_accessed(page); > + > if (!tmp) { > unlock_page(page); > page_cache_release(page); -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org