From: Miklos Szeredi <miklos@szeredi.hu>
To: Johannes Weiner <jweiner@redhat.com>
Cc: fuse-devel@lists.sourceforge.net, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [patch 2/2] fuse: mark pages accessed when written to
Date: Mon, 08 Aug 2011 17:06:17 +0200 [thread overview]
Message-ID: <8762m8eydy.fsf@tucsk.pomaz.szeredi.hu> (raw)
In-Reply-To: <1311626135-14279-2-git-send-email-jweiner@redhat.com> (Johannes Weiner's message of "Mon, 25 Jul 2011 22:35:35 +0200")
Johannes Weiner <jweiner@redhat.com> writes:
> As fuse does not use the page cache library functions when userspace
> writes to a file, it did not benefit from 'c8236db mm: mark page
> accessed before we write_end()' that made sure pages are properly
> marked accessed when written to.
>
> Signed-off-by: Johannes Weiner <jweiner@redhat.com>
Thanks, applied.
Miklos
> ---
> fs/fuse/file.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/fs/fuse/file.c b/fs/fuse/file.c
> index 5c48126..471067e 100644
> --- a/fs/fuse/file.c
> +++ b/fs/fuse/file.c
> @@ -14,6 +14,7 @@
> #include <linux/sched.h>
> #include <linux/module.h>
> #include <linux/compat.h>
> +#include <linux/swap.h>
>
> static const struct file_operations fuse_direct_io_file_operations;
>
> @@ -828,6 +829,8 @@ static ssize_t fuse_fill_write_pages(struct fuse_req *req,
> pagefault_enable();
> flush_dcache_page(page);
>
> + mark_page_accessed(page);
> +
> if (!tmp) {
> unlock_page(page);
> page_cache_release(page);
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-08-08 15:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-25 20:35 [patch 1/2] fuse: delete dead .write_begin and .write_end aops Johannes Weiner
2011-07-25 20:35 ` [patch 2/2] fuse: mark pages accessed when written to Johannes Weiner
2011-08-08 15:06 ` Miklos Szeredi [this message]
2011-07-25 20:49 ` [patch 1/2] fuse: delete dead .write_begin and .write_end aops Christoph Hellwig
2011-08-08 15:05 ` Miklos Szeredi
2011-08-10 10:26 ` Christoph Hellwig
2011-08-10 11:24 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8762m8eydy.fsf@tucsk.pomaz.szeredi.hu \
--to=miklos@szeredi.hu \
--cc=fuse-devel@lists.sourceforge.net \
--cc=jweiner@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox