From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BFD6C25B4E for ; Tue, 24 Jan 2023 15:12:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 638A86B0073; Tue, 24 Jan 2023 10:12:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5E8766B0074; Tue, 24 Jan 2023 10:12:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4B0766B0075; Tue, 24 Jan 2023 10:12:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 3BA546B0073 for ; Tue, 24 Jan 2023 10:12:24 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id DA85D1A0995 for ; Tue, 24 Jan 2023 15:12:23 +0000 (UTC) X-FDA: 80390033766.15.D44F562 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf01.hostedemail.com (Postfix) with ESMTP id 92E9540008 for ; Tue, 24 Jan 2023 15:12:20 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=RPAaXwhf; spf=pass (imf01.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674573140; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MHVYb+F+v1ly5jz020IbfY9LMW7KSn2BHzFvSpAZ9vY=; b=owACUUOtcnxYc2HgcIQqHseMhudYcBbouZggAKRlhlI6gWQCosPte2dcqsf+sj6VeIWdfd pYqxarSS0RP4Mq9K5fe41nwURBETbLop/iIc5sIbdOTuITWZ8yEBQXo5hxB40vLvWYmzis X3keJX/LXD0n1KZv+jvirY7CmjCBw1Q= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=RPAaXwhf; spf=pass (imf01.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674573140; a=rsa-sha256; cv=none; b=nrGuWXnjFxJPe2pMB+k+hRidPdm/ZbqEjjCH/MvN67jnxnY+RupcaWuTEpA/XZJmxyLt1t Jyfn+ps2DX1YdbX6v5dv9wwaisKvWAvilZsQGk2A7IB4cg8qy87oXSDYMYaIW2WLkaRmqH WpByOes9KnlC6UKIvJ46yQulY8RyfFA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674573139; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MHVYb+F+v1ly5jz020IbfY9LMW7KSn2BHzFvSpAZ9vY=; b=RPAaXwhfc+kU5qh0fy4SkPjL6QRHmESzzxlpo1wuS29SJEcePyH7o1bm1y8kLAqqsud94Y 7owVDT/GM6Tgm2WxA3glCmbTA+kpfo0RrNGsDxd8pUP5zjBoKyQuCNOc3ikBhJRUo1Jwq/ pHmtGvKEsgRzW+oIQwzvtVjYIR2lXsg= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-92-Zeki7l7aP_m9MDaf2hmA_A-1; Tue, 24 Jan 2023 10:12:13 -0500 X-MC-Unique: Zeki7l7aP_m9MDaf2hmA_A-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BCD3C1871D94; Tue, 24 Jan 2023 15:12:11 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.97]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2E3E2C15BA0; Tue, 24 Jan 2023 15:12:10 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <20230123173007.325544-1-dhowells@redhat.com> <20230123173007.325544-11-dhowells@redhat.com> <31f7d71d-0eb9-2250-78c0-2e8f31023c66@nvidia.com> <84721e8d-d40e-617c-b75e-ead51c3e1edf@nvidia.com> <852117.1674567983@warthog.procyon.org.uk> <852914.1674568628@warthog.procyon.org.uk> <859142.1674569510@warthog.procyon.org.uk> <864109.1674570473@warthog.procyon.org.uk> <875206.1674572365@warthog.procyon.org.uk> To: Jason Gunthorpe Cc: dhowells@redhat.com, John Hubbard , Al Viro , Christoph Hellwig , Matthew Wilcox , Jens Axboe , Jan Kara , Jeff Layton , Logan Gunthorpe , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Christoph Hellwig , linux-mm@kvack.org Subject: Re: [PATCH v8 10/10] mm: Renumber FOLL_PIN and FOLL_GET down MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <876298.1674573129.1@warthog.procyon.org.uk> Date: Tue, 24 Jan 2023 15:12:09 +0000 Message-ID: <876299.1674573129@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 92E9540008 X-Stat-Signature: n7mu47bu89np571uxzm65jiq73ydejg3 X-Rspam-User: X-HE-Tag: 1674573140-376578 X-HE-Meta: U2FsdGVkX19sCaVwIXuYnsGc7guS2BU1U60yZy/G6rGB2Ovcji/pYKEPD0OcB9vGLTmF0qwYpg3m5K4ICShJzlEv5+Olu3nGPm5pmCT9R6a0pJZf8HHpGNVl7OMz3IlNop95US6nE5R6Ug3XQDX06fuf8MjjXFhck7j8BKADcfUtX9jUpcIhM+etTdzcZnegF2jp8hclBxOCDeAy/ZuICHnSoJWvjhy0mJKBnM8POpz8hklkSYLWHhlRpX7UzRftcGX+Lr1d+g+BdkOfVWFfdLD4kPP9ijSEozAZlWTmC3A78mr7y5OHWGPG/MegvSuwu6hgKe4q+NlU6eIx+MBCkUZzxaWyu9fd3fj9Pn5LSGmVmJx5pSQhkFAt0eT7UZTvwuI28dOORrmPLFFGAhVPgr7BMbsmW+baBrZc2wl8/QiI1nUh9aXGe8Nb38pxr3HTYj0X9FBRRkkdX2jBpSt/3gtX9ojN8SLagea0NRJGFw/HsItDwqa9skcm444Nmxvjo7qjHTnRSWnBmjDQVLvvj7XXc42RYX+L8ZTU3QCMdD1AmDh5LSET/sCBFRHoYlLKx3Cmjd50S/7SaLIANG8WuHaelWRYez+SdOp/03QkpnZQ0GmDHGdnZ72ky5hbeT3NQtPA7FZhktFZLizQqkPofAXXgDz8MLyJeHbXu5mXv6GqbFyZ9glsZA6fETtaY+ePa7VHUkS7+6eI6GO0JCK0wTY3E0tl6uXiL4/kIqEr6hlGzgxh82JX3B9XmbuecqtcrECfqqHJP7KNWp6j0kRXzC/e98JZiPxbadt+xKJy0DMXVsxMQHfxTw5wWann/5IUaLCIW5Fw/s67+xWUWUrrN0V3/T4oXfTmBjRbQxsyt2NFJYsaYHnVaxAoHFdBo4H6Iz65gYQ69pZjLgvmz2eVhE32X4vhIEPJZTbRt/PcygXWvQBfxYmboCjHh2umpphB0HyTmrMPpkUMwBcR5Qd eRPzQqMa 8EYwVX32Y924bfyCxGhFQ4YfQuWQmAtb1Pm7lJmG0H+JhMxTOhO5tJ6rmxOvNdrXmfRZ6rB4OOIop1KeaW83jcnlxBbwur9ywDB8Nv4NjclXai4q+HWqxl0isnInyiWABgJDnkVHtZ58jQ3bBqNVD+7xZ3zrjEJ0vjq7//KV2h+5mbfciXeab0mD5kJAUKjbg1bn+dj6CANaiTDEIroOfgfSll9lPaw0WnPYNq53Y4M9eNCY5iS6nTbmMcA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Jason Gunthorpe wrote: > Isn't that this: > > if (cleanup_flags & PAGE_CLEANUP_NEEDED) > gup_put_folio(folio, 1, cleanup_flags & PAGE_CLEANUP_UNPIN) > > > ? Yes. As claimed, that would be three states. > Three states - decr get, decr pinned, do nothing? Yes. Don't worry about it. I'm not going to do it in gup.c. David