From: Michael Ellerman <mpe@ellerman.id.au>
To: Balbir Singh <bsingharora@gmail.com>, linux-mm@kvack.org
Cc: linuxppc-dev@lists.ozlabs.org, akpm@linux-foundation.org, tj@kernel.org
Subject: Re: [PATCH v1 3/3] powerpc: fix node_possible_map limitations
Date: Tue, 15 Nov 2016 18:00:52 +1100 [thread overview]
Message-ID: <8760npz0pn.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <1479167045-28136-4-git-send-email-bsingharora@gmail.com>
Can you make the subject a bit more descriptive?
Currently this prevents node hotplug, so it's required that we remove it
to support that IIUIC.
Balbir Singh <bsingharora@gmail.com> writes:
> We've fixed the memory hotplug issue with memcg, hence
> this work around should not be required.
>
> Fixes: commit 3af229f2071f
> ("powerpc/numa: Reset node_possible_map to only node_online_map")
I don't think Fixes is right here, that commit wasn't buggy, it was just
a workaround for the code at that time.
Just say "This is a revert of commit 3af229f2071f ("powerpc/numa: Reset
node_possible_map to only node_online_map")".
Otherwise LGTM to go via mm.
Acked-by: Michael Ellerman <mpe@ellerman.id.au>
cheers
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-11-15 7:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-14 23:44 [v1 0/3] Support memory cgroup hotplug Balbir Singh
2016-11-14 23:44 ` [PATCH v1 1/3] Add basic infrastructure for memcg hotplug support Balbir Singh
2016-11-14 23:44 ` [PATCH v1 2/3] Move from all possible nodes to online nodes Balbir Singh
2016-11-14 23:44 ` [PATCH v1 3/3] powerpc: fix node_possible_map limitations Balbir Singh
2016-11-15 7:00 ` Michael Ellerman [this message]
2016-11-15 15:42 ` [v1 0/3] Support memory cgroup hotplug Tejun Heo
2016-11-15 23:47 ` Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8760npz0pn.fsf@concordia.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=akpm@linux-foundation.org \
--cc=bsingharora@gmail.com \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox