From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15840C433EF for ; Tue, 29 Mar 2022 00:43:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 695088D0002; Mon, 28 Mar 2022 20:43:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6435F8D0001; Mon, 28 Mar 2022 20:43:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 532EE8D0002; Mon, 28 Mar 2022 20:43:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0104.hostedemail.com [216.40.44.104]) by kanga.kvack.org (Postfix) with ESMTP id 4715E8D0001 for ; Mon, 28 Mar 2022 20:43:30 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id E02E1A32D6 for ; Tue, 29 Mar 2022 00:43:29 +0000 (UTC) X-FDA: 79295575338.24.8992828 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by imf24.hostedemail.com (Postfix) with ESMTP id CFFFE180002 for ; Tue, 29 Mar 2022 00:43:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1648514608; x=1680050608; h=from:to:cc:subject:references:date:in-reply-to: message-id:mime-version; bh=/SIBH5oWohQy65qzFL+jDrUGSvvNfU7eDJd+7md+aW4=; b=em1PZmYk991hBgWk1CkPKdin7JDwO/s22riWQblfbd8NUsPiqrB2XBHD OK3DmPK+/1nLwMVPh/ILfLsUIvpglx9Wa8JXEgEDnpB3+hhPGAN1DhzRb 1hYU3fTWBQogh0I2sd0jeNxs6s5Qjr6bGIK7gX2K24ilDkLpr+AXzo8T5 TjSIqcGEmgb4GP2EC5ZF6KqG9kdWIhhGzgmy/ebNQA1Jpn8T4hrEM3tX+ cQBTpQ3mzWiK/z4UFbBu3JcHI5aTtT7WwMWJOWUkVBwd2z+H3y6HPzwOG AtC8KTja8XtXZ2OIMGFrQKu15ul2JrM4uFsnpzZT01vmW5vu1TxyB4RBL w==; X-IronPort-AV: E=McAfee;i="6200,9189,10300"; a="257960292" X-IronPort-AV: E=Sophos;i="5.90,218,1643702400"; d="scan'208";a="257960292" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Mar 2022 17:43:27 -0700 X-IronPort-AV: E=Sophos;i="5.90,218,1643702400"; d="scan'208";a="564145770" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.239.13.94]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Mar 2022 17:43:25 -0700 From: "Huang, Ying" To: Wei Yang Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, mgorman@techsingularity.net Subject: Re: [PATCH 2/2] mm/vmscan: make sure wakeup_kswapd with managed zone References: <20220327024101.10378-1-richard.weiyang@gmail.com> <20220327024101.10378-2-richard.weiyang@gmail.com> <8735j2opd9.fsf@yhuang6-desk2.ccr.corp.intel.com> <20220329004146.2xdswvrm2qu7f47x@master> Date: Tue, 29 Mar 2022 08:43:23 +0800 In-Reply-To: <20220329004146.2xdswvrm2qu7f47x@master> (Wei Yang's message of "Tue, 29 Mar 2022 00:41:46 +0000") Message-ID: <875ynxh9lg.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Rspam-User: X-Stat-Signature: 85pa9z7fj5s1c88deqhrinmszdayandf Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=em1PZmYk; spf=none (imf24.hostedemail.com: domain of ying.huang@intel.com has no SPF policy when checking 192.55.52.120) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: CFFFE180002 X-HE-Tag: 1648514608-812516 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Wei Yang writes: > On Mon, Mar 28, 2022 at 09:08:34AM +0800, Huang, Ying wrote: >>Hi, Wei, >> >>Wei Yang writes: >> >>> wakeup_kswapd() only wake up kswapd when the zone is managed. >>> >>> For two callers of wakeup_kswapd(), they are node perspective. >>> >>> * wake_all_kswapds >>> * numamigrate_isolate_page >>> >>> If we picked up a !managed zone, this is not we expected. >>> >>> This patch makes sure we pick up a managed zone for wakeup_kswapd(). >>> >>> Signed-off-by: Wei Yang >>> --- >>> mm/migrate.c | 2 +- >>> mm/page_alloc.c | 2 ++ >>> 2 files changed, 3 insertions(+), 1 deletion(-) >>> >>> diff --git a/mm/migrate.c b/mm/migrate.c >>> index 3d60823afd2d..c4b654c0bdf0 100644 >>> --- a/mm/migrate.c >>> +++ b/mm/migrate.c >>> @@ -2046,7 +2046,7 @@ static int numamigrate_isolate_page(pg_data_t *pgdat, struct page *page) >>> if (!(sysctl_numa_balancing_mode & NUMA_BALANCING_MEMORY_TIERING)) >>> return 0; >>> for (z = pgdat->nr_zones - 1; z >= 0; z--) { >>> - if (populated_zone(pgdat->node_zones + z)) >>> + if (managed_zone(pgdat->node_zones + z)) >> >>This looks good to me! Thanks! It seems that we can replace >>populated_zone() in migrate_balanced_pgdat() too. Right? >> > > Yes, you are right. I didn't spot this. > > While this patch comes from the clue of wakeup_kswapd(), I am not sure it is > nice to put it in this patch together. > > Which way you prefer to include this: merge the change into this one, or a > separate one? Either is OK for me. Best Regards, Huang, Ying