From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE357C4332F for ; Fri, 21 Oct 2022 10:49:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 407638E0002; Fri, 21 Oct 2022 06:49:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3B75D8E0001; Fri, 21 Oct 2022 06:49:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 27EBE8E0002; Fri, 21 Oct 2022 06:49:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 15DA98E0001 for ; Fri, 21 Oct 2022 06:49:53 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id E1BF1ABB77 for ; Fri, 21 Oct 2022 10:49:52 +0000 (UTC) X-FDA: 80044636224.04.B73CD6E Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf02.hostedemail.com (Postfix) with ESMTP id 558BC8003B for ; Fri, 21 Oct 2022 10:49:52 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 29A53B82B95; Fri, 21 Oct 2022 10:49:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8BEE5C433D7; Fri, 21 Oct 2022 10:49:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666349388; bh=UdpcZIggkYuFkG4wEbYKZ6EO11hn1g6zfjeX6Xlq0j4=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Ni+oJ/SuficEU8L3ey1MSFpjTJZIOhX/CBymIFqhbmKrYqV6JroMVAeQurURNsufo eh0VruL5A13jysiLPHQtRJByBuDeRksdURMjQ8L4HKtvkWQ9heRVuGLA7122Wo1Sd5 kF9MOD13HhILLk7CSlAs17zYhPjfnVq+vevbUCzvT1JfSuQ2Djl7mkyqf56BZb8Hap iZZI+e1pGL3WpGeoBsQX3PKavucknBEd01hlXvVzJBUShtI5y3HghNAq8YfXd8Aw37 yFS25gLrBoQpelETp/MvuERQCm7/WzUJleT1/8ZQT/77RDOeEcSCkJ34Fk2KE/ykKv C6mDpXA3f+1gw== From: Kalle Valo To: Bitterblue Smith Cc: kernel test robot , llvm@lists.linux.dev, kbuild-all@lists.01.org, Linux Memory Management List , linux-wireless@vger.kernel.org Subject: Re: [linux-next:master 637/2652] drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8188f.c:432:7: warning: variable 'hw_ctrl_s1' is used uninitialized whenever 'if' condition is false References: <202210211531.zEaM6hBM-lkp@intel.com> <87edv1lhad.fsf@kernel.org> <3d047bb4-276c-026a-e292-f0a1f011b9f4@gmail.com> Date: Fri, 21 Oct 2022 13:49:42 +0300 In-Reply-To: <3d047bb4-276c-026a-e292-f0a1f011b9f4@gmail.com> (Bitterblue Smith's message of "Fri, 21 Oct 2022 13:44:38 +0300") Message-ID: <875ygdlad5.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666349392; a=rsa-sha256; cv=none; b=5i38NsJiNAjLIMeg+aFvcW3ki/OGS7FdlycCeis1K57EzDKBKhoMH1gKqKBLCYLiXr2sIq OZZGXQoo86nXeQutMe+nkEF2hXsdhh44RzLD4lzisVtVHqluW5k8e1qNv04GCPxvARnFsO DdxyOR1EBqAUIBCQeOBiM262PTCQ+OI= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="Ni+oJ/Su"; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf02.hostedemail.com: domain of kvalo@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=kvalo@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666349392; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0GkHMmR7A2iUjH67fHguFs5simF49CVrBUfFctd6voo=; b=z0kpBc22ojx0VzHY13JhElUgsyt1R+LGdzMjsotZmzNb8/RN9BcYHR8hYui9dJOLOGD1Ux Gr826PD6ETVfU5or/ph4ypY+cjy66k/a9YRppU40wly6RpOE9SwgJsDFjSQA7CxtdgTpbw KTkOZthD4KtUuIZDSWmE8X7yEJ7mKqA= X-Rspamd-Queue-Id: 558BC8003B Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="Ni+oJ/Su"; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf02.hostedemail.com: domain of kvalo@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=kvalo@kernel.org X-Rspam-User: X-Rspamd-Server: rspam08 X-Stat-Signature: br981bbxinx7cokamfb5zkfepwmob46a X-HE-Tag: 1666349392-579889 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Bitterblue Smith writes: > On 21/10/2022 11:20, Kalle Valo wrote: > >> + linux-wireless >> >> kernel test robot writes: >> >>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master >>> head: 4d48f589d294ddc5e01d3b0dc7cecc55324c05ca >>> commit: c888183b21f36a247bb166ca9365705611bea847 [637/2652] wifi: rtl8xxxu: Support new chip RTL8188FU >>> config: i386-allyesconfig >>> compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1) >>> reproduce (this is a W=1 build): >>> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross >>> chmod +x ~/bin/make.cross >>> # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=c888183b21f36a247bb166ca9365705611bea847 >>> git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git >>> git fetch --no-tags linux-next master >>> git checkout c888183b21f36a247bb166ca9365705611bea847 >>> # save the config file >>> mkdir build_dir && cp config build_dir/.config >>> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/gpu/drm/i915/ drivers/net/wireless/ath/ath11k/ drivers/net/wireless/realtek/rtl8xxxu/ >>> >>> If you fix the issue, kindly add following tag where applicable >>> | Reported-by: kernel test robot >>> >>> All warnings (new ones prefixed by >>): >>> >>>>> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8188f.c:432:7: warning: variable 'hw_ctrl_s1' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized] >>> if (hw_ctrl) { >>> ^~~~~~~ >>> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8188f.c:440:7: note: uninitialized use occurs here >>> if (hw_ctrl_s1 || sw_ctrl_s1) { >>> ^~~~~~~~~~ >>> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8188f.c:432:3: note: remove the 'if' if its condition is always true >>> if (hw_ctrl) { >>> ^~~~~~~~~~~~~ >>> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8188f.c:415:45: note: initialize the variable 'hw_ctrl_s1' to silence this warning >>> bool do_notch, hw_ctrl, sw_ctrl, hw_ctrl_s1, sw_ctrl_s1; >>> ^ >>> = 0 >>> 1 warning generated. >> >> Bitterblue, could you submit a patch to fix this, please? > > There is one from Colin Ian King: > https://lore.kernel.org/linux-wireless/20221020135709.1549086-1-colin.i.king@gmail.com/ Thanks, I'll take that later today, before I send the pull request to net-next. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches