From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45768C47089 for ; Tue, 6 Dec 2022 02:41:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C59208E0002; Mon, 5 Dec 2022 21:41:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C09EF8E0001; Mon, 5 Dec 2022 21:41:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AD19A8E0002; Mon, 5 Dec 2022 21:41:56 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 9E36C8E0001 for ; Mon, 5 Dec 2022 21:41:56 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 68CF9AABF6 for ; Tue, 6 Dec 2022 02:41:56 +0000 (UTC) X-FDA: 80210331432.10.C4CDE60 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by imf07.hostedemail.com (Postfix) with ESMTP id E15124000D for ; Tue, 6 Dec 2022 02:41:54 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=HmOTg3Oc; spf=pass (imf07.hostedemail.com: domain of ying.huang@intel.com designates 192.55.52.120 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670294515; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QJbAtek7WIpFGAPF550dwaVVlcNDel6G39kZDCgKf0s=; b=OmX8976aOrSf1RPm2UjJ72VMcO+zI0MzViCz+JAe7m9ftieRfIX6AxdsE/4O/qH0Pfuks4 SIpG9HUkBE6U8DsyJ0b+RzX2Gq5Wp3RlR5EBACb4ZhmKVhQlFggijOAd7uEy7n3/OvQuHs NAGFx7SRnz4HENw3HbyJmIemomrrRr0= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=HmOTg3Oc; spf=pass (imf07.hostedemail.com: domain of ying.huang@intel.com designates 192.55.52.120 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670294515; a=rsa-sha256; cv=none; b=V4+SXfOKxH0o60Eo49Y+3BJAzXaf/Crh09zQ0u2wY9onJF5U3HxL6NFdPUKRPMBkgS8Jz/ hHMiMRHPoQNbiScdE9RE5mKUq7shItk8nlotdQV0ZDOJ1Svli33yVLjU0JZZClmMgURJQJ 2LMfcjRWT8Qtd0CDNQa7ujZgNzdoyRU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1670294515; x=1701830515; h=from:to:cc:subject:references:date:in-reply-to: message-id:mime-version:content-transfer-encoding; bh=FZAHxGmeLgTvz+h4faOmVd/+icSg6LznsgsEN+s6FS8=; b=HmOTg3OcHKlBYsqMy0mnM0GDlKf8pbkoMOc6tEatH49ruutnK3cpclvt 46QRIy6SHYRWaNSvqUNa/R6qKxHdMIzAAU7mAWagdoGQcd5oNlnu7OPtB yJBDYdRZ3J0FUqv+h/T1trR4xX6iiQ5ZzuCQYwW4wFaYL0+S/I6eGSb3x DNWU2d3T2Ej8D6JMa0MJAU89Wchb5ocmn7ykkFBFuW/PBfjqyo9s//bgS Tspl0chgT1db2MANhEz3A3nvAp9SIGlT6uB2PwsWKXA0jy78zorS2Pws4 x7ug6b6GQJXlNxhv+8U1JbgSHNW2wRYnJkgx1O5NzwvKKYDCZDZzgVaAc g==; X-IronPort-AV: E=McAfee;i="6500,9779,10552"; a="315226073" X-IronPort-AV: E=Sophos;i="5.96,220,1665471600"; d="scan'208";a="315226073" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Dec 2022 18:41:53 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10552"; a="974910264" X-IronPort-AV: E=Sophos;i="5.96,220,1665471600"; d="scan'208";a="974910264" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Dec 2022 18:41:50 -0800 From: "Huang, Ying" To: Shakeel Butt Cc: kernel test robot , oe-lkp@lists.linux.dev, lkp@intel.com, Andrew Morton , Marek Szyprowski , Linux Memory Management List , linux-kernel@vger.kernel.org, feng.tang@intel.com, zhengjun.xing@linux.intel.com, fengwei.yin@intel.com Subject: Re: [linux-next:master] [mm] f1a7941243: unixbench.score -5.1% regression References: <202212051324.182a6363-yujie.liu@intel.com> Date: Tue, 06 Dec 2022 10:41:00 +0800 In-Reply-To: (Shakeel Butt's message of "Mon, 5 Dec 2022 09:18:28 -0800") Message-ID: <875yepfe4j.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: E15124000D X-Stat-Signature: f3onjktsf8ozjinu57ihdyj65jid548e X-Spamd-Result: default: False [-0.92 / 9.00]; DMARC_POLICY_ALLOW(-0.50)[intel.com,none]; R_DKIM_ALLOW(-0.20)[intel.com:s=Intel]; R_SPF_ALLOW(-0.20)[+ip4:192.55.52.120/32]; RCVD_NO_TLS_LAST(0.10)[]; MIME_GOOD(-0.10)[text/plain]; BAYES_HAM(-0.02)[47.80%]; RCPT_COUNT_SEVEN(0.00)[11]; DKIM_TRACE(0.00)[intel.com:+]; FROM_EQ_ENVFROM(0.00)[]; MID_RHS_MATCH_FROMTLD(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; FROM_HAS_DN(0.00)[]; MIME_TRACE(0.00)[0:+]; TO_DN_SOME(0.00)[]; ARC_SIGNED(0.00)[hostedemail.com:s=arc-20220608:i=1]; ARC_NA(0.00)[] X-Rspam-User: X-HE-Tag: 1670294514-596079 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Shakeel Butt writes: > On Sun, Dec 4, 2022 at 9:56 PM kernel test robot wr= ote: >> >> Greeting, >> >> FYI, we noticed a -5.1% regression of unixbench.score due to commit: >> > [...] >> 9cd6ffa60256e931 f1a7941243c102a44e8847e3b94 >> ---------------- --------------------------- >> %stddev %change %stddev >> \ | \ >> 7917 -5.1% 7509 unixbench.score > > What is unixbench.score? Should be benchmark throughput. >> 10485 -12.1% 9216 unixbench.time.maximum_res= ident_set_size This should reflect accuracy change of per_cpu_counter. >> 37236706 -5.1% 35324104 unixbench.time.minor_page_= faults The reduction is same as benchmark score. So I think this reflect the nature of time-bound testing (instead of workload-bound). > For above two, is negative change good or bad? > >> 0.98 =C4=85 20% +0.7 1.64 =C4=85 38% perf-profile.cal= ltrace.cycles-pp.link_path_walk.path_openat.do_filp_open.do_sys_openat2.__x= 64_sys_openat >> 2.12 =C4=85 19% +0.8 2.96 =C4=85 13% perf-profile.cal= ltrace.cycles-pp.handle_mm_fault.do_user_addr_fault.exc_page_fault.asm_exc_= page_fault >> 2.35 =C4=85 13% +0.9 3.28 =C4=85 13% perf-profile.cal= ltrace.cycles-pp.__handle_mm_fault.handle_mm_fault.do_user_addr_fault.exc_p= age_fault.asm_exc_page_fault >> 0.14 =C4=85 74% +0.4 0.55 =C4=85 32% perf-profile.chi= ldren.cycles-pp.do_task_dead >> 0.04 =C4=85223% +0.4 0.47 =C4=85 49% perf-profile.chi= ldren.cycles-pp.__mmdrop > > Also how should I interpret the above perf-profiles? It appears that the changes of handle_mm_fault() and __mmdrop() are related to the code of the commit? That is, for this specific workloads (not so unpractical), the operations become slower? Best Regards, Huang, Ying