From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BD9EC38142 for ; Sun, 29 Jan 2023 03:02:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 27E7E6B0074; Sat, 28 Jan 2023 22:02:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 207AC6B0075; Sat, 28 Jan 2023 22:02:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0A8886B0078; Sat, 28 Jan 2023 22:02:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id EB7DE6B0074 for ; Sat, 28 Jan 2023 22:02:45 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id B9808A0152 for ; Sun, 29 Jan 2023 03:02:45 +0000 (UTC) X-FDA: 80406339090.13.7A8A64B Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by imf07.hostedemail.com (Postfix) with ESMTP id F140140006 for ; Sun, 29 Jan 2023 03:02:42 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=nFewdlOp; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf07.hostedemail.com: domain of ying.huang@intel.com designates 192.55.52.93 as permitted sender) smtp.mailfrom=ying.huang@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674961364; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SdubRjAM8RFb0a2Njegjcqr4zl5E0/7OzFQKBHluucY=; b=NyUzP7O02b/sQy1aI1zIsHmrlhm9QI+AoZPWMrnVjWkoQ/XDgpMD/iSSkDhjmOWSoMT7Fs oBAxPjRuMRxuyMUWTe16hUycQt9d/ZudjaZkbX4FCSx9VCpKeZBdfjxrfgIoRKJ9SmkABf AyaA/do2hVcgkkHvW9ZKB1wpp3/5j5g= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=nFewdlOp; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf07.hostedemail.com: domain of ying.huang@intel.com designates 192.55.52.93 as permitted sender) smtp.mailfrom=ying.huang@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674961364; a=rsa-sha256; cv=none; b=4vN1v+mYyNx1Rd3whizJW2zZ1CsYIWJgYN4/ULwEv3A6hUwCaqqV4N7eJW5i43+3Xuh85a 1uaT0VfQGhb7CqJsXY3Mog0rnCZuY4rwgXam5lC8i7X7ZbQJ0E/4nDn0HLu9uPpJgmaQzU Y0hkW1Ih8RrwPOghDtriSZlrEHsRQXo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1674961363; x=1706497363; h=from:to:cc:subject:references:date:in-reply-to: message-id:mime-version; bh=98lkgC1vWJoVJMl83+1D4wn5NUIPCKs6/A96bim2eJM=; b=nFewdlOpvPX+Gw/GqiFmpbuxBtzJ+CsrdegR70xx3V+1KTuAQZjJMo6U 67hqewi8iHYL7gjfkLrJJyCdvCl1FLZt/M11R3374iRA5x2YgOnztsEve HQVkFMTRIf7uMfg2JB9jr95tp0n7L6UZxOWuAQv688qYyGrbeB1am92nN 7Pk9vioxobpa4ECvQOSj9oUaPDbhUoN+hD48hSFs1UtIYjMGHbvjhiL4T XbhO6UqL5cTqtvXTdm8ANxjUkiCDezaeZO5OZ0o2FPXlmg+ulsPNhTpv2 IO/SqKjyydOL4LPF/iZPwlKxU04SlbWAFRlBSHel9djfWSdC/vS/d1n+u Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10604"; a="325051339" X-IronPort-AV: E=Sophos;i="5.97,254,1669104000"; d="scan'208";a="325051339" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jan 2023 19:02:41 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10604"; a="752408748" X-IronPort-AV: E=Sophos;i="5.97,254,1669104000"; d="scan'208";a="752408748" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jan 2023 19:02:39 -0800 From: "Huang, Ying" To: Chen Wandun Cc: , , Subject: Re: [PATCH] mm/migrate: Continue to migrate for small pages References: <20230129025404.1262745-1-chenwandun@huawei.com> Date: Sun, 29 Jan 2023 11:01:31 +0800 In-Reply-To: <20230129025404.1262745-1-chenwandun@huawei.com> (Chen Wandun's message of "Sun, 29 Jan 2023 10:54:04 +0800") Message-ID: <875ycqcad0.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: F140140006 X-Stat-Signature: ji5gnoz7dtjaja5um9x6snosgn6867s5 X-HE-Tag: 1674961362-35415 X-HE-Meta: U2FsdGVkX1+eFnk8giX0sNSS9NkH4e13Kp/S7eSaE8mtmtUbAHbEcEi/QRRbszzfWYzzCpV9LteuOtSumg7lkdOi26JVAqVCgviNZh/xYmTvLDAszwgqy7zDaaKOFCudzKxzsBdyd/BazrkCmgpRIrlrA4agmLF+JuA7psG6qxXGvZJLBBjgKqEIYrpewEvgydu3ip9Egl6zvrlzECdMV6rnXfOQ5Y8qLpJJBuyqrmTBcsS5BzhaO5gOUGykjnKRlR+qMiE7E1GWWatYeY+xn1iNvCvNGB1Gq7rsgAsyyumhHrXIg/kWbDasvjcYAscXJEBo0RKxoVdtBprJLYWq/fui5wmPQYJ6R/XmphG/mUmdShZ94hxB6jQJZULl1IdZt/vonOlqlo8AdzmIYRL8NS63MAk7iB968ocJUdHTxGkOQURrkf9h5NwfBEuzBmKp4zVbYkosSqrFf42XoQcLlggIfaTUnFcIHvdjSZfIUcXv8N0Db/TyllwN5fDXkq8H4mUfHdqjGmtmdd/J5wNACIaCyOKTDVEd0TnqgbK5j69BWwtJCfwZN08Jy4gZ4dZIlOa3V8V8/cZsHNrMQq4PWQs+xMNzP/nypxixWBQbL7n6zazNz83ujb+3PKaxhMtPoiZqiRqbxEIbTIeozp2ebEMMuAI7p5HMXqVHxvrnRWUjgk/3/2FQn4jhEcK5CzD6+Rcul3sQf61JlIkYjWEeNUe2Sd84WTTAeY4msbYGfZOEslxfiyxQ7AjWaHQfEt9eHx+Aq179spo2K7pMSIZFE1qJbZi1KnkvsEADvt2YQZAmnQ0/dbH16Ha4W6Bn9uof+qHAyt5rgD/kyXDL4I9lQrZPSsXdxMeZ6QtPAe31yps7ptwoohLBctYmP2bPURvK8Vrxc5zb/GZk1YY6gIXDp/IEaoN+nRzRCjEjCGUo85xQvISMCTD2U8SXr66g2Ci3z3HuBAQm1L+qy3TXGE8 9XTxVutk IUo63ybNyBZpO+Vympr2fMzvvu2z57tHjv1xaB7vCCPtuVfjX3plOa9X8VH0Hr63hcmRR3d2ouBwBDtHJc+yGck3TXTpeHXy0JHo7eWQK53VZACUpAOt9Rv40T5lDQDWPw3PuntHb6Q2FXb5VfEV78/MbqN7DJu2yKgGsb1v/0YMor1wXc1GawEI5wg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Chen Wandun writes: > migrate_hugetlbs returns -ENOMEM when no enough huge page, > however maybe there are still free small pages, so continue > to migrate for small pages. Better to replace "page" with "folio", and "small" with "non-hugetlb". > Signed-off-by: Chen Wandun > --- > mm/migrate.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/mm/migrate.c b/mm/migrate.c > index b971edbf32fc..c9d0d2058036 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -1939,7 +1939,12 @@ int migrate_pages(struct list_head *from, new_page_t get_new_page, > > rc_gather = migrate_hugetlbs(from, get_new_page, put_new_page, private, > mode, reason, &stats, &ret_folios); > - if (rc_gather < 0) > + /* Maybe there are free small pages, continue to migrate. There may be free non-hugetlb folios available, continue to migrate. > + * Nowdays the only negtive return value of migrate_hugetlbs > + * is -ENOMEM, keep compatible for coming negtive return > + * value instead of ignore return value. This can be moved to patch description. > + */ > + if (rc_gather < 0 && rc_gather != -ENOMEM) > goto out; > again: > nr_pages = 0; Best Regards, Huang, Ying