From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34B03C77B75 for ; Tue, 18 Apr 2023 05:25:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C3F31900002; Tue, 18 Apr 2023 01:25:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BEEC38E0002; Tue, 18 Apr 2023 01:25:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ADDEE900002; Tue, 18 Apr 2023 01:25:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 9E15F8E0002 for ; Tue, 18 Apr 2023 01:25:23 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 69A3FA0131 for ; Tue, 18 Apr 2023 05:25:23 +0000 (UTC) X-FDA: 80693373726.26.42FB600 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by imf12.hostedemail.com (Postfix) with ESMTP id 57BB440008 for ; Tue, 18 Apr 2023 05:25:20 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=K1V6XCTi; spf=pass (imf12.hostedemail.com: domain of ying.huang@intel.com designates 192.55.52.43 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681795521; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KtZiquyEmPvrnjLfXJC2D95Zs0y9/42nQiBoJofX/z0=; b=8R/sbOQP4w62knjsQY7OuVfH8jxFTmTgclrRq+aD7tdQD4aP5P44mEY6YVqLMzy+UuKEz1 sQitSG7pGgZV8F0ViaBveuz0h3yb8VviVKsevF5yVDg9rgrkuCW8ZnnVs0redyEhTdglhz xuTgI8Nw3HypEFAxx8QOa7cT25osbKY= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=K1V6XCTi; spf=pass (imf12.hostedemail.com: domain of ying.huang@intel.com designates 192.55.52.43 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681795521; a=rsa-sha256; cv=none; b=2hYr4YDW0umacmI3bzjbW6dBk6ujlNyg6wjelyl5Zb7YBaK4pnr86+A2wt/vQkeojyU5t/ 3Av7SOdZZ6a54qzZYz6bdQKD4ZLLqFWTCzaehsWl/Ckqo2V3GBggbODzMZwvBu+aRi8XL3 HENJDiX5B+XX4pJ6x8U+kF3KaIbJCSc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1681795520; x=1713331520; h=from:to:cc:subject:references:date:in-reply-to: message-id:mime-version:content-transfer-encoding; bh=seD/963AMpffNLu32Ham67dB9tIbhEdstnTXX27xLCo=; b=K1V6XCTi4j0I8HQtV7tPEewXHrRj+5CxOeOkVIFf2mokumd+pKuKzEf1 hklpJu39qO8wDDi3K+TFu09bkBulYNKtpxxs2wFZX4060r47oIX4kNYJB YkmG+sRvAZQ2wYwBoZooCs4W7gIReumRZf2yu39Yf/waexce9EnsgegzS i6LmvMjeVZpa+5fDsPfJbISKPMjwCk4VyAezv4jk1sHOSHqSKdnOOeJmK O0FTzTi/4kQZdSDrAqgf1L6JSEi9dXTohQCyBuQBOR6prQ8gYGJEuUNhF R3Ft/OqSiQ9NP/a7Ervhq/V4AqfKb2PB++eqzbo6xoUlptsxPCySplV1V Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10683"; a="431367798" X-IronPort-AV: E=Sophos;i="5.99,206,1677571200"; d="scan'208";a="431367798" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Apr 2023 22:25:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10683"; a="865247232" X-IronPort-AV: E=Sophos;i="5.99,206,1677571200"; d="scan'208";a="865247232" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Apr 2023 22:25:15 -0700 From: "Huang, Ying" To: Zhaoyang Huang Cc: Matthew Wilcox , "zhaoyang.huang" , Andrew Morton , Minchan Kim , Joonsoo Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org, ke.wang@unisoc.com, Timur Tabi Subject: Re: [PATCH] mm: fix printk format within cma References: <1681788789-19679-1-git-send-email-zhaoyang.huang@unisoc.com> Date: Tue, 18 Apr 2023 13:24:06 +0800 In-Reply-To: (Zhaoyang Huang's message of "Tue, 18 Apr 2023 12:16:19 +0800") Message-ID: <875y9tvk3t.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: fq3pddeorzmozsxcw4y49dce4smcfw8p X-Rspamd-Queue-Id: 57BB440008 X-HE-Tag: 1681795520-79804 X-HE-Meta: U2FsdGVkX18sapgmwjWeOFH5HawU/Jd4lrCMVWQN6p72KoJhC391fbg1SeS1E64lE26dzSw4wtBMNhvFonvADQG8XhKh6jb8UQu907g5aAEitb1BX1lra+Xe4wMw8Vuqb0y4NXWJUX7v+7aXtc4kFtToByNBAy2Ca867tu4HNcOtqkB5AX6KX5bTCvZjq2h2lbvDa3odLNq44VdCAXC7mFWNDpzcwk4bR6LtHIYidiwdRgwiO3nMjMOH0xSFstWdFGoenEbS1kTVDcLqnD89lxvZoW0G2F0zOApLwC7++DGEPHw8cF/8Ih7gXM88dojkMiLOs+qOsYa8k1gWpEG6J7+ycaojlEDQTChnNlRm4zqKdTEXd/GXhsB867JOomJIxBRiyvSCdfRKIc2HI5E8CJpI7uYY+KTkv/37sFkhjHgbQShFWb/sK5BWKbud7MVHT4W4ewBVVzJV8jcXAuzWpFObLvc+ANifjvQyuhZClnA9UXG3iV0TisMf5sciIlFbxumydG3j3naHwqlKXxQfH7LSHNsQxf6TsgctsxCtVVooGHtIlKwyfKpA1/KHKW4SSBAxtZCwbGrLpgGqXB49dHbxnbyo8HIkRsT9NKkTcalnabgjyvJFWyxv+qp4T9OZYvZ9wYern/erBQVTEGoq3340VEdHFHVARYgvuOXXSL/LMs6ZeKSUIYnwUotK446LHEEIZ4Qf5R1v/AJomxmcdrlcrBR3nn14tsl4xzf19HXFR6xT5g0nGxlVFacBArrmo9WsZSjlRDmBzF9PeLYseudD5TG165ZVuIKKOPMxepSadXKwGHzLbvyeMPcu+XY6p5yotdnEitf1jnthc9+LR1gY9aRwamWvisjAgpzzuQG+aRKWcCji/ae9t80IoPF/48TMaqHPmSmdKwOJarAcJJq0lVvjDaAwPJXq2K+xy4F1OiyvoCB+4uLD3GWt1hAsQIrOkc3m2JU0IQKpWt8 Aj0b4jHB mX1YnGx4lZkl70CIaEeJRgJnRje4DedsN/ikFEFsw/8Bw/hGOxqerXqGoI0U2925LNUoYXeCtF0otdBTwt+kbBCIKHQIIxpAhV4iomzuT63DL0vdoKsGn4ZL4JKIVocX0pwToYIt+X/V9r+NGhsVpeyuB1r0q9NlD5j2fEk1LInqp22S7iy9YO5s0iEGyuosGvNyq8y/dSWy/Nx6mp1vuNfxF/7Z99sybnxWCuS3fcwnHCL+bFMPxkBklWbAEX8vgO+JkrqDHtN3LIqy5i37PKYvmOjG5vTHBZkuBDHCaQfy4tf4+GjFTys1gVw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Zhaoyang Huang writes: > On Tue, Apr 18, 2023 at 11:38=E2=80=AFAM Matthew Wilcox wrote: >> >> On Tue, Apr 18, 2023 at 11:33:09AM +0800, zhaoyang.huang wrote: >> > cma and page pointer printed via %p are hash value which make debug to= be hard. >> > change them to %px. >> >> Why does printing the page pointer make any sense at all? Surely the >> PFN makes much more sense. > either pfn or a correct page pointer makes sense for debugging, while > page could be more safe than pfn which expose the paddr directly You can specify "no_hash_pointers" in kernel command line to print pointer value for debug. IIUC, this take care of both security and debuggability. Best Regards, Huang, Ying >> >> > [63321.482751] [c7] cma: cma_alloc(): memory range at 000000000b5e462c= is busy, retrying >> > [63321.482786] [c7] cma: cma_alloc(): memory range at 000000000f7d6fae= is busy, retrying >> > [63321.482823] [c7] cma: cma_alloc(): memory range at 00000000e653b59b= is busy, retrying >> > [63322.378890] [c7] cma: cma_release(page 00000000dd53cf48) >> > [63322.378913] [c7] cma: cma_release(page 00000000315f703d) >> > [63322.378925] [c7] cma: cma_release(page 00000000791e3a5f) >> > >> > Signed-off-by: Zhaoyang Huang >> > --- >> > mm/cma.c | 6 +++--- >> > 1 file changed, 3 insertions(+), 3 deletions(-) >> > >> > diff --git a/mm/cma.c b/mm/cma.c >> > index 4a978e0..dfe9813 100644 >> > --- a/mm/cma.c >> > +++ b/mm/cma.c >> > @@ -435,7 +435,7 @@ struct page *cma_alloc(struct cma *cma, unsigned l= ong count, >> > if (!cma || !cma->count || !cma->bitmap) >> > goto out; >> > >> > - pr_debug("%s(cma %p, count %lu, align %d)\n", __func__, (void *)= cma, >> > + pr_debug("%s(cma %px, count %lu, align %d)\n", __func__, (void *= )cma, >> > count, align); >> > >> > if (!count) >> > @@ -534,7 +534,7 @@ bool cma_pages_valid(struct cma *cma, const struct= page *pages, >> > pfn =3D page_to_pfn(pages); >> > >> > if (pfn < cma->base_pfn || pfn >=3D cma->base_pfn + cma->count) { >> > - pr_debug("%s(page %p, count %lu)\n", __func__, >> > + pr_debug("%s(page %px, count %lu)\n", __func__, >> > (void *)pages, count); >> > return false; >> > } >> > @@ -560,7 +560,7 @@ bool cma_release(struct cma *cma, const struct pag= e *pages, >> > if (!cma_pages_valid(cma, pages, count)) >> > return false; >> > >> > - pr_debug("%s(page %p, count %lu)\n", __func__, (void *)pages, co= unt); >> > + pr_debug("%s(page %px, count %lu)\n", __func__, (void *)pages, c= ount); >> > >> > pfn =3D page_to_pfn(pages); >> > >> > -- >> > 1.9.1 >> > >> >