From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AEC0C77B75 for ; Tue, 23 May 2023 17:39:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 937566B0074; Tue, 23 May 2023 13:39:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8E6D6900003; Tue, 23 May 2023 13:39:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7D5FF900002; Tue, 23 May 2023 13:39:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 6D27D6B0074 for ; Tue, 23 May 2023 13:39:30 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 40C2D1C7338 for ; Tue, 23 May 2023 17:39:30 +0000 (UTC) X-FDA: 80822231700.16.40271E9 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by imf17.hostedemail.com (Postfix) with ESMTP id 6EECD4001B for ; Tue, 23 May 2023 17:39:28 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=Bla2ERBS; dkim=pass header.d=linutronix.de header.s=2020e header.b=E81tcBii; dmarc=pass (policy=none) header.from=linutronix.de; spf=pass (imf17.hostedemail.com: domain of tglx@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=tglx@linutronix.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684863568; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UPc2BcDcHmr+80mcM6Lrl06h2h/OgpxsUG3E77KEdlM=; b=xJ7GA3K42ua7P/kP13UpoByPHU9lxSxLUH9ByQYSisz3jqTAhyEKnhhTfV73zpC8r955W9 HRpIQxl36KZStStin6MteYvykgrwXNikYsVlgwjIB1o8suDNBwkM69WmTN2rID401p42Au zbzyKHRHy3IRBx3cbHyV7l/t1jlfZos= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=Bla2ERBS; dkim=pass header.d=linutronix.de header.s=2020e header.b=E81tcBii; dmarc=pass (policy=none) header.from=linutronix.de; spf=pass (imf17.hostedemail.com: domain of tglx@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=tglx@linutronix.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684863568; a=rsa-sha256; cv=none; b=QzE8DbG0b9dSgsXogZviWN/3RJKxxLzdwPDVbQCVhS9/c8ZBv4x4OI/Iy2Yo9p3t3IuzIA MwBq8G3jlbEIDuUUVkuXC4Fb/2QDTBn0n1pS4x7hChAZDWCUVRz6GtmwgDsD0pG3D79+pO x+H3PW3AtTaiZLcUK/D3r1JZtvoj8Eo= From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1684863566; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UPc2BcDcHmr+80mcM6Lrl06h2h/OgpxsUG3E77KEdlM=; b=Bla2ERBSK/DNB6/l+h6nOsgLHKEe4Rfta0gPBRMAXuFGnH0QvJIFvG7GFYWBMfHZy/IT5J roSeWiW97Af3D1o/FCagNEEnc/HGbSAiviG15SbiI9Z/QUGeKUhu6IdlgBodXaZLj7MXf1 Q8Y+DiI3fatdQotd26a9Gwga9picvztDyLorSkJSG5o4jjmylUvkuGVTLeStegKL97TL4o xyRhAeuPqWNk8urdZovF7BuchLohJqj1RCLCYI6BaiziSRQNCXB8ek5/K3/5E/A+aXYEs7 w3YF86TTVJGle8sr9HzdHq3WnRy9HXfl12wYmVFGAOIeiELGvW/A0Bn3iMFXuQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1684863566; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UPc2BcDcHmr+80mcM6Lrl06h2h/OgpxsUG3E77KEdlM=; b=E81tcBii6EspwpzpmrTdvK3L369bYC3X+mElMFqwa/w4xCoJg4JipJoD17jQVDP1EEusBY GZcLE/v3KJRLgzDQ== To: Uladzislau Rezki Cc: linux-mm@kvack.org, Andrew Morton , Christoph Hellwig , Uladzislau Rezki , Lorenzo Stoakes , Peter Zijlstra , Baoquan He Subject: Re: [patch 0/6] mm/vmalloc: Assorted fixes and improvements In-Reply-To: <878rdfuf54.ffs@tglx> References: <20230523135902.517032811@linutronix.de> <878rdfuf54.ffs@tglx> Date: Tue, 23 May 2023 19:39:26 +0200 Message-ID: <875y8jueup.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: ce1w1c1i57pariqf9y19q7ectrosixs8 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 6EECD4001B X-HE-Tag: 1684863568-821062 X-HE-Meta: U2FsdGVkX1/uY9gYYv8Jkcq0ForAyJuTIppOHASFuJl9M31gg/7RHa0mwQCXUB/7J9mVzkZQdV0IGNt2NhkNlOv7fNqwC9QwJo1iKsk2jesWjuIFbqszJq+tWTFmYbBnKkSNYsoHMkaVpNPFWeEHeqvqI6OVNYOQWXK454wZRZyyfwm7Yk75yTgAGAHKObYDvxaVFOo2+Zd3afJNh/G1ikumuHWW4EpY88shyEXGwBvINTFa+1SrU4lznnTt8+bCfBB7s447dbdrG79b2HHjnhsF3u2Lr+HGyjxsZc97oxFd/ihs7xJZJ5GSAM0KyIDzilmSw5t6AW5ZoZLBDgdJwMmk/cK5YAXuhRM1YgiydcArzmFwoc8ZbVcxe6qsvFnMB0oLmJf7VcVoo6R+TfYiX+f6aUgoVr1XL410luShvJdBJ4scdcbgw2jBVqiND6DCK5EpAJM0hzbMZg5rAks2ObJoglt1bD5EcRyEvbCcdOheq23bUPIM1maPmbj5S4kYwIUkINuFdK1U9jGUSG1Ieuk0jpBhg+T/weK/pyPfuKo4amDPKtONDFiO49PJBaoGYg7hDgn5KuPWr2QERZ4LH+OZlTsFAUS6kUHFbv8Eo+t2lSfT2Z65IlPGHvVPOA2B0UdeTrNoOMpRVVqCOVJiNeYjWpYVxIHXmihRrN2SZiZNfJxWjX6LzcMs9wFR8nT0mn3O2HCXzIuVvMeG12zvSpuLiLiUrd+TiH4E9UwN7bXnXJe3nWvjJaiS59WeDiAxpWYzfv/mu52ySllhzhV0Go1/vPLiGiP+BznQmxXMmOYnGlpasIGBpGjWCUtrLqf2/ofX3Opw4SgTvOTt5wnpozdpkilrDLxthJ+MmJwsMejL3aX1ENBZtyH5heQZhd+kEwsjqYjDX+OXVYCKn+wP/7O/KuBU2To+AqJeF+up66H3/Xkfep1ZGjgpdv8+CAwAwceJVg89+qVWXS/ceMI J8G+FgqN upBhxP+3atYJfybfLI7l6rlrdQrAkCoDiyvgvCXh/dsCNga+sDhgaNO10U4Qrtlpwxsa8o4X3f+IQ3Fe8OVdF3VZcPWkZFgww5OpK X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 23 2023 at 19:33, Thomas Gleixner wrote: > On Tue, May 23 2023 at 18:24, Uladzislau Rezki wrote: >> On Tue, May 23, 2023 at 04:02:09PM +0200, Thomas Gleixner wrote: >> mm/vmalloc.c: In function =E2=80=98_vm_unmap_aliases=E2=80=99: >> mm/vmalloc.c:2220:19: error: =E2=80=98struct vmap_block_queue=E2=80=99 h= as no member named =E2=80=98vmap_blocks=E2=80=99 >> 2220 | xa_for_each(&vbq->vmap_blocks, idx, vb) { >> | ^~ > > Duh. I surely had that compile fail fixed before I boot tested that > pile. And then I did something stupid obviously. No. This one not. I only had the one in the last patch (missing force_purge argument) And this one makes me scratch my head: struct vmap_block_queue { spinlock_t lock; struct list_head free; /* * An xarray requires an extra memory dynamically to * be allocated. If it is an issue, we can use rb-tree * instead. */ struct xarray vmap_blocks; }; So how can your compiler complain? >> mm/vmalloc.c:2220:19: error: =E2=80=98struct vmap_block_queue=E2=80=99 h= as no member named =E2=80=98vmap_blocks=E2=80=99 >> 2220 | xa_for_each(&vbq->vmap_blocks, idx, vb) { Mine does not, but I might be missing something. Thanks, tglx