From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD828C83F11 for ; Tue, 29 Aug 2023 00:51:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 33256280028; Mon, 28 Aug 2023 20:51:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2E31F8E001E; Mon, 28 Aug 2023 20:51:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1AA32280028; Mon, 28 Aug 2023 20:51:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 06D658E001E for ; Mon, 28 Aug 2023 20:51:49 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 97EE412059B for ; Tue, 29 Aug 2023 00:51:48 +0000 (UTC) X-FDA: 81175314696.09.B090CA7 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.126]) by imf28.hostedemail.com (Postfix) with ESMTP id AA512C000B for ; Tue, 29 Aug 2023 00:51:45 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=ioCqRA6J; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf28.hostedemail.com: domain of ying.huang@intel.com designates 134.134.136.126 as permitted sender) smtp.mailfrom=ying.huang@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693270306; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DmYKTPJQQ/1/b2qMHBNsrpO1b0SIkShbuEuUs76gVbQ=; b=JaE77dBvFKRU/JSNdPni4OkYnFl1yQPLKMIDQqUXmJNnzCzJCiuVthsFmBf463gkut7Jws xKnEn+p8F3/qP6jp6Lg52hzQfBKY0PSoljFpHy1xmIeDWhXbHYA0yR2cmm6n4xcPg8+Ey/ St8k7ICHtIeJCnyIzF8ppUpBhoYjjvs= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=ioCqRA6J; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf28.hostedemail.com: domain of ying.huang@intel.com designates 134.134.136.126 as permitted sender) smtp.mailfrom=ying.huang@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693270306; a=rsa-sha256; cv=none; b=p8zipdV8QI01WdOQ4duFqFsypArJ7oJvwRYFOkBUHp/rOEPGCvcDkfnrlMyZUnRO2I/3r4 YyCGp4uSgzZHrzZKEERE+umUIxGTykhGb/kwjLVj6WtlTRm+wMHBctyGQk3Ai5x5p31iCk eRZezz1KdsSzrtSxbcwt7Gox7BFQ0eE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1693270305; x=1724806305; h=from:to:cc:subject:references:date:in-reply-to: message-id:mime-version; bh=ckp+5w39kYKdx5CWCnGyq18yY6y/3olG4Ys3T3fGb0E=; b=ioCqRA6JkgNjhrDixLW3Od8bXehy1bkrls8hCcqsyLUDcZzCt28BVnj9 OR8R4YEKVb3dljPxX+uDkzx09aOpAnUSqFs6Sxba+QUqpginoUAsIOM6G K2rKZUSKTf1Bs1dFNTPMeMNtnx7Rh6tVwlz0zwLJuVMBI7tlFe4nAINRy l/S36aRhzzePP8YeZ1EfXkkHlVgcyOehpkmJm7VfG4kcKJLTyz2+3SmnD 4darYYOLmwVXhnzPWmxlJ17mHQDIrmfZ/XZh/2/iCpO4yB+PofEHOmUoy Mlm7bGM4zySslYaKSnyyphCyktoenBu+k8tT3bjN7HeDPSndF6LpjoYfh Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10816"; a="360248546" X-IronPort-AV: E=Sophos;i="6.02,208,1688454000"; d="scan'208";a="360248546" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Aug 2023 17:51:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10816"; a="688308431" X-IronPort-AV: E=Sophos;i="6.02,208,1688454000"; d="scan'208";a="688308431" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Aug 2023 17:51:41 -0700 From: "Huang, Ying" To: Zi Yan Cc: Kefeng Wang , Andrew Morton , , , , , Mike Kravetz , Subject: Re: [PATCH v2 4/8] mm: migrate: use a folio in migrate_misplaced_page() References: <20230821115624.158759-1-wangkefeng.wang@huawei.com> <20230821115624.158759-5-wangkefeng.wang@huawei.com> <855536BE-766C-49B2-B358-6C0548760929@nvidia.com> Date: Tue, 29 Aug 2023 08:49:31 +0800 In-Reply-To: <855536BE-766C-49B2-B358-6C0548760929@nvidia.com> (Zi Yan's message of "Mon, 28 Aug 2023 10:10:25 -0400") Message-ID: <875y4y65b8.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: AA512C000B X-Stat-Signature: i6xbj4gzxmxjijphpjq9kcdgqzfcjg68 X-Rspam-User: X-HE-Tag: 1693270305-132567 X-HE-Meta: U2FsdGVkX18t8jcQRqiES0buIwR++gNVbL/aY/XvtuAiqjt+MExC+0srldxGk1Ni5gAHFtykYNRi/8zVW1CP3NJjZhcJ1RnOloS08I89wbsGZuLrhTVr1WnIvJRoCrUeTT7/lhjNI3gxm41Q7swTTYZFsUXwrYl5dS64Ct2byPI0f/xAGLhxX/4R+2pSVnQtVYQZ8CT8oGlFpf5UElc4xUDLcTrTBmXf/m7JraBmYY0dzqxwW0H7p9sZnWzTUBFfbUnHD/PwQeaBhwJMiFzgwH3tsTcS1Z/rUZjO2Jq/v/FPmUj3MzjfEXGbEaGbFullXDClG6traoSi2M3PuZ7sYU9jCN8IhiqhcH9LNwz+v/dnWeqlNjyPLEPEzOkGw911AjM6G4GKhtv03XxBrY7P8crjfUAkqDaxYksauVUMvGbp/9Tk1b+PhAWwUM/qwISeOqPIlJx5TBxIWhf8BPsgjrbSjv44NhyedI8ozLHWrAJwMKJCUTo0dmjZzteefsayzpNxH15cy1Hw56MiCpRiVW4Z5IVhOxnGiumayb5Buz9EkINuHYwonWtazZtKRFMZ4JONFLJopYPPOwRx4fFtqTjLV41T6c6/o9G6ZqGn4VErUPpX6ZHMvCXWRvLS+MP9bb6hTxCq1e9jKrmUZ3y/YOXXzp6S1LQHDWKvlvXlGK7uyh2Z0Dhi//JKTZpZ7e+br74PGwfCFNt/wjzEYUBBx41KETcpMZJ1cSYsQmCGgzfEsMi4adsPYVsMDc3QLfnOnmuaC5bojRDgM6jUEAmnir655MHSd1vRpPa1y5P6QEfgKtnfDxaThUVdK5PTqhZ6NGOoePYJFrnOHLZ1s87mpGsnZzg9HqEMcwwI+5WHxra4Fa7BwVxLzV9yzUQ36zpADX+f6NeCuqVozGb9iaK5Hz+bcNIlhvj+DK+RIs91ErdyNVd9KchLfqR73F0E9/0L+d8eKPrG1XhDYhe0s+c dqw5qgBT RjeCxW8secR8hNqoBA1uyxvBNuAgUjzLj7JlQhK4xlISSPvsBvmXelvajgYFxn56iv2bK/qT5t15IypAMPeDzOOdt0OZ5T1siL22TMFEA//6Hw7dxsNZ+SNcZdA3xIl9wavP88JAdhHAKUrdIWkrfPC0FMwveppK+pUZDhw+ZWjWEMom/MPZhF6O+Cz6FBn2Vjayf6ZSNdc2YpAMWXxrm+quOcvUY714fMpXuNmX0LLEpGphg19ziDh542g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Zi Yan writes: > On 21 Aug 2023, at 7:56, Kefeng Wang wrote: > >> Use a folio in migrate_misplaced_page() to save compound_head() calls. >> >> Signed-off-by: Kefeng Wang >> --- >> mm/migrate.c | 23 ++++++++++++----------- >> 1 file changed, 12 insertions(+), 11 deletions(-) > > LGTM. And a comment below. Reveiwed-by: Zi Yan > >> >> diff --git a/mm/migrate.c b/mm/migrate.c >> index 281eafdf8e63..fc728f9a383f 100644 >> --- a/mm/migrate.c >> +++ b/mm/migrate.c >> @@ -2521,17 +2521,18 @@ int migrate_misplaced_page(struct page *page, struct vm_area_struct *vma, >> int node) >> { >> pg_data_t *pgdat = NODE_DATA(node); >> + struct folio *folio = page_folio(page); >> int isolated; >> int nr_remaining; >> unsigned int nr_succeeded; >> LIST_HEAD(migratepages); >> - int nr_pages = thp_nr_pages(page); >> + int nr_pages = folio_nr_pages(folio); >> >> /* >> * Don't migrate file pages that are mapped in multiple processes >> * with execute permissions as they are probably shared libraries. >> */ >> - if (page_mapcount(page) != 1 && page_is_file_lru(page) && >> + if (page_mapcount(page) != 1 && folio_is_file_lru(folio) && > > page_mapcount() is not converted, since folio_mapcount() is not equivalent > to page_mapcount(). It can be converted and this function can be converted > to migrate_misplaced_folio() once we have something like folio_num_sharers(). It seems that we can use folio_estimated_sharers() here. -- Best Regards, Huang, Ying >> (vma->vm_flags & VM_EXEC)) >> goto out; >> >> @@ -2539,29 +2540,29 @@ int migrate_misplaced_page(struct page *page, struct vm_area_struct *vma, >> * Also do not migrate dirty pages as not all filesystems can move >> * dirty pages in MIGRATE_ASYNC mode which is a waste of cycles. >> */ >> - if (page_is_file_lru(page) && PageDirty(page)) >> + if (folio_is_file_lru(folio) && folio_test_dirty(folio)) >> goto out; >> >> - isolated = numamigrate_isolate_folio(pgdat, page_folio(page)); >> + isolated = numamigrate_isolate_folio(pgdat, folio); >> if (!isolated) >> goto out; >> >> - list_add(&page->lru, &migratepages); >> + list_add(&folio->lru, &migratepages); >> nr_remaining = migrate_pages(&migratepages, alloc_misplaced_dst_folio, >> NULL, node, MIGRATE_ASYNC, >> MR_NUMA_MISPLACED, &nr_succeeded); >> if (nr_remaining) { >> if (!list_empty(&migratepages)) { >> - list_del(&page->lru); >> - mod_node_page_state(page_pgdat(page), NR_ISOLATED_ANON + >> - page_is_file_lru(page), -nr_pages); >> - putback_lru_page(page); >> + list_del(&folio->lru); >> + node_stat_mod_folio(folio, NR_ISOLATED_ANON + >> + folio_is_file_lru(folio), -nr_pages); >> + folio_putback_lru(folio); >> } >> isolated = 0; >> } >> if (nr_succeeded) { >> count_vm_numa_events(NUMA_PAGE_MIGRATE, nr_succeeded); >> - if (!node_is_toptier(page_to_nid(page)) && node_is_toptier(node)) >> + if (!node_is_toptier(folio_nid(folio)) && node_is_toptier(node)) >> mod_node_page_state(pgdat, PGPROMOTE_SUCCESS, >> nr_succeeded); >> } >> @@ -2569,7 +2570,7 @@ int migrate_misplaced_page(struct page *page, struct vm_area_struct *vma, >> return isolated; >> >> out: >> - put_page(page); >> + folio_put(folio); >> return 0; >> } >> #endif /* CONFIG_NUMA_BALANCING */ >> -- >> 2.41.0 > > > -- > Best Regards, > Yan, Zi