From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D4C5C25B78 for ; Thu, 23 May 2024 01:16:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 049A86B0083; Wed, 22 May 2024 21:16:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F3C2D6B0088; Wed, 22 May 2024 21:16:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E03036B0089; Wed, 22 May 2024 21:16:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id C33176B0083 for ; Wed, 22 May 2024 21:16:08 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 3C716120261 for ; Thu, 23 May 2024 01:16:08 +0000 (UTC) X-FDA: 82147894416.03.855A0E5 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.14]) by imf07.hostedemail.com (Postfix) with ESMTP id DC45C40010 for ; Thu, 23 May 2024 01:16:05 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="aMGdY/YU"; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf07.hostedemail.com: domain of ying.huang@intel.com designates 192.198.163.14 as permitted sender) smtp.mailfrom=ying.huang@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716426966; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cM5crLpeBzt7kzCfWBvcR1h/SUJdpH6fGIkEsHekWNE=; b=UX/V8Ya1gQhrryeyrqvy4jhMpHyq3dGFbIOq3GT1beymKiLcXqC9IofVIsY/8HRkqzyDLn W6NGZ4kU+GxSlw6gHHyeXu7JYqn/Yj40w5wST8ILQCUYvxF3iecslgv+86LZ1U3/VcAgd6 /BVMY37Ivt9cQXPBeGa2dv0H1+nf77U= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="aMGdY/YU"; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf07.hostedemail.com: domain of ying.huang@intel.com designates 192.198.163.14 as permitted sender) smtp.mailfrom=ying.huang@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716426966; a=rsa-sha256; cv=none; b=0w/OCwPr32//pY+AZcRzzjNuEHOQLXm2hvtnMS9Yv1m6DmufUIignDaTCkxl2v6o2FONXb LljGafkIl8FITdICJeXdkyxL4Ax7i/KsD+ZjEZfEdLTdx9IqRC4ameYZ+KAmMdY25dlwsD E+UTX0fFH/cs81i700M2H/HD1/gVrVs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1716426966; x=1747962966; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version:content-transfer-encoding; bh=CcmpbpVJhasgLmfwQZTQL9+xSZY9u/4K8p1LLNjO9is=; b=aMGdY/YUYjUCDKHK+tqLiUsSu9RF8YDO4ntimTbcDd0ZWkkvkXj8gE2R /7ZxewDvcTPnNiv/lQVB8aGULe+wgBeDv8fpAWz97D7g28mnyKp26VxVk dFZGs71gzcmrTTX0BWCrsD5rjeHAb4ka8NzRkI3y4l+oHHWVCrzDAelZb tflPLe9D3poPjEr9UxUKMFHoft0/xf94RbrJwdt/QdGUOySBw4YkUJbn1 DnJg1iNlqlgADwORytzTpaA4pLKA4WcOkEuM50Q4WQaTF1yc2tVAn6BfO lg3BLN0DiAZTxkWmqQVHUOGqevLcW8JbqpPx9HKVe8ZX5OYA0sq25UyZQ g==; X-CSE-ConnectionGUID: 7wWNWaaLScOCL9zLzbeUOg== X-CSE-MsgGUID: VIXoqhVjTDmxW0KRJwFu/Q== X-IronPort-AV: E=McAfee;i="6600,9927,11080"; a="12945509" X-IronPort-AV: E=Sophos;i="6.08,181,1712646000"; d="scan'208";a="12945509" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 May 2024 18:16:04 -0700 X-CSE-ConnectionGUID: UCpiy+V+RKOtiYFej2ZQHQ== X-CSE-MsgGUID: TeAwZUKuRM6ypEBLA74fXA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,181,1712646000"; d="scan'208";a="38325908" Received: from unknown (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by orviesa005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 May 2024 18:16:02 -0700 From: "Huang, Ying" To: Barry Song <21cnbao@gmail.com> Cc: Baolin Wang , David Hildenbrand , akpm@linux-foundation.org, willy@infradead.org, ryan.roberts@arm.com, ziy@nvidia.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: drop the 'anon_' prefix for swap-out mTHP counters In-Reply-To: (Barry Song's message of "Wed, 22 May 2024 22:40:20 +1200") References: <0e2a6f232e7579a2e4407ecf075531980d97f286.1716367360.git.baolin.wang@linux.alibaba.com> <22ac01a3-ddbb-4114-88cd-ad1a31982dad@redhat.com> <51ba1fc1-fd77-4601-8d27-459162fd008c@linux.alibaba.com> Date: Thu, 23 May 2024 09:14:10 +0800 Message-ID: <875xv5ba8t.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: DC45C40010 X-Stat-Signature: zkownswr194z6gfukxwzpbdoru4qtxen X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1716426965-1669 X-HE-Meta: U2FsdGVkX1940j4HpDcsrV3opx5HPzyM4HLenkRs8bPGZXdNPN2dPv9bPbUgUUUt94DtfvYMXrLiyKY/ix9XXm4sso+W9/WnSEfnYSrYV1GwdOKw4lZa3RjKjydlZs/GA4bEJjz0M/+dMzV4VAmZ7Ui0nheZwIvdW1ka1EnL6SVaLR32jHwOm0zTaCFXhWuHsluRqgOe+nB91FXpwJeuBkqCzLr2ArqkgjG+atdS+Cmom14zJo60Csq2ZC0oMpfSM24Qft/YJSVl2zr1ir45FZg4fOeLXbmhXpLMbeLlrrAx5uzS97YE96EnoTuf76NGnmQyh+j4UgWEHDzo4az+Qz8HYLDF098XtoVDcI2RV/eZdmP2mD1S0Y1cCPwcI1vE7Li44MT1dwDYQIHTtkr6c37n0w6UnNg61T6SG4u9h2Zl6keY8+rrIuQB+sRH2+jJ9MDHlhX1wYgrRkxJHIQc0LUtjc4AykKfaGtm1+9ejUwXJ1iQqxMwT9ZaxAUSz7PJ3ALl9AJjWvWepAK3pvIDIpMlYML+oIYryrotaiTsEt1N/iNdkZrEpWJdsnRA7qc6gYwBhiOZ6X4YgssGj4MarEVAxzQHo58X/ekipPqp28Txz3FS0Obt1hgh+JvwkBUmfgjnz35wnUnqC96TFYCB7lGVOnlsGmOR/u/ha7F77SRqX8pqbHx9jDXrxypI8B+F/0SgYvaeOxqTMx/wgkusiqeT7mQEmUbEx3dtyVou7tlQ651kKhvL7ZAiy3fbe4YR8Q/K1IejrI18pxNYM8ycIfERK9pWFX2fWmayy1eLNBZve7Zi1QO1TJFrAEYOFbzQ9RuBSM6J9An1j+rJ/+Dv1VH8hK/rKNwSigGklUAqLTbzjisOfxUu0SxR+eB1yCLCX6Ig04NvxGrCk2VnRAFK9PSLdB1yeOgtEayDNd3gxfVR2KhiHl4pySztOi4FHfIG6d9qdPhckvMEGOofhqW EiC7Ibjc DslObZWhTog6fxQ8aErSzGVyIR5tt2Znd84XYVOvM7GM4XmxKYL9wGXOogT4YdiBzyTxEk/nDALuHLagtxVgMghc8A+O+poPQLS1IrcobNfS99V7D65z5M5wZzgk496G0VRjqplI5QsaZixa/Sdg0g+SkdZf1mkgZZbOUfk5gLGNAaleBgprRhRO9b4R1Up8XnzFMDU/303glPW2V+Z7Y9puvRqOA0ePEvgW2mSK0969hZghX5IVx5FvQ2OdhZsl/Innv8uPNAQ6opAOQUqtbVtDOyXjxmQRcq1/9pvfTHZHtxyMKlR4kAUlTx8BWaMarlwgCGW6UOz+iPpqIREx0PRdqWrgfK1Mj9YKBVmVxN1M9KO2Wr7HhjIkGsw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Barry Song <21cnbao@gmail.com> writes: > On Wed, May 22, 2024 at 9:38=E2=80=AFPM Baolin Wang > wrote: >> >> >> >> On 2024/5/22 16:58, David Hildenbrand wrote: >> > On 22.05.24 10:51, Baolin Wang wrote: >> >> The mTHP swap related counters: 'anon_swpout' and >> >> 'anon_swpout_fallback' are >> >> confusing with an 'anon_' prefix, since the shmem can swap out >> >> non-anonymous >> >> pages. So drop the 'anon_' prefix to keep consistent with the old swap >> >> counter >> >> names. >> >> >> >> Suggested-by: "Huang, Ying" >> >> Signed-off-by: Baolin Wang >> >> --- >> > >> > Am I daydreaming or did we add the anon_ for a reason and discussed the >> > interaction with shmem? At least I remember some discussion around tha= t. >> >> Do you mean the shmem mTHP allocation counters in previous >> discussion[1]? But for 'anon_swpout' and 'anon_swpout_fallback', I can >> not find previous discussions that provided a reason for adding the >> =E2=80=98anon_=E2=80=99 prefix. Barry, any comments? Thanks. > > HI Baolin, > We had tons of emails discussing about namin and I found this email, > > https://lore.kernel.org/all/bca6d142-15fd-4af5-9f71-821f891e8305@redhat.c= om/ > > David had this comment, > "I'm wondering if these should be ANON specific for now. We might want to > add others (shmem, file) in the future." > > This is likely how the 'anon_' prefix started being added, although it > wasn't specifically > targeting swapout. > > I sense your patch slightly alters the behavior of thp_swpout_fallback > in /proc/vmstat. > Previously, we didn't classify them as THP_SWPOUT_FALLBACK, even though we > always split them. IIUC, "fallback" means you try to do something, but fail, so try something else as fallback. If so, then we don't need to count splitting shmem large folio as fallback. For example, before commit 5ed890ce5147 ("mm: vmscan: avoid split during shrink_folio_list()"), if folio_entire_mapcount() =3D=3D 0, we will split the THP. But we will not count it as "fallback" because we haven't tried to swap it out as a whole. > > if (folio_test_anon(folio) && folio_test_swapbacked(folio= )) { > ... > if (!add_to_swap(folio)) { > int __maybe_unused order =3D > folio_order(folio); > > if (!folio_test_large(folio)) > goto activate_locked_spli= t; > /* Fallback to swap normal pages = */ > if (split_folio_to_list(folio, > folio_list)) > goto activate_locked; > #ifdef CONFIG_TRANSPARENT_HUGEPAGE > if (nr_pages >=3D HPAGE_PMD_NR) { > count_memcg_folio_events(= folio, > THP_SWPOUT_FALLBA= CK, 1); > > count_vm_event(THP_SWPOUT_FALLBACK); > } > count_mthp_stat(order, > MTHP_STAT_ANON_SWPOUT_FALLBACK); > #endif > if (!add_to_swap(folio)) > goto activate_locked_spli= t; > } > } > } else if (folio_test_swapbacked(folio) && > folio_test_large(folio)) { > /* Split shmem folio */ > if (split_folio_to_list(folio, folio_list)) > goto keep_locked; > } > > > > If the goal is to incorporate pmd-mapped shmem under thp_swpout* in > /proc/vmstat, > and if there is consistency between /proc/vmstat and sys regarding > their definitions, > then I have no objection to this patch. However, shmem_swpout and shmem_s= wpout_* > appear more intuitive, given that thp_swpout_* in /proc/vmstat has > never shown any > increments for shmem until now - we have been always splitting shmem in v= mscan. > > By the way, if this patch is accepted, it must be included in version > 6.10 to maintain > ABI compatibility. Additionally, documentation must be updated accordingl= y. > >> >> [1] >> https://lore.kernel.org/all/05d0096e4ec3e572d1d52d33a31a661321ac1551.171= 3755580.git.baolin.wang@linux.alibaba.com/ > -- Best Regards, Huang, Ying