From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39B54C2BD09 for ; Wed, 10 Jul 2024 01:06:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 047746B008A; Tue, 9 Jul 2024 21:06:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F38986B008C; Tue, 9 Jul 2024 21:06:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DD9146B0092; Tue, 9 Jul 2024 21:06:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id C02D76B008A for ; Tue, 9 Jul 2024 21:06:47 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 6457916198D for ; Wed, 10 Jul 2024 01:06:47 +0000 (UTC) X-FDA: 82322053254.10.CC3482D Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2088.outbound.protection.outlook.com [40.107.93.88]) by imf13.hostedemail.com (Postfix) with ESMTP id 9337320011 for ; Wed, 10 Jul 2024 01:06:44 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=HdY8Zb8Q; spf=pass (imf13.hostedemail.com: domain of apopple@nvidia.com designates 40.107.93.88 as permitted sender) smtp.mailfrom=apopple@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1720573588; a=rsa-sha256; cv=pass; b=NCs5CS5uZXXCakAdBYml6M/VDgMh/beAz+0dO+JTSlX/TbQoY6hpbKJn1tzGu1Np6UJuyV JGl9vanGFd5q5aRaAnbcFazudzmjCaPWFjC4LL1DGtybhrh5UaYpONrFdexJlf2f6IP39n 0MHDNUEZf1wdbKHDYh5zpwWvTD3yOjk= ARC-Authentication-Results: i=2; imf13.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=HdY8Zb8Q; spf=pass (imf13.hostedemail.com: domain of apopple@nvidia.com designates 40.107.93.88 as permitted sender) smtp.mailfrom=apopple@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720573588; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ev/DbwUoJjM+VHQ1HVoQZlyBa/flmbVG8T8PK0CcWSc=; b=2wxBiNDwF/rJFjTNv/n1DqQTxCyIE4Qr1zf/LHmrDADZStQW2za9yTPGyYmptRJJwE3sKo /1xtl8uDf58ZfqlcyLjDwldMO1oHZCtqPByvKeX5rVX7Itoz0Uw72nmsF+JU+67I5tNxMg C+DZoBomeX+a6wqb/HpSsxdTCbgZmJM= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=M3X9XEcucSgAm098xqRpfcj6nHgT6HBdu06D2SiBE/OcRglLEJfD7FoWMxQwUK2FqNjept0Lv09b9eIYR0yhNx6CA27aeCbxRlMRTZruY3KTsxdOBt3UolwMFsoPiBbSfgf3QZcmQ4WkL5+im+OwU+kcPUnwRN3nC7sJ9HSWyfJXMDCwDov9djBbgGVv7Doo+ouBH5XXELW7MVWbpcKau0QEAuXbJc5vLOhRQxGmW5sgCv2wp1KFMkkLv5sRVlmvuah1CaGslY7+/XzVEgD5f8N6FQ1Qa88N8aE/RKAmyFJLrYRRnocgIlYDMuZSj3V47Q0P7gcaod3zWbtoCJxW0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ev/DbwUoJjM+VHQ1HVoQZlyBa/flmbVG8T8PK0CcWSc=; b=VPYUlQEWDqCr5QUKm4PVRwA/6gOKn9xduwizmAo9vXtYAZDYgngWBXykhfA1JlEXj75m8btjst5ELfpxshix1W2CC+jXJ7quMZN83I0+tkc9i9BoQoNT2A8D0pmTNPhhlTXSpBcZ8w1x8Cw3qedSNKgwZqjah9hhkPvj7R47uTo2NmmR7B6VLs6hWdADa4Qw9+yPV1vBEg7H2g5TIxIjx45iGv4eDt1j3I3855dsExnV8l4pYgERicHCAdhg7WbnxgaNRdcrpbZQi+uDCtNm4OLzV2EA/M7+koMqjrrGCS4Ijs+Zxqgc+97Fjcgb20u8ZGzA4rVeJVSMq9mdJz0Zcg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ev/DbwUoJjM+VHQ1HVoQZlyBa/flmbVG8T8PK0CcWSc=; b=HdY8Zb8QP9/ETiv7+4TZMv+nDUyT9bytM0N2hQj5mgCHvVG/H2/6YUQH9oFKc/nAAotUvqea6roCmUVDF/x3jUioy9F1pgbO4Ya0YIFcpFOnUjPNsf03NnaeOMrFvbUlf16lTKvPieulfjEKLCTGp0NBAPYh6iTrr1E9xtYsDC0dyDw0ksiytLs5d51Th2uXRtrxZQtpu8PDthQfXbHpFFtimeTZU9qGiCC13cLLcmfSVUPmyjyigvcyMS/wVCrIEhH7jxJGP4GvE2Qzg25BfZOzpOl9p9UMB6kqQPtrphMTcagjNxxKw772DncbC3y3PhdoUaLRLtrQvY9C1xHGlg== Received: from DS0PR12MB7726.namprd12.prod.outlook.com (2603:10b6:8:130::6) by PH8PR12MB6913.namprd12.prod.outlook.com (2603:10b6:510:1ca::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7741.36; Wed, 10 Jul 2024 01:06:40 +0000 Received: from DS0PR12MB7726.namprd12.prod.outlook.com ([fe80::953f:2f80:90c5:67fe]) by DS0PR12MB7726.namprd12.prod.outlook.com ([fe80::953f:2f80:90c5:67fe%2]) with mapi id 15.20.7741.033; Wed, 10 Jul 2024 01:06:39 +0000 References: <20240710000942.623704-1-rtummala@nvidia.com> User-agent: mu4e 1.10.8; emacs 29.1 From: Alistair Popple To: Matthew Wilcox Cc: Ram Tummala , akpm@linux-foundation.org, fengwei.yin@intel.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] mm: Fix PTE_AF handling in fault path on architectures with HW AF support Date: Wed, 10 Jul 2024 11:02:03 +1000 In-reply-to: Message-ID: <875xtevyw6.fsf@nvdebian.thelocal> Content-Type: text/plain X-ClientProxiedBy: SY6PR01CA0159.ausprd01.prod.outlook.com (2603:10c6:10:1ba::17) To DS0PR12MB7726.namprd12.prod.outlook.com (2603:10b6:8:130::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR12MB7726:EE_|PH8PR12MB6913:EE_ X-MS-Office365-Filtering-Correlation-Id: 5f51fc75-c53b-4ec3-abee-08dca07c8dc0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?XZfwbNfslaL7EvSR12me2hYWfcZ6yWsUVQLov2kQUD09AiuRMrN4OrojQvJe?= =?us-ascii?Q?oaNYISe2qY4+KAOJH2Y1DVaeiNw+MTglkFb3lMRdD+td87qJZ1/Btj00DYNk?= =?us-ascii?Q?FrMLuGo+Ak014/S2ibQqroZ/0AGs1Pymwwlczfwr8Bodk7hlcGvqNm4S4vIO?= =?us-ascii?Q?QrktRJSVnlz90oPlCSP02/3HDyV8CZsYPGdLNEqZRYF4GFtY/D9vSnl2Rr6C?= =?us-ascii?Q?by1hgZ72VKCLE+pWRoFIMN8cYUxJaOek4n08DGYw+luTLIALYqAuHwYWXxah?= =?us-ascii?Q?BR10Rf0/0TMKerCY+OKFzuQGTsOF3zclz6PKVM3kdswjzJ9yiOobmRnYRani?= =?us-ascii?Q?OJG4LK1FahO+ButvDW10f4A2MdzBs97iL5v4HSUgAL97NuTtOakqLqvlKiW+?= =?us-ascii?Q?19P0yPUQDBWOooPeF3dRU7/sBJIY52XbYtmnFlHxMmyCqloAdSjzSuyPupPZ?= =?us-ascii?Q?ESp0XEl35G3NSMyxmbc5ZKa14l7mxdzFD5w+HiOIpLOa85k7opbE/LeZrnr/?= =?us-ascii?Q?gifPFWkyzmxpqD+aiMm/7bAN6++ZzH73APtLyhZGUclNzVlRvlnX8qqAPcZh?= =?us-ascii?Q?SZ5KmRMOCTHY823EsXqg4EwvotHnZiNsJkAVysnpubt7fZBotrz+95IsnPFk?= =?us-ascii?Q?TKuLbKGvqBP1OunWR1+ZqULKaXa0DbVCrspuwufUGDrHRrWlThjkfWRn9MoG?= =?us-ascii?Q?D55xuhq9cDgGBQrXYe3wrATETVcbBdRX0bUSiEhO2XpOb2YtwXauU3SVV42i?= =?us-ascii?Q?YMLU2icQQ9z8RTt0L7Y5JAF/AqydB9RIX2my/p6u9DrDTMjMtG9MFGmTLlOO?= =?us-ascii?Q?7UIpEIGcsGAgFRQD3sYnepEdtU05EFtnwYF6ItjjDkDwude7zqkrgbrBeErx?= =?us-ascii?Q?fWM0aX9EBdP9SliXRcpnB4Rkx2GwgdXfnbI0YpH265lYl2PuRlxg8jrac+SK?= =?us-ascii?Q?/t1dbOPD1bt0Uq2CNNJcDW0XyD/tYq7GH6TsT5eD6Jr8bcR7/cq3yOELfyql?= =?us-ascii?Q?n9hjKKdhtzUxgzt0s+6Mtf9WwYI1LtTwkvOcHzJS3HFy3D34L6tCiClU/LVX?= =?us-ascii?Q?UxO1bZz3fRokL7f/EwW+/qRcLwGO9QKxmsz/vrOuR1F1S+YzrEsBp+o4ZyNa?= =?us-ascii?Q?qCDLpr6UiCQeq0NF7/vrP5Md5CfsQe4NhfPDr3WxL/1nUFxt3bclIOW2ghuy?= =?us-ascii?Q?Ksrwcy7KzlWVqUOfH5gRIF5RIic+eYiZOni9yni9PSTdU7GE1Ch5EPMSE81F?= =?us-ascii?Q?NYm03ZJ5RiSKDq0iobYYNCXh3z/XUuTzzW8nN/D379PGx7mNwwOhnFvZ15dM?= =?us-ascii?Q?XY2JBgCzQ4lmNf5b+EvhOZCLGWSpxBqkKpr3uNv+M1j9aQ=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR12MB7726.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(1800799024)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?SHNib+deeP+WdpSOG/jj/AAjTAYX6uhx7483gIgT6OI7EA57J2OampIrFJx6?= =?us-ascii?Q?QmEUzAPLuMYGbD5GRUB2zJ5FgDV/ihLMIixlbDfwZQGBYwHhDuA7gxi9X7+p?= =?us-ascii?Q?atnQkjWbxHWRj/KZaxbRglBL8MRolewffjDowwElnbB1hE3REhtcVZYvaPkz?= =?us-ascii?Q?0ePFULU8eWh9Lh3MVxuhGOWfRCEZoeoSBzZ64DlgAAsDHfOa3MBu5rotRPs8?= =?us-ascii?Q?J2CRFGhLgFtK0RjYNz2XXy+voJgfPM19j71yXRbdryBw2N5X2vtqWwvrRtof?= =?us-ascii?Q?RMts4UQKSxUg1LcvWH7VTUorhXHLiBJU8A9isBBthK45/TiniCYzUTBLK15j?= =?us-ascii?Q?tQOukHrQ/7aSyFwVXZehv81e8eGI8v2wL+mXFwjhC9Bd0+vm0lxk5/obT7QR?= =?us-ascii?Q?xLpgfeyUw7CSJGFyR+il3mIqJOHHLWVZU5BmKKNLuU1bbGhOXcfgLQg2oGhq?= =?us-ascii?Q?FRLgJTAUCFaR9vvozhOXjN2ykciWAhziAhS1TqZJv3l3nfGwR7w1HbaSeRjm?= =?us-ascii?Q?97EZbPd1G2lGZHMiQtgmP6OO0EvsCCtIAIJyJ7Bqa/S9ggG6K3wGCJt4PGK6?= =?us-ascii?Q?HZm3udvpAJDzGRHTq7qgbjTJFMHNFixR/kZBmSjCJQWmx4ja/5fqW9ka5yX2?= =?us-ascii?Q?uzAl0BICp3OUdw9jWnVS+TI/AiC4rnoOXSUIPsbchS5so4y/V8XYWr97W5C2?= =?us-ascii?Q?uJNiqjQiSCi3Q7YkjQnbPL6S4t/QtBy9JDv2YI86szPFPo9FWdBlVvt9kWfm?= =?us-ascii?Q?mLPF3g0OSz7/RL9UJNmPs3VQFSV3qrTkqhP3rFiOQhQ1oEOdF1hQVHlbhheU?= =?us-ascii?Q?2y+LJCe7K+VBHBsJmEL5cgXWqqkGU6BrWqcM3gsPYlUoUOIhXq3NwIAKcMqu?= =?us-ascii?Q?mzvLfIPiA+8tbA+i4OrqaRVIen2+4fi9q+na5bV3YltqC/szXJlE/FKG2dQ2?= =?us-ascii?Q?2C5EU9J7rivHOkQDcwbBClE6o3S83TnQIN9SkNf137lT0loFW9k1NWTehr4K?= =?us-ascii?Q?Njyq8un4/zk/x511sLPYzI3BV4HBBCQIgQ8ykSLb3yFYAlKt2O2abKsUvWkg?= =?us-ascii?Q?vy2iKROQliNzNYY9PP52TUqDtmCTvrNp62t0pU2Y3NcgJCcKmN+10/uynIsH?= =?us-ascii?Q?xvN/+QNvHW1q6BzpVcKv+kJxAR02TUJDu+jUXM2eXyaLix9E5YFmnAeV7x8F?= =?us-ascii?Q?rRLDj1yp9ihmOV6DL2lkotooc8R9PNU7iBIZuPCJSM6sXQaVlnkvprG2ktgY?= =?us-ascii?Q?JYeMhfhZcIdDBHqwgYu3+Wp6TSC3U+pfx/4wQ6Bqo3c8vsOtjhrCakPClv0U?= =?us-ascii?Q?dL+N9A5uQDTFPMUrUuCGOgnerqMQdEXauCQHbSSTHxY7hdeLO24cUR0TkKsz?= =?us-ascii?Q?WzkGxkiH10SXCkNJjVW3StkZ2DrMEzfcTFvRO8yUc+52X2RqH4ZoBxROpf9V?= =?us-ascii?Q?RVB6u5mz41OYB+Jw5FXm/V7kTCskq1PojxDzAncqF/YtlozyBKUZJltWOv9E?= =?us-ascii?Q?xqt25BIuofb59KoOuQLU30pCpZszRywmF/7Fo1iK1dEAxgRJYVkQKSDalyPh?= =?us-ascii?Q?1HZwALC5u630i/Pgp3IjeJ5hnj0L+dewCRnTYMJI?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5f51fc75-c53b-4ec3-abee-08dca07c8dc0 X-MS-Exchange-CrossTenant-AuthSource: DS0PR12MB7726.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2024 01:06:39.5638 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Gu677zx0JmrQ+5c1ppsOXbW6AmXdNVNBvkF6pyeDVUx2WbvvnOrHikOSAborOi/nzVbmhO4/PhEFJF2o/fYS1g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB6913 X-Stat-Signature: e6itkpuq44arz53e8hxc8e9dptcuqc5z X-Rspamd-Queue-Id: 9337320011 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1720573604-95123 X-HE-Meta: U2FsdGVkX19EsNgY0ARRRsAW/qFO8jLFpcBVOl6olmaqbUTUG/aRZAYNoCTjWaiOMuB9FAdDy6fxod61W4U4wj15AfmzaSJYrHsgQoRFzqiB+0518zx0eqfYCeLDRaWnov+QEQ72GFVG6KDFGomJGC9Y49f6NVuaQrFUL25iF1bQx7bc3OvpiMRkHHNciZvpORS5OgiMjjLBsDujbZ8eD17WNAI4Psk7JhzRqWufp+gUjjQsPUM7+GPXrRLpyHRGTEQkT0ZS4lwcuGdCs5kU0Uy5uJ70/vgOF085hQwyb1aUuG7LKkS/SJCC4GrYeE13ZH/U2JtAXSiI3NhPJgvJQVd8n+QXnm5AR7/M5PgqOhz0CddgmPr58GzTufAMa4SmT4eWJYquocJ+385+9pGPlalteJECaGuYSAyJfCqRAWbzy1AOD/L5B52qI5rhKQDF+smgyWYHf3wCyrHHTqjsztcnLIsJ8WvEJd6fzgJsS4ybUJKpCELlq8Od8AQez87QA2CRJH7eALYu3emjxScxRrl3L8yzlLFLjXU12xIptT0Bpba+sf0rQS/ye+YjZhW3YBnxfxkZedo3ga/GlsEo3CHmGmkiWMyDl9Imy94I2FZxh9TTFziEoi9vMmAfZGTKnX9rR759P2iauRWX+8b5bYQM8v4pQbqNjEJ+OYlQHGGxUq9jNZK65RDcr/L7ROJWpdehPEg1R8tJa0dunTGacvVLOqguT8GC52GtrPsq58tdw1sOfOsRypGY7a3eND6QerEB/Jf4Xg1GYXWJMTeupk21Dcu59HO0YCZhljokP/xvW9FwxAfG3xxhwov+QbtYB+VsqPOIRL8w+LeSY0zHlCQphgMzLlT93i+tv9Bhm+Ssxr0OkuRpIFAUuaBopVGWxXemU9uBBT7Lu1LLupTnKdx3eAZCkZepFE8ktU7d27uWB1allKEzz3wZSTO1Ua+3EJTeBNoXeaNebfuTHWY 1u7yqGTc YnW1A0CGF55NRrj2hHvv38hQiFaqy0lTTYLQ5BM896ntX4+/siff4jofL1fY5nu0gANt+5P5sUCvSQjoukc7CN+DLayw1xsBX5d0Vv5oe9K/Gurxy0wFpoh/zY9kQPUFrsblvITtfMTkrmTDbmZjejLapAfPgevd+Y06XlMUlk6japsk0XSO72h+Do0mmaR4VafuxmbOJuUzRoq/NxsW2FurVCg+tY7OOT014miF5YtOIrDaRyowYf9CCRT0xtvdAlb+2u8RDPZlEpk1vWKTgGzQcDqr9fSDi+ZDp X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Matthew Wilcox writes: > On Tue, Jul 09, 2024 at 05:09:42PM -0700, Ram Tummala wrote: >> Commit 3bd786f76de2 ("mm: convert do_set_pte() to set_pte_range()") >> replaced do_set_pte() with set_pte_range() and that introduced a regression >> in the following faulting path of non-anonymous vmas on CPUs with HW AF > > At no point in this do you say what "AF" stands for. It stands for "Access Flag", but that is specific to ARM64. As the fix is in generic architecture independent code it would be better to use that terminology (ie. old/young).