From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFDBDD2E028 for ; Wed, 23 Oct 2024 08:52:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 36F106B007B; Wed, 23 Oct 2024 04:52:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 31DD56B0082; Wed, 23 Oct 2024 04:52:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1E7BB6B0083; Wed, 23 Oct 2024 04:52:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 00F0E6B007B for ; Wed, 23 Oct 2024 04:52:38 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id B721B1607C5 for ; Wed, 23 Oct 2024 08:52:18 +0000 (UTC) X-FDA: 82704250986.02.8E09281 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by imf12.hostedemail.com (Postfix) with ESMTP id 44F6B40010 for ; Wed, 23 Oct 2024 08:52:28 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=AKhdXlrs; spf=pass (imf12.hostedemail.com: domain of jani.nikula@intel.com designates 198.175.65.9 as permitted sender) smtp.mailfrom=jani.nikula@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729673404; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pB4udbJ850EzlHY4aFkWvI7KEgmH05MRZCNj8jRM0ek=; b=7/av9cxgYR/56n2OE5NuATuKTBi5NTWwNKhr58fKi5pc5xS3d3j9tNrCVthdOViMM2d/Wi qnHmsd/ek9XmMVV5A33ho10s5IXxGys3AMqtCTSrqkkbRr3904MA9MxysXTu0y35jyFl+5 VRx3DsEo6/s4OzlIKxX5aTp7e5QWj5U= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729673404; a=rsa-sha256; cv=none; b=XuVw1CImoLTBEaLJ2Rbq2Yiqga+AhyB8xtB1C/YhoOD0Ypha32oug4UinMWjnki/km+GFr Rys/vioPFsP7BzaBksw5d0CX1y5/EjU2BKQ3cVomMRJTpiVmYiL+qWOhRaQAmupPILEYQy Xo39pcSB66qh4FN23cSoAXg9jhSeR2g= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=AKhdXlrs; spf=pass (imf12.hostedemail.com: domain of jani.nikula@intel.com designates 198.175.65.9 as permitted sender) smtp.mailfrom=jani.nikula@intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1729673556; x=1761209556; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=Q5ucK7d7uRJd+cvR1lR4/2r90nHVsOJOCPAxYH7QWpM=; b=AKhdXlrs50bSL0/FVSDo3gQThWcb+qgefPezJuoY9ovpaBcBn20EjVED zpb3CtyY2jDM4bpoytOo+GrKtv26DrH7E3pbww1H/Sauq4z6tTTCEd/S2 2iChxcClipLaOLqKxb8rdgaeZp8BfpbilJZhOpfMNRa7269xYWJV8/vNo cJe4zo/Xh6KrEx8Uha6iS3fr3zV3tVyFGeX9M5/hFppN8DWhHfsA0JVhj nkXQTAYmOewKBQAW/bsaL7R22FlaxiCTztx/0eUutLrLlXymia+232WyC OC0fUA5sET6WG9L39r/NuaQIEXwFgvCQordslf58Z4SjwTXTkCicAkCLI w==; X-CSE-ConnectionGUID: 3OKf21iIRvCKFxIvsr7jJQ== X-CSE-MsgGUID: ye10WYD7RAe8a2mLnnmI9Q== X-IronPort-AV: E=McAfee;i="6700,10204,11222"; a="51792577" X-IronPort-AV: E=Sophos;i="6.11,199,1725346800"; d="scan'208";a="51792577" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Oct 2024 01:52:33 -0700 X-CSE-ConnectionGUID: h73qZ12oSHigC3GIMnT0gA== X-CSE-MsgGUID: ZVHijG1OSPSJdXDXnmMvjA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,225,1725346800"; d="scan'208";a="80207426" Received: from kniemiec-mobl1.ger.corp.intel.com (HELO localhost) ([10.245.246.84]) by fmviesa008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Oct 2024 01:52:29 -0700 From: Jani Nikula To: Maarten Lankhorst , intel-xe@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Tejun Heo , Zefan Li , Johannes Weiner , Andrew Morton Cc: Friedrich Vock , cgroups@vger.kernel.org, linux-mm@kvack.org, Maxime Ripard , Maarten Lankhorst Subject: Re: [PATCH 6/7] [HACK] drm/xe: Hack to test with mapped pages instead of vram. In-Reply-To: <20241023075302.27194-7-maarten.lankhorst@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20241023075302.27194-1-maarten.lankhorst@linux.intel.com> <20241023075302.27194-7-maarten.lankhorst@linux.intel.com> Date: Wed, 23 Oct 2024 11:52:26 +0300 Message-ID: <875xpjurp1.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 44F6B40010 X-Stat-Signature: yqsh9d8xx3kf63tw53xj6etd75zgwkyy X-HE-Tag: 1729673548-701220 X-HE-Meta: U2FsdGVkX19zNdwWoF/QZcjAXqv21vsnQq8yiR/E75QAeA9QJEzBCTRHpF9fVL9ZNPI2jbSMpLAFKx99WhLdgVyY+MGz49z3+hj7muirpHBd6diFAZls1p68IcXsJDBZYG6Ix0bxfbGMPXCEAu9cAQRcBSfWPXpZwj/uq6/QLPAJtMOw3EMVHQMkRorRCmK/1Bgk8E4mh8yFHyz2rUlgnyPzLUpjAOA8VvnUues7+fDXnTq8CWZXBiEnUav1N6QsaF3/U9VMr7DAbcAPGY1+EtmY7zco+4jVUqHT/DTbAoyE4N15JC7+riG7KVZv3M9RTLxGokeBwM2s9F9FFSiKExkY2zrea73pjjnp92AuM3buz6XVAW/a8/7wQL12/VH6upr+Vpsfl2OKzhWIJzGqonW2AiEr/LL6jEZf5LipU2NvyQRjATMlkaTQrdpfxpTjAtlElfeu/c3GDryQKJzIAngI/yBp5s7P901zjQPzb0NO7rjVrp4hwxH4pmqhs812reZ8KMX95IBDFwnJsJI9+yLj9JUZOjCDyDkbTKo+tgrm1Y9cu7a5L1/+t1Y0cyEtPkXdrnblr4XEFXZm0CULcLV9fvj2wVpnbpaQjnWPCg7pBPVSfY2sc/UF6NE9sYMYunE5PkOD6H+Bqp2hde5qMkv/uDeNH8mKS6aO4JQdob44M1cv/ARAPiI6E89c6Im8wsoPoNV+Cwzn0Gcqs5QxCymIrroEPPFW5WmeAyQ+Q4dSNc0fgRkBP5FQEKow99ymOKK2EDbT1wsuVprDxfdQcoKyZLvQsopsnVAJ3vxmjqUilR7/upaU8T2N99jYtJ1Ne8CFUSzywh5ZsMkht2vcH9fZ8VRuJ6JuEpQMHNIO5N5O9rJibOSZnCNr8QmdjJ3LMdhJ2HBkI48IkTKzD+30lUsneXpVfohGEbbTPALO9JuijDxk31TFS214blyq5xQKY0SjSFsjmH4KLs/EJ33 6z3VAfm1 qCn+yCmc/USgIIfWxpsS3fCPVs64Pd+GiaS73UYC3D1ULEtpESzMByiX3INGfddQumm1Xd3Xt7lycpO+q6T4KHZNcnBkFReQZhQSyjfrzJoVncIJZRRLKHgFi1kslJkRQx0jNEA2wiCzQT67Z0N45smm62z4j8rcuWZUTcCJPnQwSAzn29qIZI6owfjxWIa9Qfl7mV3zPiG6B5nkv7TFZUbSjq90jRM/jw/byt9y1Qc1VRCKhR4t8zTc6/aeB3mYvdDxl9VHTxpu1JRWmBgmbP0wG0nDcL7S2JaRIcyjrkrGnlnMi+B7r/iSDYpRBpykQUSFhin9BjrZL21Yu5tKEkRJSDOcwYn7A4vovFgDpdkgi4FWSy3V7Np8nKtQcsKcx8JF1N3fwvk5nw/CJZRcj1xtu3uuFal533W6OhJUEfikFZ+UmXeqVc6mcOQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 23 Oct 2024, Maarten Lankhorst wrote: > We will probably want to make this a proper region in TTM for > everything, so that we can charge VRAM twice, once for mapped > in sysmem, once for mapped in vram. That way we don't need to > deal with evict failing from lack of available memory in mapped. > > Signed-off-by: Maarten Lankhorst > Signed-off-by: Maxime Ripard > --- > drivers/gpu/drm/xe/xe_ttm_sys_mgr.c | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/drivers/gpu/drm/xe/xe_ttm_sys_mgr.c b/drivers/gpu/drm/xe/xe_ttm_sys_mgr.c > index 9844a8edbfe19..20fa8ec8925ef 100644 > --- a/drivers/gpu/drm/xe/xe_ttm_sys_mgr.c > +++ b/drivers/gpu/drm/xe/xe_ttm_sys_mgr.c > @@ -101,6 +101,18 @@ static void ttm_sys_mgr_fini(struct drm_device *drm, void *arg) > ttm_set_driver_manager(&xe->ttm, XE_PL_TT, NULL); > } > > +static inline void apply_cg(struct xe_device *xe, > + struct ttm_resource_manager *man, > + u64 gtt_size) Ditto here about static inline in .c. > +{ > + int cgregion = xe->cg.num_regions++; > + > + xe->cg.regions[cgregion].size = gtt_size; > + xe->cg.regions[cgregion].name = "mapped"; > + man->cgdev = &xe->cg; > + man->cgidx = cgregion; > + > +} > int xe_ttm_sys_mgr_init(struct xe_device *xe) > { > struct ttm_resource_manager *man = &xe->mem.sys_mgr; > @@ -116,6 +128,8 @@ int xe_ttm_sys_mgr_init(struct xe_device *xe) > man->func = &xe_ttm_sys_mgr_func; > ttm_resource_manager_init(man, &xe->ttm, gtt_size >> PAGE_SHIFT); > ttm_set_driver_manager(&xe->ttm, XE_PL_TT, man); > + apply_cg(xe, man, gtt_size); > + > ttm_resource_manager_set_used(man, true); > return drmm_add_action_or_reset(&xe->drm, ttm_sys_mgr_fini, xe); > } -- Jani Nikula, Intel