From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D9BAC77B7C for ; Tue, 24 Jun 2025 10:58:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0702B6B0099; Tue, 24 Jun 2025 06:58:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 020CA6B00A4; Tue, 24 Jun 2025 06:58:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EA02A6B00AA; Tue, 24 Jun 2025 06:58:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D81736B0099 for ; Tue, 24 Jun 2025 06:58:09 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 8471B1404F7 for ; Tue, 24 Jun 2025 10:58:09 +0000 (UTC) X-FDA: 83589994698.18.CEED31C Received: from out30-119.freemail.mail.aliyun.com (out30-119.freemail.mail.aliyun.com [115.124.30.119]) by imf13.hostedemail.com (Postfix) with ESMTP id 88F432000C for ; Tue, 24 Jun 2025 10:58:06 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=d2m446pn; spf=pass (imf13.hostedemail.com: domain of ying.huang@linux.alibaba.com designates 115.124.30.119 as permitted sender) smtp.mailfrom=ying.huang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750762688; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+NgBLhqy1L817I/jNzksXR2nN08H6Idgamz1I8pvVlw=; b=l6uvB67Jpw+mqj9PYL+YEUPUwNwDl8B5aU2dLxlFhrwxqSDZBrZFVHXZdt/hoHqgSf2ArU Whq1UtufD/LoYKnBXhAePTZ2a+P6t7dH6zOzxVJIG3tFpaZdGNs+cBhqz2/iFiM0Flf6wj IfUumYQW4BawasZTi3MUjsbdtyDjtQA= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=d2m446pn; spf=pass (imf13.hostedemail.com: domain of ying.huang@linux.alibaba.com designates 115.124.30.119 as permitted sender) smtp.mailfrom=ying.huang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750762688; a=rsa-sha256; cv=none; b=jhjV3I7YxqA5Gf/vdJ+oFPyEiJZe8+taWpAr7pwS16fDMH5uS+L77Qi0JQlpqd1F7WkoRt OJzeTgB4NqQaZgyub0aTJBxPEz8LZlXFQMV+wSLeQ/4Mv3SjpwKVqUc52Jx56sc/k69Kaw RZK6Qu5ylMDGOQkRTpgMkL0FXhUD8hA= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1750762683; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type; bh=+NgBLhqy1L817I/jNzksXR2nN08H6Idgamz1I8pvVlw=; b=d2m446pnIaQCuB9GGRw7Y4JhCO8/kGyKR5XyyOLXDi9XcnR3515/dVNSg72/bWryuF059+d9GhH9Kx+n/KHuXEOsgkP+BW49lJ3X9jhFkcRGcy2eMnnE51DpvBkSKOYgrkNUbrYVtQmiAcrRXB2rAbMMUqyGR8YeUrYbzKPAlIY= Received: from DESKTOP-5N7EMDA(mailfrom:ying.huang@linux.alibaba.com fp:SMTPD_---0Weh-0Qo_1750762681 cluster:ay36) by smtp.aliyun-inc.com; Tue, 24 Jun 2025 18:58:01 +0800 From: "Huang, Ying" To: Bijan Tabatabai Cc: damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, sj@kernel.org, akpm@linux-foundation.org, david@redhat.com, ziy@nvidia.com, matthew.brost@intel.com, joshua.hahnjy@gmail.com, rakie.kim@sk.com, byungchul@sk.com, gourry@gourry.net, apopple@nvidia.com, bijantabatab@micron.com, venkataravis@micron.com, emirakhur@micron.com, ajayjoshi@micron.com, vtavarespetr@micron.com Subject: Re: [RFC PATCH v2 1/2] mm/mempolicy: Expose get_il_weight() to MM In-Reply-To: <20250620180458.5041-2-bijan311@gmail.com> (Bijan Tabatabai's message of "Fri, 20 Jun 2025 13:04:57 -0500") References: <20250620180458.5041-1-bijan311@gmail.com> <20250620180458.5041-2-bijan311@gmail.com> Date: Tue, 24 Jun 2025 18:58:00 +0800 Message-ID: <875xglo18n.fsf@DESKTOP-5N7EMDA> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 88F432000C X-Stat-Signature: 748gwsumof531kbfxjkdrn159ps76jp8 X-Rspam-User: X-HE-Tag: 1750762686-905969 X-HE-Meta: U2FsdGVkX19UUSYXT+GUeIJ/9loTJ7QPLsgzET6GfBMqA20I23zxH4iSIe3vmn9dHjvrdh0yu6RBDQhLV1Zclbo05BqEUQxMhU0Iaxsfv6DF7xwd+MguDPPA6po0mCozfq+A0oeezZzNBTeZLVUxf8YlT0m305Epb/QBGKZviyohtueQzSa+zmRuA6Nnvh4SCyI7fQOYEsJ1Gno3bdpT31KA6fjkZpkYOzJN/pUHjTP6DjTcTsqUFbO4syngqwr7OOjiEzxnsC0AHMNlJgdACOcJHhAPKQBY3u2uc7xWab+yVE/kmi8XfU1ptXwnzeUphaZlzaEgol+qAA7PsdyKJdXxnVvCzrnLQ6ie/CKTzUE7WPZNtbB6KNKPgJjaSErpmR3XM6qbpxyt7uHeThiRLd42vPRncT8bWqlLdpCQ4Mo94pMd0iDcaxw9OBvxVGL7REOUY5bxq7F5PUUZMxhyysCK31T7Hl6riQXAGdbiabINr8wZdt6TkiVwL7kL9JljlUPsBZF+UB0tJNGiTpck3Q5Oy657XjQQ6mWAKy5wOXw8pCbFUkKXMbz6BWm4wzLpp9vweGw8+5XeO4p6VU7InC2AIgutDVl76YRHKka3ZEv+Wix2wvDEzLhhLSIvvAVm94TnnMZ0YWjbBHdjOzXSWrfXFZ6eWg7Whts+mKiOIkNgCHP8A7k8/9mxATvGgSfHeqy9Sr5N4fTQMYPVjukmmpDsC6sXPehnlzIAD/KsNjNtKc5aNcz5zMt9OUdSJ8yqb31LNtcPoZtLdQPLv6ey0f2gWThFjK4L9tX2+jtCXrJBcaEXLjZBvFg5KfNw1LpD+a2f02QCNm+KOYixcg+HmWt/c5KaThK8ZRT9IVsw38JBbQ6droih0LhD4/t4FSBQsKKWpU0eVMpUkg/bq6LWDEbyo6tJv+MszsFPWVFdm4Pt89CYQi36hon2TKBwKHO08/9rui8kBdF/luAvSJu FvaILEjj gPE4Kx8JhQq1wkfOjoEPLl+zaQBxAxnH17RLfb6Mm0hDqCPKD2IhDuEgg2Jp37z1J1x1XFfl0RfsePy3SEwmYhTxbXFun7wF0hVdRutzMuuyTOGQmWcjZl1iZ/Clb+mEMkH+4sMwxJ/DyJfRnYftU+cWwX8Qb0ZKhckI1T3YTqNzykUCYIcLTC1DxN2RHSDbfHwVg7B5G8ZPZuI2ua7rcuRV5ULTYwcVITtlDUGn785XPmBA6ImpAGi/eO4EHFAuoHxgDmY8Cs0Rbaouu8mdxqU88gu0zY/vj/GAZrlNRfFBa9InQJzHiVNap5PAwpqnsyC2YVFsv04yupzB0Ig2A9gHiJSoTH0vprKMNlZBCRiEOkteK4gujdiNtSsoyuf4Sp0k6nyKdwYSU0ythwdwOVtey6xrBqgqOwsJSKAt+1sJyh+Pv4TT5zmRxFrtqrfbDB5c5BDsGCuxultrPEVV0i5DSE2YQGGeytAbx X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Bijan Tabatabai writes: > From: Bijan Tabatabai > > This patch exposes get_il_weight() in mm/internal.h. This patch is to > allow other parts of the MM subsystem, such as DAMON, to make page > placement decisions based on the global interleave weights. > > Signed-off-by: Bijan Tabatabai > --- > mm/internal.h | 6 ++++++ > mm/mempolicy.c | 2 +- > 2 files changed, 7 insertions(+), 1 deletion(-) > > diff --git a/mm/internal.h b/mm/internal.h > index 3823fb356d3b..b718ebe7cad5 100644 > --- a/mm/internal.h > +++ b/mm/internal.h > @@ -1169,6 +1169,7 @@ extern int node_reclaim_mode; > > extern int node_reclaim(struct pglist_data *, gfp_t, unsigned int); > extern int find_next_best_node(int node, nodemask_t *used_node_mask); > +extern u8 get_il_weight(int node); > #else > #define node_reclaim_mode 0 > > @@ -1181,6 +1182,11 @@ static inline int find_next_best_node(int node, nodemask_t *used_node_mask) > { > return NUMA_NO_NODE; > } > + > +static inline u8 get_il_weight(int node) > +{ > + return 1; > +} > #endif > > static inline bool node_reclaim_enabled(void) > diff --git a/mm/mempolicy.c b/mm/mempolicy.c > index 1ff7b2174eb7..b1713430ee9c 100644 > --- a/mm/mempolicy.c > +++ b/mm/mempolicy.c > @@ -165,7 +165,7 @@ static unsigned int *node_bw_table; > */ > static DEFINE_MUTEX(wi_state_lock); > > -static u8 get_il_weight(int node) > +u8 get_il_weight(int node) > { > struct weighted_interleave_state *state; > u8 weight = 1; I agree with David on the function naming and "extern". Otherwise, this looks good to me, Thanks! Feel free to add my Reviewed-by: Huang Ying in the future versions. --- Best Regards, Huang, Ying