* [PATCH] mm/debug_vm_pgtable: Add [pte|pmd]_mkwrite_novma() tests
@ 2025-10-21 2:44 Anshuman Khandual
2025-10-21 3:54 ` Huang, Ying
0 siblings, 1 reply; 3+ messages in thread
From: Anshuman Khandual @ 2025-10-21 2:44 UTC (permalink / raw)
To: linux-mm
Cc: Anshuman Khandual, Andrew Morton, David Hildenbrand, Huang Ying,
linux-kernel, Catalin Marinas
Add some [pte|pmd]_mkwrite_novma() relevant tests.
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: David Hildenbrand <david@redhat.com>
Cc: Huang Ying <ying.huang@linux.alibaba.com>
Cc: linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org
Suggested-by: Catalin Marinas <catalin.marinas@arm.com>
Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
---
These tests clear on arm64 platform after the following recent patch.
https://lore.kernel.org/all/20251015023712.46598-1-ying.huang@linux.alibaba.com/
mm/debug_vm_pgtable.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/mm/debug_vm_pgtable.c b/mm/debug_vm_pgtable.c
index 830107b6dd08..b9cae1580782 100644
--- a/mm/debug_vm_pgtable.c
+++ b/mm/debug_vm_pgtable.c
@@ -102,6 +102,11 @@ static void __init pte_basic_tests(struct pgtable_debug_args *args, int idx)
WARN_ON(pte_write(pte_wrprotect(pte_mkwrite(pte, args->vma))));
WARN_ON(pte_dirty(pte_wrprotect(pte_mkclean(pte))));
WARN_ON(!pte_dirty(pte_wrprotect(pte_mkdirty(pte))));
+
+ WARN_ON(pte_dirty(pte_mkwrite_novma(pte_mkclean(pte))));
+ WARN_ON(!pte_write(pte_mkdirty(pte_mkwrite_novma(pte))));
+ WARN_ON(!pte_write(pte_mkwrite_novma(pte_wrprotect(pte))));
+ WARN_ON(pte_write(pte_wrprotect(pte_mkwrite_novma(pte))));
}
static void __init pte_advanced_tests(struct pgtable_debug_args *args)
@@ -195,6 +200,11 @@ static void __init pmd_basic_tests(struct pgtable_debug_args *args, int idx)
WARN_ON(pmd_write(pmd_wrprotect(pmd_mkwrite(pmd, args->vma))));
WARN_ON(pmd_dirty(pmd_wrprotect(pmd_mkclean(pmd))));
WARN_ON(!pmd_dirty(pmd_wrprotect(pmd_mkdirty(pmd))));
+
+ WARN_ON(pmd_dirty(pmd_mkwrite_novma(pmd_mkclean(pmd))));
+ WARN_ON(!pmd_write(pmd_mkdirty(pmd_mkwrite_novma(pmd))));
+ WARN_ON(!pmd_write(pmd_mkwrite_novma(pmd_wrprotect(pmd))));
+ WARN_ON(pmd_write(pmd_wrprotect(pmd_mkwrite_novma(pmd))));
/*
* A huge page does not point to next level page table
* entry. Hence this must qualify as pmd_bad().
--
2.30.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mm/debug_vm_pgtable: Add [pte|pmd]_mkwrite_novma() tests
2025-10-21 2:44 [PATCH] mm/debug_vm_pgtable: Add [pte|pmd]_mkwrite_novma() tests Anshuman Khandual
@ 2025-10-21 3:54 ` Huang, Ying
2025-10-21 7:48 ` Anshuman Khandual
0 siblings, 1 reply; 3+ messages in thread
From: Huang, Ying @ 2025-10-21 3:54 UTC (permalink / raw)
To: Anshuman Khandual
Cc: linux-mm, Andrew Morton, David Hildenbrand, linux-kernel,
Catalin Marinas
Anshuman Khandual <anshuman.khandual@arm.com> writes:
> Add some [pte|pmd]_mkwrite_novma() relevant tests.
>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: David Hildenbrand <david@redhat.com>
> Cc: Huang Ying <ying.huang@linux.alibaba.com>
> Cc: linux-mm@kvack.org
> Cc: linux-kernel@vger.kernel.org
> Suggested-by: Catalin Marinas <catalin.marinas@arm.com>
> Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
> ---
> These tests clear on arm64 platform after the following recent patch.
>
> https://lore.kernel.org/all/20251015023712.46598-1-ying.huang@linux.alibaba.com/
>
> mm/debug_vm_pgtable.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/mm/debug_vm_pgtable.c b/mm/debug_vm_pgtable.c
> index 830107b6dd08..b9cae1580782 100644
> --- a/mm/debug_vm_pgtable.c
> +++ b/mm/debug_vm_pgtable.c
> @@ -102,6 +102,11 @@ static void __init pte_basic_tests(struct pgtable_debug_args *args, int idx)
> WARN_ON(pte_write(pte_wrprotect(pte_mkwrite(pte, args->vma))));
> WARN_ON(pte_dirty(pte_wrprotect(pte_mkclean(pte))));
> WARN_ON(!pte_dirty(pte_wrprotect(pte_mkdirty(pte))));
> +
> + WARN_ON(pte_dirty(pte_mkwrite_novma(pte_mkclean(pte))));
Why not use: pte_mkwrite(pte, args->vma)?
Maybe add
WARN_ON(!pte_dirty(pte_mkwrite_novma(pte_mkdirty(pte))));
> + WARN_ON(!pte_write(pte_mkdirty(pte_mkwrite_novma(pte))));
> + WARN_ON(!pte_write(pte_mkwrite_novma(pte_wrprotect(pte))));
> + WARN_ON(pte_write(pte_wrprotect(pte_mkwrite_novma(pte))));
> }
>
> static void __init pte_advanced_tests(struct pgtable_debug_args *args)
> @@ -195,6 +200,11 @@ static void __init pmd_basic_tests(struct pgtable_debug_args *args, int idx)
> WARN_ON(pmd_write(pmd_wrprotect(pmd_mkwrite(pmd, args->vma))));
> WARN_ON(pmd_dirty(pmd_wrprotect(pmd_mkclean(pmd))));
> WARN_ON(!pmd_dirty(pmd_wrprotect(pmd_mkdirty(pmd))));
> +
> + WARN_ON(pmd_dirty(pmd_mkwrite_novma(pmd_mkclean(pmd))));
> + WARN_ON(!pmd_write(pmd_mkdirty(pmd_mkwrite_novma(pmd))));
> + WARN_ON(!pmd_write(pmd_mkwrite_novma(pmd_wrprotect(pmd))));
> + WARN_ON(pmd_write(pmd_wrprotect(pmd_mkwrite_novma(pmd))));
> /*
> * A huge page does not point to next level page table
> * entry. Hence this must qualify as pmd_bad().
---
Best Regards,
Huang, Ying
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mm/debug_vm_pgtable: Add [pte|pmd]_mkwrite_novma() tests
2025-10-21 3:54 ` Huang, Ying
@ 2025-10-21 7:48 ` Anshuman Khandual
0 siblings, 0 replies; 3+ messages in thread
From: Anshuman Khandual @ 2025-10-21 7:48 UTC (permalink / raw)
To: Huang, Ying
Cc: linux-mm, Andrew Morton, David Hildenbrand, linux-kernel,
Catalin Marinas
On 21/10/25 9:24 AM, Huang, Ying wrote:
> Anshuman Khandual <anshuman.khandual@arm.com> writes:
>
>> Add some [pte|pmd]_mkwrite_novma() relevant tests.
>>
>> Cc: Andrew Morton <akpm@linux-foundation.org>
>> Cc: David Hildenbrand <david@redhat.com>
>> Cc: Huang Ying <ying.huang@linux.alibaba.com>
>> Cc: linux-mm@kvack.org
>> Cc: linux-kernel@vger.kernel.org
>> Suggested-by: Catalin Marinas <catalin.marinas@arm.com>
>> Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
>> ---
>> These tests clear on arm64 platform after the following recent patch.
>>
>> https://lore.kernel.org/all/20251015023712.46598-1-ying.huang@linux.alibaba.com/
>>
>> mm/debug_vm_pgtable.c | 10 ++++++++++
>> 1 file changed, 10 insertions(+)
>>
>> diff --git a/mm/debug_vm_pgtable.c b/mm/debug_vm_pgtable.c
>> index 830107b6dd08..b9cae1580782 100644
>> --- a/mm/debug_vm_pgtable.c
>> +++ b/mm/debug_vm_pgtable.c
>> @@ -102,6 +102,11 @@ static void __init pte_basic_tests(struct pgtable_debug_args *args, int idx)
>> WARN_ON(pte_write(pte_wrprotect(pte_mkwrite(pte, args->vma))));
>> WARN_ON(pte_dirty(pte_wrprotect(pte_mkclean(pte))));
>> WARN_ON(!pte_dirty(pte_wrprotect(pte_mkdirty(pte))));
>> +
>> + WARN_ON(pte_dirty(pte_mkwrite_novma(pte_mkclean(pte))));
>
> Why not use: pte_mkwrite(pte, args->vma)?
>
> Maybe add
>
> WARN_ON(!pte_dirty(pte_mkwrite_novma(pte_mkdirty(pte))));
Sure, will add the above test as well.
>
>> + WARN_ON(!pte_write(pte_mkdirty(pte_mkwrite_novma(pte))));
>> + WARN_ON(!pte_write(pte_mkwrite_novma(pte_wrprotect(pte))));
>> + WARN_ON(pte_write(pte_wrprotect(pte_mkwrite_novma(pte))));
>> }
>>
>> static void __init pte_advanced_tests(struct pgtable_debug_args *args)
>> @@ -195,6 +200,11 @@ static void __init pmd_basic_tests(struct pgtable_debug_args *args, int idx)
>> WARN_ON(pmd_write(pmd_wrprotect(pmd_mkwrite(pmd, args->vma))));
>> WARN_ON(pmd_dirty(pmd_wrprotect(pmd_mkclean(pmd))));
>> WARN_ON(!pmd_dirty(pmd_wrprotect(pmd_mkdirty(pmd))));
>> +
>> + WARN_ON(pmd_dirty(pmd_mkwrite_novma(pmd_mkclean(pmd))));
>> + WARN_ON(!pmd_write(pmd_mkdirty(pmd_mkwrite_novma(pmd))));
>> + WARN_ON(!pmd_write(pmd_mkwrite_novma(pmd_wrprotect(pmd))));
>> + WARN_ON(pmd_write(pmd_wrprotect(pmd_mkwrite_novma(pmd))));
>> /*
>> * A huge page does not point to next level page table
>> * entry. Hence this must qualify as pmd_bad().
>
> ---
> Best Regards,
> Huang, Ying
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-10-21 7:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-10-21 2:44 [PATCH] mm/debug_vm_pgtable: Add [pte|pmd]_mkwrite_novma() tests Anshuman Khandual
2025-10-21 3:54 ` Huang, Ying
2025-10-21 7:48 ` Anshuman Khandual
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox