From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5457DE7AD77 for ; Tue, 3 Oct 2023 16:46:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9861A6B0142; Tue, 3 Oct 2023 12:46:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 935F26B0147; Tue, 3 Oct 2023 12:46:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7FDA46B0149; Tue, 3 Oct 2023 12:46:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 706216B0142 for ; Tue, 3 Oct 2023 12:46:43 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 3EEFF1603EE for ; Tue, 3 Oct 2023 16:46:43 +0000 (UTC) X-FDA: 81304729086.28.A41AA33 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.93]) by imf08.hostedemail.com (Postfix) with ESMTP id DBC1E160009 for ; Tue, 3 Oct 2023 16:46:39 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=hbRhNsmk; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf08.hostedemail.com: domain of dave.hansen@intel.com designates 192.55.52.93 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696351600; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7I753hgUN3aPtNz6n3TXAXMtDJ+JrriXycYwMbEjzfQ=; b=PtpvQ9sgnokIe35j8SLe1F4CmhUqWY/98w72hpocUAVQpn0C3z1QAwAqoxBN/qE6ZE5Dqj HUtapVxmc1JRHqUBWILUydVlVOLTHCeE32RsqrGDAN01WqrIU7u7kCdFz4hv+GcdWhk62C 0KToJigpqMQWYQzLYqK5Je6VJtoHg+E= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=hbRhNsmk; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf08.hostedemail.com: domain of dave.hansen@intel.com designates 192.55.52.93 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696351600; a=rsa-sha256; cv=none; b=nAj1vW9wMX0yBKvC1FpxCIkdVEO4u1GLbEt8cQgCVL9fc+ct7Ga9kBZwu8p+q+OimbKHJy s4V43FhzETEcL866UQy+JGEK0F3WoGGuJb3UjM30uMG2uz67OY6Q7Sd9YlR6JNq/FJa73o 72GllYjb6iFZ4tw9Qh6dgRZEn4O8EDE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1696351600; x=1727887600; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=WABA3N82zUWgofliPDkDARwavt+9zpHw4Esz4HwHYMg=; b=hbRhNsmkCFutPEznxx10k+RjhtCLd6ZXA11eL+Y2AYOPyElaakAaFe8R 6owfnhfnVJP1zbrW6ETDmxfo50Zi+R2+MaaQmz962l7y3Oo/+gDXVKU73 YwUcXWQYvGGZoYw0S2i0qFgtbxiFgqDyV3zxer8bQtDNV3NhUdOQVcpv1 QUpj4lNHqxWrePKTv2mXa2hpdijEWjP7XCjzI57HVkBGiMW3pQlZ3yvtg LecXc1/+eeoF31GGDJRovKUO6PSge1Bv7bX6fofS1OIl7CMwsYVgajeNf Z8OggJYRNFnELVbvx346gvcn67S8NPvhob21k4xfex6Hwdbjljdcef2LK A==; X-IronPort-AV: E=McAfee;i="6600,9927,10852"; a="380198869" X-IronPort-AV: E=Sophos;i="6.03,197,1694761200"; d="scan'208";a="380198869" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Oct 2023 09:46:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10852"; a="841423206" X-IronPort-AV: E=Sophos;i="6.03,197,1694761200"; d="scan'208";a="841423206" Received: from ddiaz-mobl4.amr.corp.intel.com (HELO [10.209.57.36]) ([10.209.57.36]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Oct 2023 09:46:37 -0700 Message-ID: <875f8a6f-c2b3-92f4-f067-b969a9fc1112@intel.com> Date: Tue, 3 Oct 2023 09:46:36 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v1 20/20] selftests: mm: make protection_keys test work on arm64 Content-Language: en-US To: Joey Gouly , linux-arm-kernel@lists.infradead.org Cc: nd@arm.com, akpm@linux-foundation.org, aneesh.kumar@linux.ibm.com, catalin.marinas@arm.com, dave.hansen@linux.intel.com, maz@kernel.org, oliver.upton@linux.dev, shuah@kernel.org, will@kernel.org, kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org References: <20230927140123.5283-1-joey.gouly@arm.com> <20230927140123.5283-21-joey.gouly@arm.com> From: Dave Hansen In-Reply-To: <20230927140123.5283-21-joey.gouly@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: DBC1E160009 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: cseuyt3hxgmr6zha5xbtpbtydyirq185 X-HE-Tag: 1696351599-924973 X-HE-Meta: U2FsdGVkX19EcEn10kRBbkUIGLiO+1omU6xV5TlzFilLEsbjTdo23v2iQb5OkNU4YCwhHOR+EsueZy3UWnLNH6q0ZmLVdithujQsQdpZbbEbfdFW0tfmYT3c1eABDEqDMxPdGkrLJNSlIFupbzeoCK6D2yBct1tNqaoYOpsLh7QXzHh/79SOSsnuy0RmtdFF/FIPVgcQDtsjUEE7FVzFRwx3GgYKXIoA60BWlI7Qypv6G5+zZ+zngcRKQ8Cw/SiB57EHSMZukVdVB9Ra9OXhqvhoy4LEBWEkTAY2RbwD67PP6ZdbqPccTeVBylUJKLiQyTbu47vChzFRBKK6BQ1QzuBXnjkuL2kNC32KpSl1tYMs9HuEAbYIrWYmm0Iu3e0YW360VpjbFZy/4Yx0+B6PV01XVUySGVYw+Uwm8DoklbbvgtlRtdZe4Xv1Cdmsc4UsLLZ+MrWwrsBzzl5jnv8137yIBmlRNUE3eI2qytSVF/5YT9906p3kTijE+OMlPdZGyCqXQlUegJzxW+tc6aHVDCNUc55lZlO6sN7nSfHo9gXXVu4n5zECn2u/w9XN0y0ptAd3pcz62oFXA5LvNvUMtGGltFASCEtsum8AKsuOs1mOCKWxuja06H689e+lDHtrlvsslYFFf4a+qxhHhJ9l5008aO/OIWI1uxYYiq4EYZmLe18BEzsFk8k5+k0IIgvjbYjezxa86I51DYOfjuCeayUcZlikjBuDTL7ebZQuWSNwlxyBvZfk7NPTWctHPj+iofpe9K3ib2HJ7GltOPkNOUuR+Xy8QMOZzOImdlocfymRo/R0niqm0i0ROGCF6kfsHJXpkEjJ/Av6oh7Uw0KWZh0aZiWdp/uf8jy4NV9POVvQxn1Q+8gS1PmF3b1G7iVdVjFwOkoQifV1mZ3LQFZSMAjuXiNdG/CtD06geGQYQhx/kaMZCuGLM+kfEZZ1g0xF6QRaeJDlAl/oGxHMFPn 8YMMqRnO 288XtK04YDwaGC4zXu6oNVLDL0FlssRaWPPmf094HiKxEvyuuV9PojyBviojEUGCi6NfQvZoyCgaCS+hyWzfDhuoERwwMYX7h/oe0dOYHXawqn0tSEUdxwUMkGdz37+5iLsNga3bmCDkQVcROmd21x854bg5NRvAW196GE9hBb2ZSJgNmIdL2/2V3jQcIznK5JMB2mwrcyD/forfOk+dtE5U1je1Xb1gx1N5NfWdB/Xd/zGlXba2o6n+KEAbx0q0TbjeT1zYeeIVH/l8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 9/27/23 07:01, Joey Gouly wrote: > The encoding of the pkey register differs on arm64, than on x86/ppc. On those > platforms, a bit in the register is used to disable permissions, for arm64, a > bit enabled in the register indicates that the permission is allowed. > > This drops two asserts of the form: > assert(read_pkey_reg() <= orig_pkey_reg); > Because on arm64 this doesn't hold, due to the encoding. > > The pkey must be reset to both access allow and write allow in the signal > handler. pkey_access_allow() works currently for PowerPC as the > PKEY_DISABLE_ACCESS and PKEY_DISABLE_WRITE have overlapping bits set. > > Access to the uc_mcontext is abstracted, as arm64 has a different structure. This all looks sane enough. Welcome to the pkey party! :) Acked-by: Dave Hansen