From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE379C433F5 for ; Thu, 10 Mar 2022 08:25:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6D4088D0002; Thu, 10 Mar 2022 03:25:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 683F08D0001; Thu, 10 Mar 2022 03:25:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5A5C38D0002; Thu, 10 Mar 2022 03:25:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.a.hostedemail.com [64.99.140.24]) by kanga.kvack.org (Postfix) with ESMTP id 4A8578D0001 for ; Thu, 10 Mar 2022 03:25:37 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 0762B203ED for ; Thu, 10 Mar 2022 08:25:37 +0000 (UTC) X-FDA: 79227792714.13.D1B570B Received: from alexa-out-sd-01.qualcomm.com (alexa-out-sd-01.qualcomm.com [199.106.114.38]) by imf14.hostedemail.com (Postfix) with ESMTP id 2989C100015 for ; Thu, 10 Mar 2022 08:25:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1646900736; x=1678436736; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=M1FxyZOr2miK6glLtvAtSHCGudtfTwOvAFevUu4VqpU=; b=tOFGZO7tMMp9nYFKhEPmCiOHUEw4Lxblfu9coDktxVs5rXhSAuKGyuVs dMXXL7XZkABSWcTFEP5eXEB9gzoR2Tx6XOEuvFtzPQYzr5SFYXqzXRcQr AOfANfL81aStYoWzXRP9EQM/PKshFJnxXRIzul66tWa7b4CcjMDpvVMSM g=; Received: from unknown (HELO ironmsg02-sd.qualcomm.com) ([10.53.140.142]) by alexa-out-sd-01.qualcomm.com with ESMTP; 10 Mar 2022 00:25:34 -0800 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg02-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Mar 2022 00:25:34 -0800 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.15; Thu, 10 Mar 2022 00:25:34 -0800 Received: from [10.216.27.16] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.15; Thu, 10 Mar 2022 00:25:30 -0800 Message-ID: <8758f360-0c6f-28bb-8483-342ad808865f@quicinc.com> Date: Thu, 10 Mar 2022 13:55:26 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.0 Subject: Re: [PATCH] mm: madvise: return correct bytes advised with process_madvise Content-Language: en-US To: Minchan Kim CC: , , , , , , , References: <1646803679-11433-1-git-send-email-quic_charante@quicinc.com> From: Charan Teja Kalla In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-Rspamd-Queue-Id: 2989C100015 X-Stat-Signature: bk1p9pctxudaj58okrrmz8z5ag97ndy9 X-Rspam-User: Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcdkim header.b=tOFGZO7t; dmarc=pass (policy=none) header.from=quicinc.com; spf=pass (imf14.hostedemail.com: domain of quic_charante@quicinc.com designates 199.106.114.38 as permitted sender) smtp.mailfrom=quic_charante@quicinc.com X-Rspamd-Server: rspam03 X-HE-Tag: 1646900735-772967 X-Bogosity: Ham, tests=bogofilter, spamicity=0.052344, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Thanks Minchan for your comment!! On 3/9/2022 10:17 PM, Minchan Kim wrote: >> @@ -1426,15 +1426,21 @@ SYSCALL_DEFINE5(process_madvise, int, pidfd, const struct iovec __user *, vec, >> >> while (iov_iter_count(&iter)) { >> iovec = iov_iter_iovec(&iter); >> + /* >> + * Even when [start, end) passed to do_madvise covers >> + * some unmapped addresses, it continues processing with >> + * returning ENOMEM at the end. Thus consider the range >> + * as processed when do_madvise() returns ENOMEM. >> + * This makes process_madvise() never returns ENOMEM. >> + */ > Looks like that this patch has two things. first, returns processed > bytes instead of error in case of error. Second, keep working on > rest vmas on -ENOMEM due to unmapped hole. > > First thing totally makes sense to me(that's exactly I wanted to > do but somehow missed) so it should go stable tree. However, > second stuff might be arguble so it would be great if you split > the patch. Sure, then will split the patch in V2. >