From: "Huang\, Ying" <ying.huang@intel.com>
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: "Huang, Ying" <ying.huang@intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Michal Hocko <mhocko@suse.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
David Rientjes <rientjes@google.com>,
Arnd Bergmann <arnd@arndb.de>, Hugh Dickins <hughd@google.com>,
Jerome Glisse <jglisse@redhat.com>,
Daniel Colascione <dancol@google.com>,
Zi Yan <zi.yan@cs.rutgers.edu>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Subject: Re: [PATCH -mm] mm, pagemap: Fix soft dirty marking for PMD migration entry
Date: Tue, 17 Oct 2017 20:23:15 +0800 [thread overview]
Message-ID: <874lqy7yks.fsf@yhuang-dev.intel.com> (raw)
In-Reply-To: <20171017112100.pciya6pmo62owpht@node.shutemov.name> (Kirill A. Shutemov's message of "Tue, 17 Oct 2017 14:21:00 +0300")
"Kirill A. Shutemov" <kirill@shutemov.name> writes:
> On Tue, Oct 17, 2017 at 04:18:18PM +0800, Huang, Ying wrote:
>> From: Huang Ying <ying.huang@intel.com>
>>
>> Now, when the page table is walked in the implementation of
>> /proc/<pid>/pagemap, pmd_soft_dirty() is used for both the PMD huge
>> page map and the PMD migration entries. That is wrong,
>> pmd_swp_soft_dirty() should be used for the PMD migration entries
>> instead because the different page table entry flag is used.
>>
>> Cc: Michal Hocko <mhocko@suse.com>
>> Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
>> Cc: David Rientjes <rientjes@google.com>
>> Cc: Arnd Bergmann <arnd@arndb.de>
>> Cc: Hugh Dickins <hughd@google.com>
>> Cc: "J.r.me Glisse" <jglisse@redhat.com>
>> Cc: Daniel Colascione <dancol@google.com>
>> Cc: Zi Yan <zi.yan@cs.rutgers.edu>
>> Cc: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
>> Signed-off-by: "Huang, Ying" <ying.huang@intel.com>
>
> What is effect of the misbehaviour? pagemap reports garbage?
Yes. pagemap may report incorrect soft dirty information for PMD
migration entries.
> Shoudn't it be in stable@? And maybe add Fixes: <sha1>.
Yes. Will do that in the next version.
> Otherwise, looks good to me.
>
> Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Thanks!
Best Regards,
Huang, Ying
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-10-17 12:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-17 8:18 Huang, Ying
2017-10-17 9:47 ` Anshuman Khandual
2017-10-17 11:21 ` Kirill A. Shutemov
2017-10-17 12:23 ` Huang, Ying [this message]
2017-10-17 12:33 ` Zi Yan
2017-10-17 13:55 ` Huang, Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874lqy7yks.fsf@yhuang-dev.intel.com \
--to=ying.huang@intel.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=dancol@google.com \
--cc=hughd@google.com \
--cc=jglisse@redhat.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=rientjes@google.com \
--cc=zi.yan@cs.rutgers.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox