From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E992C432C0 for ; Fri, 29 Nov 2019 12:10:44 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3248D2086A for ; Fri, 29 Nov 2019 12:10:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=axtens.net header.i=@axtens.net header.b="RmK+wv0p" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3248D2086A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=axtens.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CE7CA6B0585; Fri, 29 Nov 2019 07:10:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C97CC6B0586; Fri, 29 Nov 2019 07:10:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BAD666B0587; Fri, 29 Nov 2019 07:10:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id A430D6B0585 for ; Fri, 29 Nov 2019 07:10:43 -0500 (EST) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with SMTP id 5CEDD62D9 for ; Fri, 29 Nov 2019 12:10:43 +0000 (UTC) X-FDA: 76209198366.18.45AC892 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin18.hostedemail.com (Postfix) with ESMTP id 419FF100FADEB for ; Fri, 29 Nov 2019 12:09:33 +0000 (UTC) X-HE-Tag: lunch48_36398d5be2502 X-Filterd-Recvd-Size: 7560 Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com [209.85.210.194]) by imf36.hostedemail.com (Postfix) with ESMTP for ; Fri, 29 Nov 2019 12:09:32 +0000 (UTC) Received: by mail-pf1-f194.google.com with SMTP id q13so14574156pff.2 for ; Fri, 29 Nov 2019 04:09:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axtens.net; s=google; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=Qm6oKiM2ABO+RifKesimvx+ONcOc9pjFmAlUk+XGKuc=; b=RmK+wv0pWAtIVk3gDw86d6xPm3fd/ePOaadw8wpI5SIfIyvdQy9QQKrfOgcBn/xSem RVFQC3tu4XYZsD0nZnlZ/qFiH1zA+efqOjx8WYFUbBoiVbgnOUe6B5bDVU5PVfCsTY5F G2kdqHW3bN5PZkR/YI3YZkudxUk1tRIT7b28I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=Qm6oKiM2ABO+RifKesimvx+ONcOc9pjFmAlUk+XGKuc=; b=elR0QXWE0P6o6klWEAChBGQOFjoaBhO4TJ2zJ5cTd40HlN+NWwN8R2ctZUqN+njph+ UhMjA7B1DmNP3oWm6Bvy6TU14OAVZPG1z/Y3DJHVAS7VRusl73Sge4wn/fRRRG5FlIy0 1ZQAwLZRdWFCO0Npto8qm1IiTV2VfXBYKL01PD0CEKaM6cjBYrnf285Y4dEfDNFhuekX WskcDWQu0jAm5fWu5ckPWTTYhPAkGBbOtwYPvcc5v+YBkwA/d389UBkOdEXE0QJhxMDK w3ul3c0OTyKwTCZt4VaH8BFzHWuX1Dbx6Z96gvcV2seMubP+u/7ad6sJJIqU3qVrs8I7 GKlg== X-Gm-Message-State: APjAAAWZL1xvYC2z6mT9sLfC9uCPqMTbLubW8lhzMY6LCxoPnLKl/oG5 EkLjFWeC7yN+fUx7oFU6uvxjyw== X-Google-Smtp-Source: APXvYqyOoxv4Fn6O7kpK30eEyZ3WTIVIVniRJX4iEN2aXzT4yNpDehQhUnYXRieB8j+TUqLopRanFA== X-Received: by 2002:a63:4d1f:: with SMTP id a31mr16309174pgb.360.1575029371290; Fri, 29 Nov 2019 04:09:31 -0800 (PST) Received: from localhost (2001-44b8-111e-5c00-4092-39f5-bb9d-b59a.static.ipv6.internode.on.net. [2001:44b8:111e:5c00:4092:39f5:bb9d:b59a]) by smtp.gmail.com with ESMTPSA id q9sm8641213pjb.27.2019.11.29.04.09.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Nov 2019 04:09:30 -0800 (PST) From: Daniel Axtens To: Dmitry Vyukov , Andrey Ryabinin Cc: Qian Cai , kasan-dev , Linux-MM , the arch/x86 maintainers , Alexander Potapenko , Andy Lutomirski , LKML , Mark Rutland , Christophe Leroy , linuxppc-dev , Vasily Gorbik Subject: Re: [PATCH v11 1/4] kasan: support backing vmalloc space with real shadow memory In-Reply-To: References: <20191031093909.9228-1-dja@axtens.net> <20191031093909.9228-2-dja@axtens.net> <1573835765.5937.130.camel@lca.pw> <871ru5hnfh.fsf@dja-thinkpad.axtens.net> <952ec26a-9492-6f71-bab1-c1def887e528@virtuozzo.com> Date: Fri, 29 Nov 2019 23:09:27 +1100 Message-ID: <874kymg9zc.fsf@dja-thinkpad.axtens.net> MIME-Version: 1.0 Content-Type: text/plain X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Dmitry, >> I am testing this support on next-20191129 and seeing the following warnings: >> >> BUG: sleeping function called from invalid context at mm/page_alloc.c:4681 >> in_atomic(): 1, irqs_disabled(): 0, non_block: 0, pid: 44, name: kworker/1:1 >> 4 locks held by kworker/1:1/44: >> #0: ffff888067c26d28 ((wq_completion)events){+.+.}, at: >> __write_once_size include/linux/compiler.h:247 [inline] >> #0: ffff888067c26d28 ((wq_completion)events){+.+.}, at: >> arch_atomic64_set arch/x86/include/asm/atomic64_64.h:34 [inline] >> #0: ffff888067c26d28 ((wq_completion)events){+.+.}, at: atomic64_set >> include/asm-generic/atomic-instrumented.h:868 [inline] >> #0: ffff888067c26d28 ((wq_completion)events){+.+.}, at: >> atomic_long_set include/asm-generic/atomic-long.h:40 [inline] >> #0: ffff888067c26d28 ((wq_completion)events){+.+.}, at: set_work_data >> kernel/workqueue.c:615 [inline] >> #0: ffff888067c26d28 ((wq_completion)events){+.+.}, at: >> set_work_pool_and_clear_pending kernel/workqueue.c:642 [inline] >> #0: ffff888067c26d28 ((wq_completion)events){+.+.}, at: >> process_one_work+0x88b/0x1750 kernel/workqueue.c:2235 >> #1: ffffc900002afdf0 (pcpu_balance_work){+.+.}, at: >> process_one_work+0x8c0/0x1750 kernel/workqueue.c:2239 >> #2: ffffffff8943f080 (pcpu_alloc_mutex){+.+.}, at: >> pcpu_balance_workfn+0xcc/0x13e0 mm/percpu.c:1845 >> #3: ffffffff89450c78 (vmap_area_lock){+.+.}, at: spin_lock >> include/linux/spinlock.h:338 [inline] >> #3: ffffffff89450c78 (vmap_area_lock){+.+.}, at: >> pcpu_get_vm_areas+0x1449/0x3df0 mm/vmalloc.c:3431 >> Preemption disabled at: >> [] spin_lock include/linux/spinlock.h:338 [inline] >> [] pcpu_get_vm_areas+0x1449/0x3df0 mm/vmalloc.c:3431 >> CPU: 1 PID: 44 Comm: kworker/1:1 Not tainted 5.4.0-next-20191129+ #5 >> Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.12.0-1 04/01/2014 >> Workqueue: events pcpu_balance_workfn >> Call Trace: >> __dump_stack lib/dump_stack.c:77 [inline] >> dump_stack+0x199/0x216 lib/dump_stack.c:118 >> ___might_sleep.cold.97+0x1f5/0x238 kernel/sched/core.c:6800 >> __might_sleep+0x95/0x190 kernel/sched/core.c:6753 >> prepare_alloc_pages mm/page_alloc.c:4681 [inline] >> __alloc_pages_nodemask+0x3cd/0x890 mm/page_alloc.c:4730 >> alloc_pages_current+0x10c/0x210 mm/mempolicy.c:2211 >> alloc_pages include/linux/gfp.h:532 [inline] >> __get_free_pages+0xc/0x40 mm/page_alloc.c:4786 >> kasan_populate_vmalloc_pte mm/kasan/common.c:762 [inline] >> kasan_populate_vmalloc_pte+0x2f/0x1b0 mm/kasan/common.c:753 >> apply_to_pte_range mm/memory.c:2041 [inline] >> apply_to_pmd_range mm/memory.c:2068 [inline] >> apply_to_pud_range mm/memory.c:2088 [inline] >> apply_to_p4d_range mm/memory.c:2108 [inline] >> apply_to_page_range+0x5ca/0xa00 mm/memory.c:2133 >> kasan_populate_vmalloc+0x69/0xa0 mm/kasan/common.c:791 >> pcpu_get_vm_areas+0x1596/0x3df0 mm/vmalloc.c:3439 >> pcpu_create_chunk+0x240/0x7f0 mm/percpu-vm.c:340 >> pcpu_balance_workfn+0x1033/0x13e0 mm/percpu.c:1934 >> process_one_work+0x9b5/0x1750 kernel/workqueue.c:2264 >> worker_thread+0x8b/0xd20 kernel/workqueue.c:2410 >> kthread+0x365/0x450 kernel/kthread.c:255 >> ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:352 >> >> >> Not sure if it's the same or not. Is it addressed by something in flight? It looks like this one is the same. There is a patch to fix it: https://lore.kernel.org/linux-mm/20191120052719.7201-1-dja@axtens.net/ Andrew said he had picked it up on the 22nd: https://marc.info/?l=linux-mm-commits&m=157438241512561&w=2 It's landed in mmots but not mmotm, so hopefully that will happen and then it will land in -next very soon! I will look into your other bug report shortly. Regards, Daniel >> >> My config: >> https://gist.githubusercontent.com/dvyukov/36c7be311fdec9cd51c649f7c3cb2ddb/raw/39c6f864fdd0ffc53f0822b14c354a73c1695fa1/gistfile1.txt > > > I've tried this fix for pcpu_get_vm_areas: > https://groups.google.com/d/msg/kasan-dev/t_F2X1MWKwk/h152Z3q2AgAJ > and it helps. But this will break syzbot on linux-next soon.