From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6C6AC4BA24 for ; Wed, 26 Feb 2020 19:08:01 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A4636222C4 for ; Wed, 26 Feb 2020 19:08:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A4636222C4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=xmission.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4DCF66B0006; Wed, 26 Feb 2020 14:08:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 48E9C6B0007; Wed, 26 Feb 2020 14:08:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 37D256B0008; Wed, 26 Feb 2020 14:08:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0094.hostedemail.com [216.40.44.94]) by kanga.kvack.org (Postfix) with ESMTP id 17B4B6B0006 for ; Wed, 26 Feb 2020 14:08:01 -0500 (EST) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id DF43F8245571 for ; Wed, 26 Feb 2020 19:08:00 +0000 (UTC) X-FDA: 76533213120.23.mind26_ba746cbff134 X-HE-Tag: mind26_ba746cbff134 X-Filterd-Recvd-Size: 5395 Received: from out02.mta.xmission.com (out02.mta.xmission.com [166.70.13.232]) by imf04.hostedemail.com (Postfix) with ESMTP for ; Wed, 26 Feb 2020 19:07:59 +0000 (UTC) Received: from in01.mta.xmission.com ([166.70.13.51]) by out02.mta.xmission.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1j722H-0004xQ-Mj; Wed, 26 Feb 2020 12:07:57 -0700 Received: from ip68-227-160-95.om.om.cox.net ([68.227.160.95] helo=x220.xmission.com) by in01.mta.xmission.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.87) (envelope-from ) id 1j722G-0003UI-Hj; Wed, 26 Feb 2020 12:07:57 -0700 From: ebiederm@xmission.com (Eric W. Biederman) To: Catalin Marinas Cc: linux-arm-kernel@lists.infradead.org, Will Deacon , Vincenzo Frascino , Szabolcs Nagy , Richard Earnshaw , Kevin Brodsky , Andrey Konovalov , Peter Collingbourne , linux-mm@kvack.org, linux-arch@vger.kernel.org, Arnd Bergmann References: <20200226180526.3272848-1-catalin.marinas@arm.com> <20200226180526.3272848-10-catalin.marinas@arm.com> Date: Wed, 26 Feb 2020 13:05:52 -0600 In-Reply-To: <20200226180526.3272848-10-catalin.marinas@arm.com> (Catalin Marinas's message of "Wed, 26 Feb 2020 18:05:16 +0000") Message-ID: <874kvdxj73.fsf@x220.int.ebiederm.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-XM-SPF: eid=1j722G-0003UI-Hj;;;mid=<874kvdxj73.fsf@x220.int.ebiederm.org>;;;hst=in01.mta.xmission.com;;;ip=68.227.160.95;;;frm=ebiederm@xmission.com;;;spf=neutral X-XM-AID: U2FsdGVkX1/0F2i/+wSq/VqwOdFbGsprftz56H+SliE= X-SA-Exim-Connect-IP: 68.227.160.95 X-SA-Exim-Mail-From: ebiederm@xmission.com Subject: Re: [PATCH v2 09/19] arm64: mte: Add specific SIGSEGV codes X-SA-Exim-Version: 4.2.1 (built Thu, 05 May 2016 13:38:54 -0600) X-SA-Exim-Scanned: Yes (on in01.mta.xmission.com) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Catalin Marinas writes: > From: Vincenzo Frascino > > Add MTE-specific SIGSEGV codes to siginfo.h. > > Note that the for MTE we are reusing the same SPARC ADI codes because > the two functionalities are similar and they cannot coexist on the same > system. Any chance you can move the v2 notes up into the description or otherwise fix it. The description talks about reusing the ADI codes which is no longer happening. Otherwise the patch looks good. Acked-by: "Eric W. Biederman" > > Cc: Arnd Bergmann > Cc: Eric W. Biederman > Signed-off-by: Vincenzo Frascino > [catalin.marinas@arm.com: renamed precise/imprecise to sync/async] > [catalin.marinas@arm.com: dropped #ifdef __aarch64__, renumbered] > Signed-off-by: Catalin Marinas > --- > > Notes: > v2: > - Dropped the #ifdef __aarch64__. > - Renumbered the SEGV_MTE* values to avoid clash with ADI. > > include/uapi/asm-generic/siginfo.h | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/include/uapi/asm-generic/siginfo.h b/include/uapi/asm-generic/siginfo.h > index cb3d6c267181..7aacf9389010 100644 > --- a/include/uapi/asm-generic/siginfo.h > +++ b/include/uapi/asm-generic/siginfo.h > @@ -229,7 +229,9 @@ typedef struct siginfo { > #define SEGV_ACCADI 5 /* ADI not enabled for mapped object */ > #define SEGV_ADIDERR 6 /* Disrupting MCD error */ > #define SEGV_ADIPERR 7 /* Precise MCD exception */ > -#define NSIGSEGV 7 > +#define SEGV_MTEAERR 8 /* Asynchronous ARM MTE error */ > +#define SEGV_MTESERR 9 /* Synchronous ARM MTE exception */ > +#define NSIGSEGV 9 > > /* > * SIGBUS si_codes