From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92A5CC4363A for ; Wed, 28 Oct 2020 08:30:18 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BE055241A7 for ; Wed, 28 Oct 2020 08:30:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="LP13nQGV"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="cNQ8tTA1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BE055241A7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linutronix.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8D1656B005D; Wed, 28 Oct 2020 04:30:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 881076B0068; Wed, 28 Oct 2020 04:30:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7702A6B006C; Wed, 28 Oct 2020 04:30:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0195.hostedemail.com [216.40.44.195]) by kanga.kvack.org (Postfix) with ESMTP id 482276B005D for ; Wed, 28 Oct 2020 04:30:16 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id C92971EE6 for ; Wed, 28 Oct 2020 08:30:15 +0000 (UTC) X-FDA: 77420661990.23.teeth56_52082b427283 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin23.hostedemail.com (Postfix) with ESMTP id AD4EB37604 for ; Wed, 28 Oct 2020 08:30:15 +0000 (UTC) X-HE-Tag: teeth56_52082b427283 X-Filterd-Recvd-Size: 2483 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by imf32.hostedemail.com (Postfix) with ESMTP for ; Wed, 28 Oct 2020 08:30:15 +0000 (UTC) From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1603873812; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VCmEsSIGXzvsi9jAbfyuG98+Fx4+fgb6AA6gSwGEIa4=; b=LP13nQGV0S1l2VQjphFpxdo4d2AqSpdD39POMDckcJH5iqRRnqbEh8VDQZ51APLoOjADEo m4l3NOSqV+QlAYPBlVKGa3HZkKXgUzWCbkW8y04Heu7YF9ZEmfqrFGnlKDFxk1m8rryzJ4 7Ji0itY8bqGMBDuDsq4XvVmf3j1FoZv0/1EF8KewH95rdMncTToeFzWld8DLeX9tHchKLh EvU/5XO3kL4qALJhVqk6lpk6Y1FddLz7J2bP/jrYziwW+gZoftiU/0DiBa0BHGiap/bKUL DyQ6nd0QOe3CHchmpH+QIOWkoezI3PDq4SSSfxjjhgQUHKTVtG3arbxvL7Eg2Q== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1603873812; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VCmEsSIGXzvsi9jAbfyuG98+Fx4+fgb6AA6gSwGEIa4=; b=cNQ8tTA1FEzeSetii7henu2O3D+SumSLHI5KCVyxFBTXTb5iTCIVJLycHLMh5z72lYf+MQ wGkC67n9xiQCO8Aw== To: qiang.zhang@windriver.com, pmladek@suse.com, tj@kernel.org Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] kthread_worker: re-set CPU affinities if CPU come online In-Reply-To: <20201028073031.4536-1-qiang.zhang@windriver.com> References: <20201028073031.4536-1-qiang.zhang@windriver.com> Date: Wed, 28 Oct 2020 09:30:12 +0100 Message-ID: <874kme21nv.fsf@nanos.tec.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Oct 28 2020 at 15:30, qiang zhang wrote: > From: Zqiang > > When someone CPU offlined, the 'kthread_worker' which bind this CPU, > will run anywhere, if this CPU online, recovery of 'kthread_worker' > affinity by cpuhp notifiers. > > Signed-off-by: Zqiang > --- > v1->v2: > rename variable kworker_online to kthread_worker_online. > add 'cpuhp_node' and 'bind_cpu' init in KTHREAD_WORKER_INIT. > add a comment explaining for WARN_ON_ONCE. How is that addressing any of the comments I made on V1 of this? Thanks, tglx