From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6253C433ED for ; Tue, 20 Apr 2021 04:03:26 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 26F466103E for ; Tue, 20 Apr 2021 04:03:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 26F466103E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5B11F6B0036; Tue, 20 Apr 2021 00:03:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5608D6B006E; Tue, 20 Apr 2021 00:03:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 428486B0070; Tue, 20 Apr 2021 00:03:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0115.hostedemail.com [216.40.44.115]) by kanga.kvack.org (Postfix) with ESMTP id 2B3976B0036 for ; Tue, 20 Apr 2021 00:03:25 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id AC491181AEF32 for ; Tue, 20 Apr 2021 04:03:24 +0000 (UTC) X-FDA: 78051400728.26.173C150 Received: from ozlabs.org (bilbo.ozlabs.org [203.11.71.1]) by imf30.hostedemail.com (Postfix) with ESMTP id 0ADBEE000108 for ; Tue, 20 Apr 2021 04:03:09 +0000 (UTC) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4FPVQt5v9Kz9vDw; Tue, 20 Apr 2021 14:03:18 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ellerman.id.au; s=201909; t=1618891401; bh=ykDn0c4Pei/ni8JeosESXjK9PStd/mFtGxVh8YrZKPo=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=WAzcjt4GF5woknj0LOcFLLaZXQt4dxoP7XPsbd7Tfc1ZG1omi42FFMVoV9nSFqQho Nm9HeadCpbCSiKDCzKxPEin83TkkOVRNfkkriIZRvLAzVPgdswB9tsavwJleQekRLX enavKzaRFnyMjr49Bu8x4BXaAh50ERXzYbqbZnasQSQJjlRWT8GT0o8YyeWj7yNT8H SAQkKiu9Z5cM3IrONxJBmovgdEC2V3CpOs3qXHVGyk37PLNqcK3YziP+GQJMOP3Um8 uEqVHGZl6+7aGF0tu9EUML9m1weR+PZkuPR+Wlqofl74HscYVDBxO8zGG3CBwzRoKJ ca8b0iHu4Cymg== From: Michael Ellerman To: "Matthew Wilcox (Oracle)" , brouer@redhat.com Cc: arnd@kernel.org, grygorii.strashko@ti.com, netdev@vger.kernel.org, ilias.apalodimas@linaro.org, linux-kernel@vger.kernel.org, "Matthew Wilcox (Oracle)" , linux-mips@vger.kernel.org, mhocko@kernel.org, linux-mm@kvack.org, mgorman@suse.de, mcroce@linux.microsoft.com, linux-snps-arc@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, hch@lst.de, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 0/2] Change struct page layout for page_pool In-Reply-To: <20210416230724.2519198-1-willy@infradead.org> References: <20210416230724.2519198-1-willy@infradead.org> Date: Tue, 20 Apr 2021 14:03:18 +1000 Message-ID: <874kg1d2m1.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain X-Stat-Signature: itgj1ubmeuazi1616ch79c6ikiak4njc X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 0ADBEE000108 Received-SPF: none (ellerman.id.au>: No applicable sender policy available) receiver=imf30; identity=mailfrom; envelope-from=""; helo=ozlabs.org; client-ip=203.11.71.1 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1618891389-48435 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: "Matthew Wilcox (Oracle)" writes: > The first patch here fixes two bugs on ppc32, and mips32. It fixes one > bug on arc and arm32 (in certain configurations). It probably makes > sense to get it in ASAP through the networking tree. I'd like to see > testing on those four architectures if possible? Sorry I don't have easy access to any hardware that fits the bill. At some point I'll be able to go to the office and setup a machine that (I think) can test these paths, but I don't have an ETA on that. You and others seem to have done lots of analysis on this though, so I think you should merge the fixes without waiting on ppc32 testing. cheers > > The second patch enables new functionality. It is much less urgent. > I'd really like to see Mel & Michal's thoughts on it. > > I have only compile-tested these patches. > > Matthew Wilcox (Oracle) (2): > mm: Fix struct page layout on 32-bit systems > mm: Indicate pfmemalloc pages in compound_head > > include/linux/mm.h | 12 +++++++----- > include/linux/mm_types.h | 9 ++++----- > include/net/page_pool.h | 12 +++++++++++- > net/core/page_pool.c | 12 +++++++----- > 4 files changed, 29 insertions(+), 16 deletions(-) > > -- > 2.30.2