From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 097AEC4332F for ; Thu, 10 Nov 2022 03:10:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 849E78E0001; Wed, 9 Nov 2022 22:10:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7F8246B0075; Wed, 9 Nov 2022 22:10:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6BFE68E0001; Wed, 9 Nov 2022 22:10:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 5CD7E6B0074 for ; Wed, 9 Nov 2022 22:10:23 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 25CB941549 for ; Thu, 10 Nov 2022 03:10:23 +0000 (UTC) X-FDA: 80116054326.02.A5C36B8 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by imf19.hostedemail.com (Postfix) with ESMTP id 253A81A0004 for ; Thu, 10 Nov 2022 03:10:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1668049822; x=1699585822; h=from:to:cc:subject:references:date:in-reply-to: message-id:mime-version; bh=ShRX+hTWxgwzxN+xhIfLsN8tp5u8u7jmKdcv/JvaJv0=; b=Nt0kppgq5YfIA+XAz7P+5jVnKGUYl6BY6XD/Bb6k+sjxhc89Scp8bU0Z 5D8sgakmOBt0ixTS1uvAJM2PUBOHgPukDDBtpAW6h5N9oVfdXRq1MMHTD Wz+PgD6IoO8qk2toYSo8elRr5/jV72Ub8GOjl9IgAKlbm5lnNwXM9B+O7 RqIYquFbdJRrL9zLfFe90IXETIsSMqS16OPIsLxPLq6I8/9CVOM5900lF iPo7JFGdZdcTdAvxuV4Gv0fbbiKrtJLlsVmroZ51Rr7B8JuJew7dojVdx DvLVUGZBokS6TuHTvTGdylQh6VkH/bs8xDBbaA8n2HCDVzI6LejgjqBfo Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10526"; a="312963961" X-IronPort-AV: E=Sophos;i="5.96,152,1665471600"; d="scan'208";a="312963961" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Nov 2022 19:10:20 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10526"; a="614931300" X-IronPort-AV: E=Sophos;i="5.96,152,1665471600"; d="scan'208";a="614931300" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Nov 2022 19:10:18 -0800 From: "Huang, Ying" To: Miaoqian Lin Cc: Andrew Morton , Wei Xu , "Aneesh Kumar K.V" , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/demotion: Fix NULL vs IS_ERR checking in memory_tier_init References: <20221110030751.1627266-1-linmq006@gmail.com> Date: Thu, 10 Nov 2022 11:09:34 +0800 In-Reply-To: <20221110030751.1627266-1-linmq006@gmail.com> (Miaoqian Lin's message of "Thu, 10 Nov 2022 07:07:51 +0400") Message-ID: <874jv7wln5.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668049822; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GvuG67By9IiJMtX9M+XO/hWkAupYLmnKY/oNnZrZnMg=; b=sA+NIocMfzKSTQhRZh7ksygE5ZSdxIRiq80IRZobxUjKDFQ4MaU/Aa+R45kckJ0c8oWD7z MqHuaeokuiVE1uU9gOGNm2YbOp1OrhzXVvqF6DVu64v6EzFeZ7vgKCyumqf0FcZJhzsj1p NXNbjQ+Jv4/tB/mYFYnf/okS3xx5RQI= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=Nt0kppgq; spf=pass (imf19.hostedemail.com: domain of ying.huang@intel.com designates 134.134.136.65 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668049822; a=rsa-sha256; cv=none; b=QWhp/oCmBH/U01bLIO1VnAxtomn446x5qGLwe1r1C0dxl+BMUoXUPDsTqAMA4plHhvlAwH DHdcfJngq9gTIS7jpirQAjc/HH00EbMAQ99lBWxgXtkyk0bd94Eo+nr+7xIgkWmHjg7D3K 1cNBjqqkct/IxdKhlgj69uW7alCHank= X-Rspamd-Queue-Id: 253A81A0004 X-Rspam-User: X-Rspamd-Server: rspam08 Authentication-Results: imf19.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=Nt0kppgq; spf=pass (imf19.hostedemail.com: domain of ying.huang@intel.com designates 134.134.136.65 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com X-Stat-Signature: 5ze6nih5rgtzhjx7zwkg36zsai11e7u1 X-HE-Tag: 1668049821-998657 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Miaoqian Lin writes: > The alloc_memory_type() function return error pointers on error > instead of NULL. > Use IS_ERR() to check the return value to fix this. > > Fixes: 7b88bda3761b ("mm/demotion/dax/kmem: set node's abstract distance to MEMTIER_DEFAULT_DAX_ADISTANCE") > Signed-off-by: Miaoqian Lin Thanks! Reviewed-by: "Huang, Ying" > --- > mm/memory-tiers.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/memory-tiers.c b/mm/memory-tiers.c > index fa8c9d07f9ce..ac0dae9e54bf 100644 > --- a/mm/memory-tiers.c > +++ b/mm/memory-tiers.c > @@ -645,7 +645,7 @@ static int __init memory_tier_init(void) > * than default DRAM tier. > */ > default_dram_type = alloc_memory_type(MEMTIER_ADISTANCE_DRAM); > - if (!default_dram_type) > + if (IS_ERR(default_dram_type)) > panic("%s() failed to allocate default DRAM tier\n", __func__); > > /*