From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBE1CC64EC4 for ; Thu, 9 Mar 2023 22:54:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 197E66B0078; Thu, 9 Mar 2023 17:54:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 148456B007B; Thu, 9 Mar 2023 17:54:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 00F346B007D; Thu, 9 Mar 2023 17:54:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id E57346B0078 for ; Thu, 9 Mar 2023 17:54:36 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id B8C18120203 for ; Thu, 9 Mar 2023 22:54:36 +0000 (UTC) X-FDA: 80550865752.10.BFF4796 Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by imf15.hostedemail.com (Postfix) with ESMTP id BE129A000A for ; Thu, 9 Mar 2023 22:54:33 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=ellerman.id.au header.s=201909 header.b=qtChMEay; spf=pass (imf15.hostedemail.com: domain of mpe@ellerman.id.au designates 150.107.74.76 as permitted sender) smtp.mailfrom=mpe@ellerman.id.au; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678402474; a=rsa-sha256; cv=none; b=ho+wbR9vIYSTapwE5GeMn/rWu4GtqNkIuJP3VmUgp//TJG4EK7sgB0obbzamKoSRxgrH5v GG+tIVUUrmfHtQJF3376I3CDHZaScLe63FZnLgncXd3K6NbQETp1/MAjRK/bhabGzEhbcu TMseMaVIkFWwMnt/sKbnbKTNIEJmZyU= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=ellerman.id.au header.s=201909 header.b=qtChMEay; spf=pass (imf15.hostedemail.com: domain of mpe@ellerman.id.au designates 150.107.74.76 as permitted sender) smtp.mailfrom=mpe@ellerman.id.au; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678402474; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HnGqhsJTeGjqlPVUTmz3g9ouF0ULtGaBV4DNsEeVxsY=; b=vkUvVnwdazxESlo6nu8TbN368nbg9wNDJzYwgy758nm/OhSatY9MGe5LcpwGCR0dKcG+Bl Y47ekDGRPd4b8HswXLX+RTlUivHQlSj5HR+epEjleZHXYW3WhWUFmSwP4AQ61KmfCIVe93 LqsWZpt84dtDO+D64lessRZuC3ICX30= Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4PXkyW6RNvz4x7s; Fri, 10 Mar 2023 09:54:27 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1678402469; bh=HnGqhsJTeGjqlPVUTmz3g9ouF0ULtGaBV4DNsEeVxsY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=qtChMEayOa7BG3gV8biPN1UquvZjKKHH1PLnOktZLFk+z7+30lmoHFQWG/ybTGOfV Msn+vq0214G/5bCC5sK8YEWC4SONYn3IjVV2gLKa55Cy0vLJqZpwyIgKHr5xpyRlRO 2B59x+JG32iD6Ll1IeACkY+jSFZ42uC6mHr940GQ8rZCqsWJ73oUfODgJNTU1QA4cH /Zt2BN0brA6nfVHnuvaamrjV+75syVJwmQZUAWs6jzdNGb6ONfyH1iskU2QALlqqJR fcr5fnsHZCG3RA30SBInWnaih8rWQ8VzjneqbRw1yHLKc3Q/ihjyNUCZJzzzjHFnUd puglrrgtkl1qg== From: Michael Ellerman To: Baoquan He , linux-kernel@vger.kernel.org Cc: linux-arch@vger.kernel.org, linux-mm@kvack.org, arnd@arndb.de, geert@linux-m68k.org, mcgrof@kernel.org, hch@infradead.org, Baoquan He , linux-alpha@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org Subject: Re: [PATCH v4 3/4] arch/*/io.h: remove ioremap_uc in some architectures In-Reply-To: <20230308130710.368085-4-bhe@redhat.com> References: <20230308130710.368085-1-bhe@redhat.com> <20230308130710.368085-4-bhe@redhat.com> Date: Fri, 10 Mar 2023 09:54:27 +1100 Message-ID: <874jqtpmcc.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain X-Rspam-User: X-Rspamd-Queue-Id: BE129A000A X-Rspamd-Server: rspam01 X-Stat-Signature: 5fpremejp17wmmfqqd3hkcao3qzc8h5u X-HE-Tag: 1678402473-743206 X-HE-Meta: U2FsdGVkX18ORjtNVMLoBsfkvFsUFKSqNQn5O+lXPCn78QCG+yXpMgEqgb19xeDAboqcPOcguiQ7hTLvBjifMaIOxu0M+JEiLbtoOustlyf80TiRzw4WJAUQmGROPs2aYXPlqgh9905NBdeMkmi4fFuSb/9k7tcrJ6HRrjBssMYcpcJFkQ+zP5X6fi6Ups6cYrchgYUtJaE7JhBhZdVljM45IBCsyJV5AVpYO5ke/rDz9VYOBXe9C3VIAU4br4vYJiQbveX+AaxGKdyE2D4DVDgauH+30+dLTTI6brD+Y1gs93BmTeuIcKil34Le9WvTG/BIK+zXJAlRhnIVvR+kh/vBycd/LlcCazPuhxqyEJ0b06w98tINvZmk0rObuwSH6pExqycQK3CrVDW5DDDpCzaI4LbVEjlFRxvoydpKOJdLDzDFCzklxqtLulW0h4tmiQi8lcj69VsHLQGsQ0oeQSZmnLzxHUe5xQVLqzw0vd34gOiBh06vvc5NU/NTQEF5nUewNv1fOqRDBKQHrIpEoOSFGTbQxiBZ8EeXiDZC4bcb7ies227vnMPOUBt1Zb2B2QSHPNOZ836yykUylPsGEbHcJpV6FRqU+DQ746AZTbqF05ToPmdyTiB2RQJD7p+np+L/yMh9FA7BkYf3xjKnuBRbYxEOfmiE29SpyL2dI0QePhiDu9i0p0Ds+pKY3odJXR8PJcC2PutmSKPWBX9+7iHEdCRTolX43YvBgkYFYHCD7K3vUzZnvtErRwMjiwx4ZHtV6XQjQ/xmrg9L2RhWv3HyWd/fw8Cn1zjX19NdV4qNK1xdmRnf1IprcTNSF5BxmdrlAJZ5ncAUd3gzg/Nigaq8gZUS3kEO0CR9XuekEV3droyzza96FzsqERz1WYIGSNJLthdKl/mB0BNDJfZGsLpdn6mQy9TyMr8UpOiFO4+rdvat0FP1h9DAZbwcmp0bj/RCb9vprvM6t2AiH30 U5SrgGpC oxId5jUEXh5KalKSIRDhAoRN0v1JLo0p1nFiDV/ZxjBr39cWktrlIUGRnqdzny4WRrqUUSaGJZQrM6BbXM+A4AtvAVTwtP72YnmOWQ4JXMjpoFkjCd23/1E/GimkD4+doypCM8R7UG8ttQVq0+JRKWNWVvknnnT3vSjq4ldRtfCPrStrJRDzGXhObzBpLTaaKXgyg32qEFIOpJAjYDkToLh/tSUGgaX4Q0sBPdmPCyLefPLxGWMVNMbqQVtIT5p3ZGf905YCrARnF98CQOLgwf8b4dvH3b30LGWmkY4GFPAmyqGSIHfWY1uii5PVVSXB0wquT12hLJ6l6m1V79tDVYCzzmcwKVmPsJgIgID/eKI8lvjgge+5c4eB+iyALu2X7KzkM55Yv1m4wTq0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Baoquan He writes: > ioremap_uc() is only meaningful on old x86-32 systems with the PAT > extension, and on ia64 with its slightly unconventional ioremap() > behavior. So remove the ioremap_uc() definition in architecutures > other than x86 and ia64. These architectures all have asm-generic/io.h > included and will have the default ioremap_uc() definition which > returns NULL. > > This changes the existing behaviour, while no need to worry about > any breakage because in the only callsite of ioremap_uc(), code > has been adjusted to eliminate the impact. Please see > atyfb_setup_generic() of drivers/video/fbdev/aty/atyfb_base.c. > > If any new invocation of ioremap_uc() need be added, please consider > using ioremap() intead or adding a ARCH specific version if necessary. > > Acked-by: Geert Uytterhoeven > Signed-off-by: Baoquan He > Cc: linux-alpha@vger.kernel.org > Cc: linux-hexagon@vger.kernel.org > Cc: linux-m68k@lists.linux-m68k.org > Cc: linux-mips@vger.kernel.org > Cc: linux-parisc@vger.kernel.org > Cc: linuxppc-dev@lists.ozlabs.org > Cc: linux-sh@vger.kernel.org > Cc: sparclinux@vger.kernel.org > --- > Documentation/driver-api/device-io.rst | 9 +++++---- > arch/alpha/include/asm/io.h | 1 - > arch/hexagon/include/asm/io.h | 3 --- > arch/m68k/include/asm/kmap.h | 1 - > arch/mips/include/asm/io.h | 1 - > arch/parisc/include/asm/io.h | 2 -- > arch/powerpc/include/asm/io.h | 1 - Acked-by: Michael Ellerman (powerpc) cheers