From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B613C04FE2 for ; Wed, 9 Aug 2023 14:44:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8076E6B0071; Wed, 9 Aug 2023 10:44:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7B7BA8E0001; Wed, 9 Aug 2023 10:44:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 630CE6B0075; Wed, 9 Aug 2023 10:44:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 4FBC46B0071 for ; Wed, 9 Aug 2023 10:44:39 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 18B1A1C95FB for ; Wed, 9 Aug 2023 14:44:39 +0000 (UTC) X-FDA: 81104837478.17.21BB380 Received: from mail.parknet.co.jp (mail.parknet.co.jp [210.171.160.6]) by imf09.hostedemail.com (Postfix) with ESMTP id 8C9DE140021 for ; Wed, 9 Aug 2023 14:44:35 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf09.hostedemail.com: domain of hirofumi@parknet.co.jp designates 210.171.160.6 as permitted sender) smtp.mailfrom=hirofumi@parknet.co.jp ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691592276; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MOCsRKWVFDQ5+8K52e1Kw/ijj3OYX5HbMPhfQsu89XE=; b=lWeg1L7I0g/mFICT2FvO5QEikRSRoIzvvXTnDdcWzH/W2DElG739UpPRPHGaxeL90c1hwv 6SZ1Rb0JYTwXMLrL8anaG7MMDzgZVZb4ycG1nMWYGgTUPIjVOx8+u8Jijhz957VEZcvrmQ IsLsdpyIeeCi81CN+cyte6RY1z3YYN8= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf09.hostedemail.com: domain of hirofumi@parknet.co.jp designates 210.171.160.6 as permitted sender) smtp.mailfrom=hirofumi@parknet.co.jp ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691592276; a=rsa-sha256; cv=none; b=POtlV2i2VVBT6xMnwMOwWfQYs8W1oVInkb75S3p9Rm0ugvbl2F/vpoBfVBs5kAgHlzCuYl wwyJry/kQmJwabtyeRWxuIIuoLOFhgIuxoytZ8DPFjC/7kAR79K8Ox0OIohZyu5xkBZbi9 EVt1ysWiIXZo+sc5vBeykiUyUnqn0W4= Received: from ibmpc.myhome.or.jp (server.parknet.ne.jp [210.171.168.39]) by mail.parknet.co.jp (Postfix) with ESMTPSA id 593222055FA0; Wed, 9 Aug 2023 23:44:33 +0900 (JST) Received: from devron.myhome.or.jp (foobar@devron.myhome.or.jp [192.168.0.3]) by ibmpc.myhome.or.jp (8.17.2/8.17.2/Debian-1) with ESMTPS id 379EiWdd218003 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 9 Aug 2023 23:44:33 +0900 Received: from devron.myhome.or.jp (foobar@localhost [127.0.0.1]) by devron.myhome.or.jp (8.17.2/8.17.2/Debian-1) with ESMTPS id 379EiV6k197737 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 9 Aug 2023 23:44:31 +0900 Received: (from hirofumi@localhost) by devron.myhome.or.jp (8.17.2/8.17.2/Submit) id 379EiQ5o197730; Wed, 9 Aug 2023 23:44:26 +0900 From: OGAWA Hirofumi To: Jeff Layton Cc: Alexander Viro , Christian Brauner , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , David Howells , Marc Dionne , Chris Mason , Josef Bacik , David Sterba , Xiubo Li , Ilya Dryomov , Jan Harkes , coda@cs.cmu.edu, Tyler Hicks , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Namjae Jeon , Sungjong Seo , Jan Kara , "Theodore Ts'o" , Andreas Dilger , Jaegeuk Kim , Miklos Szeredi , Bob Peterson , Andreas Gruenbacher , Greg Kroah-Hartman , Tejun Heo , Trond Myklebust , Anna Schumaker , Konstantin Komarov , Mark Fasheh , Joel Becker , Joseph Qi , Mike Marshall , Martin Brandenburg , Luis Chamberlain , Kees Cook , Iurii Zaikin , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Sergey Senozhatsky , Richard Weinberger , Hans de Goede , Hugh Dickins , Andrew Morton , Amir Goldstein , "Darrick J. Wong" , Benjamin Coddington , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, v9fs@lists.linux.dev, linux-afs@lists.infradead.org, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org, codalist@telemann.coda.cs.cmu.edu, ecryptfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, ntfs3@lists.linux.dev, ocfs2-devel@lists.linux.dev, devel@lists.orangefs.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-mtd@lists.infradead.org, linux-mm@kvack.org, linux-unionfs@vger.kernel.org, linux-xfs@vger.kernel.org Subject: Re: [PATCH v7 05/13] fat: make fat_update_time get its own timestamp In-Reply-To: <7edc9239f73022b9c2a1d3f4f946153f85f94739.camel@kernel.org> (Jeff Layton's message of "Wed, 09 Aug 2023 10:22:54 -0400") References: <20230807-mgctime-v7-0-d1dec143a704@kernel.org> <20230807-mgctime-v7-5-d1dec143a704@kernel.org> <87msz08vc7.fsf@mail.parknet.co.jp> <52bead1d6a33fec89944b96e2ec20d1ea8747a9a.camel@kernel.org> <878rak8hia.fsf@mail.parknet.co.jp> <7edc9239f73022b9c2a1d3f4f946153f85f94739.camel@kernel.org> Date: Wed, 09 Aug 2023 23:44:26 +0900 Message-ID: <874jl88ed1.fsf@mail.parknet.co.jp> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Queue-Id: 8C9DE140021 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: qs8ec1siyeeofjawdd6589ufrac9g6wd X-HE-Tag: 1691592275-246810 X-HE-Meta: U2FsdGVkX19RN1T5cREANC5YbOwjCxLkZbdGpr9N9sq1DUXOyEFhgjhUIjQl6aE1eRH1mlUX9wMwOdraF6vmU86q3NYLsWTtHTWKxSOHyJhAnSDi5UBAvHhwtSx/H/9GsXBc+SFxBZ+pD5/kNDUgguqgsLqU0ipiE6h4qPAjztvCIsV+CtkZCWlP3tNNzjN+dwR7TBslhub2cf36Ia//VHK+NXxxiAIiEYThHDuLp6sUnOuDp/7BMAqCveFK6S0xsW9oaCfiaENJ46IHhmeXRAwilDydlX8RaCnP8ZqQWZJIlJAPjDnT6YYpnUesMzzDOeAO2grvf4eI16FRamgjIHuhjUkgaLxqq1syh95courCHUsM6oCCfL+Q0UmNRp/mNsP/sbrenP2oLCgLk9feV7mSJXuczlIHGw7CEFMVihJEJofik9la2NEXiCokWKIuU9KtHbnHV5BrEj6Oak3fdAorvXo+MwRSb7I6vPHukxqp+JCZisSc0cVwkSZfUWte1FSN9WYYKDU4lx0stn2XWOIy/kU+j0hI9h5RhDNHfbMXDnr61NN1hBma4D5+I6omKoRRBpLnEA0SLtooWw3leQ+0X2IlQCRf+5E8s53exgUCf3K/HbXy8FEx7LC8vZleW18FawQLV052tS20YVcTimvfU4hQ58vfP3/SU/yl43SEBxHj5U2je62qC4x2XI9LC6AZJmewJtVLl0+xpS/ddn6brV2nr7ayqBVO9pEnjKUtmplTiGnWq9drcwOFNUV0nDagnWmfFZMTk/vg0cIlOrliGnDf9ImH8cFgX98pZmuHvSqR0m6jW6hsN4kj+e3TAtECR6mJk4+xYMoitr8KX/OC0UDNLaT5RYiz43qJ6qkFZ2kv0RLzCBwFuX4N4Pk5yCOXrYYoxqvdb6NKkzf/erZJSFM84vUxmY+jp1pW1W6VurDWm0KTo8MMNxhIBayj7ra5VqVfTSqlKDYBiNd xESkV5c1 +lKxXA9kIQHL+QhtXLf7bf/IODeqVNr1ygMlUIgZigvzijiQ1l7R55gE6ynHY2xncuUQw43YgGm/Ew/jgKpkiPpavqPzrmTsOSsdRljxmn1tgwHGuE6nQ22p/rdsJbTKYeNhdNMt8NYTrhA2dg7Pklavc/1lY4+2pKRaRlogjTfXkt5JRKhZE8SqgQ3HJDQ3si5psJrpW2gsKhq0Njkj5puLl6JExkP3YrbDjxLRZqAI52jDSA/z3ApbNoinTZU+k6GdjoUzPXkoUp/k0lG7m6rFm0i/oAngyODq1FORw58HT9jM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Jeff Layton writes: > I'm a little confused too. Why do you believe this will break > -o relatime handling? This patch changes two things: > > 1/ it has fat_update_time fetch its own timestamp (and ignore the "now" > parameter). This is in line with the changes in patch #3 of this series, > which explains the rationale for this in more detail. > > 2/ it changes fat_update_time to also update the i_version if any of > S_CTIME|S_MTIME|S_VERSION are set. relatime is all about the S_ATIME, > and it is specifically excluded from that set. > > The rationale for the second change is is also in patch #3, but > basically, we can't guarantee that current_time hasn't changed since we > last checked for inode_needs_update_time, so if any of > S_CTIME/S_MTIME/S_VERSION have changed, then we need to assume that any > of them may need to be changed and attempt to update all 3. > > That said, I think the logic in fat_update_time isn't quite right. I > think want something like this on top of this patch to ensure that the > S_CTIME and S_MTIME get updated, even if the flags only have S_VERSION > set. > > Thoughts? I'm not talking about "relatime" at all, I'm always talking about "lazytime". I_DIRTY_TIME delays to update on disk inode only if changed timestamp. But you changed it to I_DIRTY_SYNC, i.e. always update on disk inode by timestamp. Thanks. > ---------------------8<----------------------- > > diff --git a/fs/fat/misc.c b/fs/fat/misc.c > index 080a5035483f..313eef02f45c 100644 > --- a/fs/fat/misc.c > +++ b/fs/fat/misc.c > @@ -346,15 +346,21 @@ int fat_update_time(struct inode *inode, int flags) > if (inode->i_ino == MSDOS_ROOT_INO) > return 0; > > - if (flags & (S_ATIME | S_CTIME | S_MTIME)) { > - fat_truncate_time(inode, NULL, flags); > - if (inode->i_sb->s_flags & SB_LAZYTIME) > - dirty_flags |= I_DIRTY_TIME; > - else > - dirty_flags |= I_DIRTY_SYNC; > - } > + /* > + * If any of the flags indicate an expicit change to the file, then we > + * need to ensure that we attempt to update all of 3. We do not do > + * this in the case of an S_ATIME-only update. > + */ > + if (flags & (S_CTIME | S_MTIME | S_VERSION)) > + flags |= S_CTIME | S_MTIME | S_VERSION; > + > + fat_truncate_time(inode, NULL, flags); > + if (inode->i_sb->s_flags & SB_LAZYTIME) > + dirty_flags |= I_DIRTY_TIME; > + else > + dirty_flags |= I_DIRTY_SYNC; > > - if ((flags & (S_VERSION|S_CTIME|S_MTIME)) && inode_maybe_inc_iversion(inode, false)) > + if ((flags & S_VERSION) && inode_maybe_inc_iversion(inode, false)) > dirty_flags |= I_DIRTY_SYNC; > -- OGAWA Hirofumi